[C+ Checklist Needs Completion] [$500] Status - The colon between hours and minutes is misaligned

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to Settings > Profile > Status
2. Click Clear after > Custom > Time

Expected Result:

The time is displayed properly

Actual Result:

The colon between hours and minutes in Status is misaligned

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f22c871c339d732d
• Upwork Job ID: 1744875536384045056
• Last Price Increase: 2024-01-10
• Automatic offers:
• shubham1206agra | Contributor | 28092023

Issue Owner

Current Issue Owner: @greg-schroeder

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Status - The colon between hours and minutes is misaligned on native (no issue on web)

What is the root cause of that problem?

offending PR: #33221

web is using updated style name (touchableInputWrapperStyle)

App/src/components/TextInput/BaseTextInput/index.tsx

Line 291 in abd28cd

touchableInputWrapperStyle,

But native is still using old style name (containerStyles)

App/src/components/TextInput/BaseTextInput/index.native.tsx

Line 276 in abd28cd

containerStyles,

What changes do you think we should make in order to solve the problem?

replace containerStyles with touchableInputWrapperStyle

[roryabraham]

Not sure why this is unassigned, I guess I'll grab it

[roryabraham]

It was missing the Engineering label

[mkhutornyi]

Not sure why this is unassigned, I guess I'll grab it

That's because this GH was created while github was down https://www.githubstatus.com/history

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f22c871c339d732d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[roryabraham]

Thanks for the proposal @mkhutornyi, when do you think you'll be able to have a PR ready?

[mkhutornyi]

I will raise PR in an hr

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add missing containerStyles in web TextInput container #34555

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment automatic offer (Contributor)
• @mkhutornyi requires payment (Needs manual offer from BZ)

[greg-schroeder]

Amended offers sent to @mkhutornyi and @shubham1206agra

Can you please complete the checklist above @shubham1206agra? Thanks!

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Rename style container for the TextInput #33221
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/33221/files#r1471135719
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
• [@shubham1206agra] Determine if we should create a regression test for this bug. No as this was deploy blocker.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[shubham1206agra]

@greg-schroeder #34385 had happened due to improper sync in margelo@1290c7c. But hadn't been detected before we made changes in this issue (which is basically a syncing the PR correctly with web counterpart).

Can you please not apply regression cut here as per above?

[melvin-bot]

@greg-schroeder @thienlnam @roryabraham @shubham1206agra @mkhutornyi this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

@greg-schroeder, @thienlnam, @roryabraham, @shubham1206agra, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

@roryabraham @thienlnam can you confirm this for me? #34136 (comment)

Should this be a reduced payment or not?

[mkhutornyi]

P.S. The root cause existed before and our fix just revealed it. We fixed it too as a follow-up so no other contributors were involved and there's no overpayment for this issue.

[roryabraham]

@greg-schroeder – confirmed, this should not be a reduced payment. The regression was introduced by https://github.com/Expensify/App/pull/33221/files#diff-a96e6554e48aa6637ea884224e6943a1dabc067fabd173015072164bac3e96a6 and neither @shubham1206agra nor @mkhutornyi were involved.

[greg-schroeder]

Okay got it, thanks @roryabraham! It was just hard for me to tell and I wanted to be sure. I'll adjust the payments accordingly

[greg-schroeder]

@shubham1206agra paid you $500 (gave you a $250 bonus on the original offer)

@mkhutornyi amended your offer to $500, so please accept and I'll pay you ASAP

[mkhutornyi]

@greg-schroeder I haven't got offer yet. Can you please share screenshot?

[greg-schroeder]

@mkhutornyi I withdrew it and tried again - can you look?