[$500] BA - When page is reloaded in any form page, "Open in app" banner turns dark mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: Cannot test on prod
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must have New Expensify app installed and set light mode

1. Go to Settings > Workspace > Bank account
2. Start the add bank account flow
3. In any form page, reload the page

Expected Result:

The "Open in app" banner should remain in light mode

Actual Result:

The "Open in app" banner turns to dark mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6336784_1704813052853.Cumh5666_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b0434639aab4eb51
• Upwork Job ID: 1745355229456834560
• Last Price Increase: 2024-01-11
• Automatic offers:
• ishpaul777 | Contributor | 28094255

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When page is reloaded in any form page, "Open in app" banner turns dark mode

What is the root cause of that problem?

App/src/components/CustomStatusBarAndBackground/index.tsx

Lines 97 to 100 in 5df6055

	if (newStatusBarStyle !== statusBarStyle) {
	updateStatusBarAppearance({statusBarStyle: newStatusBarStyle});
	setStatusBarStyle(newStatusBarStyle);
	}

☝️ here the status bar color is only changes when newStatusBarStyle !== statusBarStyle which seems to be wrong conditional

offending PR- #33200

What changes do you think we should make in order to solve the problem?

Change it back to what it was before:

           if (newStatusBarStyle === statusBarStyle) {
                updateStatusBarAppearance({backgroundColor: currentScreenBackgroundColor});
            } else {
                updateStatusBarAppearance({backgroundColor: currentScreenBackgroundColor, statusBarStyle: newStatusBarStyle});
                setStatusBarStyle(newStatusBarStyle);
            }

I am available to raise a quick PR as this is a Deploy blocker

[aimane-chnaif]

@ishpaul777 the proposal makes sense (not tested) but how can you show smart banner in dev?

[ishpaul777]

this is reporducable for status bar on simulator, smart banner just uses status bar color

[aimane-chnaif]

@ishpaul777's proposal looks good and tests well.
cc: @bondydaa

Simple repro step:

1. Be in light mode
2. Open any chat
3. Refresh app

[bondydaa]

if this was caused by #33200 then it's not a blocker b/c that was deployed to prod it looks like.

I posted on on that issue to get @roryabraham and @situchan 's 👀 on it but going to remove the blocker for now.

[aimane-chnaif]

right, already in production

Reproducible in production?: Cannot test on prod - this is the only reason for marking as deploy blocker I think

[aimane-chnaif]

cc: @chrispader since you removed backgroundColor in status bar

[ishpaul777]

This is reproducible on production also, so I think this can be treated as usual bug

trim.431911ED-6803-4DE6-8D89-52814790F05A.MOV

[roryabraham]

I think @ishpaul777's proposal looks good.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b0434639aab4eb51

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ishpaul777]

Thanks for assignment. PR will be up within 24hrs

[roryabraham]

Looks like @parasharrajat will be back next week, and I think we can wait until then for this PR

[melvin-bot]

@parasharrajat, @roryabraham, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

Looks like @parasharrajat is back and should get to the PR soon

[roryabraham]

I see review activity in the last 12 hours, so review is ongoing

[parasharrajat]

PR close to merge.

[roryabraham]

PR merged 🚀

[melvin-bot]

@parasharrajat, @roryabraham, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ishpaul777]

PR is merged and deployed to prod

[ishpaul777]

not overdue

[abekkala]

self-assigning to get payments sent now that regression period is over.

[abekkala]

PAYMENT SUMMARY:

• Fix: @ishpaul777 [$500] Offer Link
• PR Review: @parasharrajat [$500] - PAYMENT IN NEWDOT

[abekkala]

@ishpaul777 payment sent and contract ended - thank you! 🎉

[parasharrajat]

@abekkala Feel free to close it. I will request later. Thanks.

[parasharrajat]

Payment requested as per #34154 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat