[$500] Web-Bank Account-Error message disappears when navigate back to Company information page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check prod
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause -Internal Team
Slack conversation:

Issue found when executing PR #33865

Action Performed:

1. Go to Workspace > Bank account > Connect manually
2. Enter routing and account number >> Continue
3. Enter emojis in Legal business name, Company address and City fields
4. Verify that Invalid errors show for these fields
5. Navigate back to Connect bank account page
6. Click Continue

Expected Result:

Error messages Company information page should remain when user navigates back there

Actual Result:

Error message disappears when navigate back to Company information page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6337125_1704834699463.Recording__1722.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aac2f98317031f8d
• Upwork Job ID: 1745116901033091072
• Last Price Increase: 2024-01-31

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

This does not happen on production from my testing, so it seems like a legit deploy blocker if we want to block on it.

[AndrewGable]

@grgia @parasharrajat @tienifr - Would we like to move forward with a fix or revert?

[thienlnam]

I don't think this needs to be a blocker - I'm not sure if it ever retained the error if you navigate to a different page since I can reproduce on production with a different field error

This is what happens on production with a different error (not emojis). We have the same outcome

295448886-0974abfa-e2dc-4608-8b09-c6ef334c860a.mov

[parasharrajat]

I don't think #33865 is responsible for this issue in any way. We just added another validation for emoji. Error handling logic was not touched.

Also, this is how the form works for now where we are saving drafts. A possible solution can be to prevent saving drafts when there is an error on the field i.e. Only save drafts when the value passes validation. This is a feature change.

Or do nothing. Pressing submit will trigger the validation again.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aac2f98317031f8d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[AndrewGable]

Adding @kevinksullivan to figure out if/how we want to fix this!

[abdulrahuman5196]

Thank you. Do let me know if we want to fix this issue.

[melvin-bot]

@AndrewGable, @kevinksullivan, @abdulrahuman5196 Huh... This is 4 days overdue. Who can take care of this?

[AndrewGable]

@kevinksullivan any thoughts?

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Web-Bank Account-Error message disappears when navigate back to Company information page

What is the root cause of that problem?

• Once we navigate back to Company information page, the validate function is not called (because there is no blur, submit actions, ... that will trigger the validate function), so the error message disappears. (Need to confirm the expected behavior here)

There is an additional bug:

• When we navigate back to Company information page, then focus on Company address, then focus on Phone number, only the Company address is validated, and the Legel business name is not validated.
• RCA: We only validate the input that we have touched, in this case, the Legal business name was not touched before, so it is not validated.

What changes do you think we should make in order to solve the problem?

• This change will fix the There is an additional bug that I mentioned above.
• We have a logic that will set the initial value for the inputs below:
  

  App/src/components/Form/FormProvider.js

  Line 120 in b542031

  const [inputValues, setInputValues] = useState(() => ({...draftValues}));

• So, with the input having an empty initial value, we should treat it as being touched. Do it by updating the above to:

        const [inputValues, setInputValues] = useState(() => {
            const draftValuesKeys = _.keys(draftValues);
            draftValuesKeys.forEach((key) => {
                if (draftValues[key]) {
                    setTouchedInput(key);
                }
            });
            return {...draftValues};
        });

• Then

What alternative solutions did you explore? (Optional)

• NA

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Adding @kevinksullivan to figure out if/how we want to fix this!

@kevinksullivan Could you kindly check on this?

[melvin-bot]

@AndrewGable @kevinksullivan @abdulrahuman5196 this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@AndrewGable, @kevinksullivan, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@AndrewGable, @kevinksullivan, @abdulrahuman5196 Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@AndrewGable @kevinksullivan @abdulrahuman5196 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@AndrewGable, @kevinksullivan, @abdulrahuman5196 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@AndrewGable, @kevinksullivan, @abdulrahuman5196 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

This issue has not been updated in over 14 days. @AndrewGable, @kevinksullivan, @abdulrahuman5196 eroding to Weekly issue.

[DylanDylann]

@kevinksullivan Please help check this comment once you have a chance

[abdulrahuman5196]

Bump @kevinksullivan / @AndrewGable

[kevinksullivan]

Sorry I missed this. But I don't think this is worth fixing, as these patterns are being changed to one-be-one in other projects as is. Going to close this out.