Message didn’t show up in #social as unread in LHN, but I got the email notification. ie. LHN is not updating from posts in #social til it's clicked on

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704231385914329

Action Performed: (Updated by @mallenexpensify on Jan 17)

Precondition: must have access to #social channel in NewDot on the Expensify Chat workspace (hence why this needs to be internal, Matt A hasn't been able to reproduce in other rooms)

1. Have focus on a report that isn't #social
2. Have others post to #social or just wait 15 mins for chats to come in, which is usually pretty frequently

Expected Result:

New chats to show in LHN for the #social room

Actual Result:

New chat don't show in LHN until the chat is clicked on, then chats load in the main #social report and LHN updates.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01059dcd731dd4aa05
• Upwork Job ID: 1747761033220931584
• Last Price Increase: 2024-01-17

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mallenexpensify]

@MitchExpensify if this never happens to you, will you unassign and put me on as BZ? Thx

[MitchExpensify]

Still unable to reproduce reliably https://expensify.slack.com/archives/C049HHMV9SM/p1705174729264039?thread_ts=1704231385.914329&cid=C049HHMV9SM

[MitchExpensify]

Switching to Weekly while we figure out how to reproduce

[mallenexpensify]

If I had to guess, the repro step involves putting your computer to sleep or closing the lid.
I can most-reliably reproduce it with the #social room.

[MitchExpensify]

Tried closing the lid and sleeping in a variety of ways to no success..

I think I can only close this issue at this point and we can reopen if we are able to reliable reproduce

[mallenexpensify]

Gonna take over for ya Mitch since it keep happening to me, especially with #social
Below you can see what's supposed to be the latest message in #social but, it's not, when you click it, the chat updates and shows the latest chat.

2024-01-16_17-17-53.mp4

[mallenexpensify]

It's not just #social, just happened with chat with Scott too, got a desktop notification 20 mins ago, noticed it didn't show in LHN, loaded once I clicked it

[mallenexpensify]

Also being discussed here

[mallenexpensify]

Tested in/on a test room and wasn't able to repro. Wonder if it's because #social has a lot of chats? files?

[kadiealexander]

Just adding in here that I experience it too - persistently always with #social, but inconsistently with other chats as well. It was worst when we were having issues during harvesting (#fireroom-2024-01-10-site-slowness). And it's definitely worse for chats that have a lot of content.

2024-01-17_16-49-34.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01059dcd731dd4aa05

[marcaaron]

There are a lot of potential things to look into. Generally speaking, it is very hard (maybe impossible?) to confirm the delivery of an update from the server to the client in realtime (or after the fact). If you didn't see the LHN update but got an email then the basic problem would logically be one of these:

• A. Got the update, but something prevented the LHN from updating (possible but unlikely)
• B. Never got the update

B has another layer of complexity because we have "reliable updates" now which means that if you miss an update we should be sending you those updates at some point. I think we don't really do that until you reconnect from being offline or take some other kind of action in the app. So it could be that you just "missed an update" and the app is working how it's supposed to work when that happens.

[marcaaron]

This could also explain it https://expensify.slack.com/archives/C0671JDRKQW/p1706062397300099?thread_ts=1706048639.315449&cid=C0671JDRKQW

[mallenexpensify]

Thanks for the deets and especially the link. I commented there, asking for an update once I can test via staging.

Also also ran into another issue of #social not updating

• Send message in iOS
• Stay on the screen with the keyboard and compose box showing
• Ask someone else to confirm once a new post is added after yours
• Observe your message is the last shown on iPhone.

[mallenexpensify]

Random note... I noticed when I started up this morn and went to #social, the chat in LHN, the one that initially showed when I went to #social then the one that loaded were all different.

Also... will test on Monday, from the thread Marc linked above

[mallenexpensify]

Def doesn't seem to be getting better, I've updated NewDot 4 times today and am continually testing, both Flo and Scott have run into issues today too. https://expensify.slack.com/archives/C049HHMV9SM/p1706569754923139?thread_ts=1706551202.735269&cid=C049HHMV9SM

Checking in #ngineering https://expensify.slack.com/archives/C03SSAQ7P/p1706569735098989

[aldo-expensify]

Maybe this is related to what is being fixed here: https://github.com/Expensify/Web-Expensify/pull/40434

AddComment can crash if the chants has many participants. Maybe sometimes it crashes before sending out the onyx updates?

[mallenexpensify]

Another (potentially) interesting bit. I closed/quit NewDot last night. When I opened it this morn, it showed an old chat in LHN or #social. So, even with a clean/fresh instance, it's still not loading and showing correctly.

Thanks for the comment @aldo-expensify , I'm going to follow that PR.

[aldo-expensify]

Thanks for the comment @aldo-expensify , I'm going to follow that PR.

From my testing yesterday, even if AddComment doesn't crash anymore, the push events still don't arrive for big chats, so that PR may not be the final solution

[mallenexpensify]

the push events still don't arrive for big chats,

Is this specific to Pusher?
Also, possibly off topic a bit, if the push event doesn't happen for a big chat, does that affect it showing in LHN and also in the main chat? (there's a bug where a bunch of chats from a couple weeks ago don't show in #social, they disappeared)

[aldo-expensify]

does that affect it showing in LHN and also in the main chat?

I think the bug makes you miss the message itself and the latest visible message in the LHN (both updates come from the pusher when someone sends a message).

bunch of chats

Are you referring to "messages"? are you saying that they sent a message in social that failed to be posted?

[mallenexpensify]

This is the other bug (that I don't think is directly related but ¯_(ツ)_/¯ )

• [$1000] #Room - When scrolling up in a room a weird mix of old chats show up from different dates. ie. chats are missing.  #34687

[aldo-expensify]

I can confirm that messages in #social are throwing errors:

Log of the command running out of memory: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%2284dc4505deef2dab-YVR%22)+AND+timestamp:[2024-01-30T18:54:56.360Z+TO+2024-01-30T20:54:56.360Z]&index=logs_expensify-026534

This does allow the message to be posted (saved in the database), but the pusher events are not sent so no one gets notified/updated with the new message

[aldo-expensify]

This is the other bug (that I don't think is directly related but ¯_(ツ)_/¯ )

• [$500] #Room - When scrolling up in #social Room a weird mix of old chats show up from different dates #34687

that looks different, but can't be certain until investigated :P

[mallenexpensify]

I can confirm that messages in #social are throwing errors:

ooooh, and the PR is fixing the AddComment bug, right ? so there's a good chance that PR will help or fix things, right?!?!

[aldo-expensify]

ooooh, and the PR is fixing the AddComment bug, right ? so there's a good chance that PR will help or fix things, right?!?!

Apparently it is not fixing it completely. In my local testing of the PR, the command doesn't crash anymore, but I still don't get the pusher events. I haven't investigated why the pusher events are still getting lost.

[melvin-bot]

@akinwale @mallenexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[mallenexpensify]

ooooh, i got a notification and #social updated in LHN. I unsure if it's consistent though so will keep checking/testing

Confirming I have notifications set to immediately too

[mallenexpensify]

Shared in #expensify-bugs
https://expensify.slack.com/archives/C049HHMV9SM/p1706818982723529?thread_ts=1704231385.914329&cid=C049HHMV9SM

[mallenexpensify]

Tracked another ~dozen updates in #social and it appears that I'm receiving the desktop notification for all chats and that LHN is updating for each comment.

[melvin-bot]

@akinwale, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

Closing, issue has been fixed,