[TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript #34374

VickyStash · 2024-01-11T16:07:15Z

Details

[TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript

Fixed Issues

$ #31973
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Make sure that the Money Request preview looks the same way as before.

Manual Money request

Create a Manual Money request to any user and go to the chat with that user.
Make sure Report Preview looks okay - check currency and amount of money.
Tap on the Report Preview - make sure navigation works

Scan Money request

Create a Scan Money request to any user.
Make sure Report Preview looks okay - it should have receipt image and Receipt scan in progress... text
Tap on the Report Preview - make sure navigation works
Check it after scanning is finished, make sure the amount/currency looks as expected.

Distance Money request

Create a Distance Money request to any workspace.
Make sure Report Preview looks okay: it will show default image for a couple of seconds, after that the map with the route should appear. Make sure distance and amount of money looks ok.
You can also see Pay button, check if it works as expected.
Tap on the Report Preview - make sure navigation works.

Mixed Money request

Create several different money requests to any user and workspace.
Go to the relevant user chat and make sure that grouped report preview looks okay, tap on it to check navigation
Go to the relevant workspace chat and make sure that grouped report preview looks okay, tap on it to check navigation

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

src/components/ReportActionItem/ReportPreview.tsx

…omponent # Conflicts: # src/libs/ReportUtils.ts # src/types/onyx/OriginalMessage.ts

filip-solecki

LGTM

melvin-bot · 2024-01-15T13:42:06Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…omponent # Conflicts: # src/components/ReportActionItem/ReportPreview.tsx

…omponent # Conflicts: # src/libs/ReportUtils.ts # src/pages/home/report/ContextMenu/ReportActionContextMenu.ts # src/types/onyx/OriginalMessage.ts

…omponent # Conflicts: # src/components/ReportActionItem/ReportPreview.tsx # src/libs/ReportUtils.ts # src/types/onyx/OriginalMessage.ts

VickyStash · 2024-01-18T08:10:34Z

@situchan kind bump 🙂

…omponent # Conflicts: # src/components/ReportActionItem/ReportPreview.tsx

…omponent

situchan · 2024-01-22T09:14:38Z

reviewing today

…omponent

blazejkustra

Minor comments, don't want to stop this PR, LGTM!

blazejkustra · 2024-01-23T12:11:19Z

src/types/onyx/TransactionViolation.ts

@@ -31,7 +31,7 @@ type TransactionViolation = {
    };
 };

-type TransactionViolations = Record<string, TransactionViolation>;
+type TransactionViolations = TransactionViolation[];


Are you sure about this change?

This type is used in TransactionViolations collection. And a collection of TransactionViolations is a collection of arrays, not objects

This change is correct. Good catch!

src/components/ReportActionItem/ReportPreview.tsx

…omponent # Conflicts: # src/components/ReportActionItem/ReportPreview.tsx # src/libs/ReportUtils.ts

VickyStash · 2024-01-24T09:11:50Z

@situchan kind bump 🙂

situchan · 2024-01-24T10:34:04Z

src/types/onyx/TransactionViolation.ts

@@ -31,7 +31,7 @@ type TransactionViolation = {
    };
 };

-type TransactionViolations = Record<string, TransactionViolation>;
+type TransactionViolations = TransactionViolation[];


This change is correct. Good catch!

situchan · 2024-01-24T10:40:10Z

src/components/ReportActionItem/ReportPreview.tsx

+    containerStyles,
+    contextMenuAnchor,
+    transactions,
+    transactionViolations,


Why don't we keep original default values?
i.e. iouReport = {}, chatReport = {}, transactions: {}, transactionViolations: {violations: []}

@situchan Since it all are onyx values they have null in their typing. That's mean that cases where the value is null will be handled by the app anyway (with optional chaining, conditions), so no need in default values.

…omponent

VickyStash · 2024-01-26T12:13:19Z

@situchan kind bump 🙂

situchan · 2024-01-28T18:45:51Z

@VickyStash there's conflict

situchan · 2024-01-28T18:47:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…omponent # Conflicts: # src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

VickyStash · 2024-01-29T08:09:53Z

@situchan conflicts are resolved, all yours!

situchan

melvin-bot · 2024-01-29T11:56:52Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31973 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

VickyStash · 2024-01-30T07:49:54Z

It looks like after merging main this PR started to cause lint and TS errors, I'm preparing a follow-up to resolve it!

OSBotify · 2024-01-31T02:57:14Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-01-31T04:11:11Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T04:37:28Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-31T22:48:21Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[TS migration] Migrate 'ReportActionItemReportPreview.js' component

96ab013

kubabutkiewicz approved these changes Jan 12, 2024

View reviewed changes

src/components/ReportActionItem/ReportPreview.tsx Outdated Show resolved Hide resolved

Reuse PaymentMethodType in other places

273406e

fabioh8010 approved these changes Jan 12, 2024

View reviewed changes

filip-solecki reviewed Jan 15, 2024

View reviewed changes

src/components/ReportActionItem/ReportPreview.tsx Outdated Show resolved Hide resolved

VickyStash added 2 commits January 15, 2024 13:51

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

cdd6480

…omponent # Conflicts: # src/libs/ReportUtils.ts # src/types/onyx/OriginalMessage.ts

Remove extra double negation, fix lint error

ef8050c

filip-solecki approved these changes Jan 15, 2024

View reviewed changes

VickyStash marked this pull request as ready for review January 15, 2024 13:42

VickyStash requested a review from a team as a code owner January 15, 2024 13:42

melvin-bot bot removed the request for review from a team January 15, 2024 13:42

melvin-bot bot requested a review from situchan January 15, 2024 13:42

VickyStash added 8 commits January 16, 2024 13:14

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

a40a0ee

…omponent # Conflicts: # src/components/ReportActionItem/ReportPreview.tsx

TS fixes after merging main

449e691

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

fdb6a9a

…omponent # Conflicts: # src/libs/ReportUtils.ts # src/pages/home/report/ContextMenu/ReportActionContextMenu.ts # src/types/onyx/OriginalMessage.ts

Use ContextMenuAnchor type for anchor typing

23c94b6

Fix lint error

b2ca9a6

Fix lint error in import

a53da9d

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

d24481a

…omponent # Conflicts: # src/components/ReportActionItem/ReportPreview.tsx # src/libs/ReportUtils.ts # src/types/onyx/OriginalMessage.ts

Fix ts error

ed8e47e

VickyStash added 4 commits January 19, 2024 09:07

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

a0eb3c7

…omponent # Conflicts: # src/components/ReportActionItem/ReportPreview.tsx

Update TransactionViolations type

2ccf45f

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

48ccf59

…omponent

TS fixes after merging main

7910c46

VickyStash added 3 commits January 23, 2024 10:02

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

1e4952b

…omponent

Fix TS issue

0110446

Update image typing

ed0c95d

VickyStash added 2 commits January 23, 2024 10:40

Fix lint error

4fcb65b

Fix lint error

033aaa1

blazejkustra approved these changes Jan 23, 2024

View reviewed changes

Reuse ContextMenuAnchor type, use TranslationPaths type

2189e2f

blazejkustra approved these changes Jan 23, 2024

View reviewed changes

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

6b5e775

…omponent # Conflicts: # src/components/ReportActionItem/ReportPreview.tsx # src/libs/ReportUtils.ts

situchan reviewed Jan 24, 2024

View reviewed changes

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

e98645f

…omponent

Merge branch 'main' into ts-migration/reportActionItemReportPreview-c…

1a7767b

…omponent # Conflicts: # src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

situchan approved these changes Jan 29, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg January 29, 2024 11:58

jasperhuangg approved these changes Jan 29, 2024

View reviewed changes

jasperhuangg merged commit 480ae8d into Expensify:main Jan 29, 2024
17 checks passed

VickyStash mentioned this pull request Jan 30, 2024

[No QA] [TS migration] Fix Onyx types import #35361

Merged

50 tasks

github-actions bot mentioned this pull request Jan 31, 2024

Deploy Checklist: New Expensify 2024-01-31 #35448

Closed

54 tasks

melvin-bot bot mentioned this pull request Jan 31, 2024

[$250] [HOLD for payment 2024-02-07] [TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript #31973

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript #34374

[TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript #34374

VickyStash commented Jan 11, 2024 •

edited

Loading

filip-solecki left a comment

melvin-bot bot commented Jan 15, 2024

VickyStash commented Jan 18, 2024

situchan commented Jan 22, 2024

blazejkustra left a comment

blazejkustra Jan 23, 2024

VickyStash Jan 23, 2024

situchan Jan 24, 2024

VickyStash commented Jan 24, 2024

situchan Jan 24, 2024

situchan Jan 24, 2024 •

edited

Loading

VickyStash Jan 24, 2024

VickyStash commented Jan 26, 2024

situchan commented Jan 28, 2024

situchan commented Jan 28, 2024 •

edited

Loading

VickyStash commented Jan 29, 2024

situchan left a comment

melvin-bot bot commented Jan 29, 2024

VickyStash commented Jan 30, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

[TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript #34374

[TS migration] Migrate 'ReportActionItemReportPreview.js' component to TypeScript #34374

Conversation

VickyStash commented Jan 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

filip-solecki left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 15, 2024

VickyStash commented Jan 18, 2024

situchan commented Jan 22, 2024

blazejkustra left a comment

Choose a reason for hiding this comment

blazejkustra Jan 23, 2024

Choose a reason for hiding this comment

VickyStash Jan 23, 2024

Choose a reason for hiding this comment

situchan Jan 24, 2024

Choose a reason for hiding this comment

VickyStash commented Jan 24, 2024

situchan Jan 24, 2024

Choose a reason for hiding this comment

situchan Jan 24, 2024 • edited Loading

Choose a reason for hiding this comment

VickyStash Jan 24, 2024

Choose a reason for hiding this comment

VickyStash commented Jan 26, 2024

situchan commented Jan 28, 2024

situchan commented Jan 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

VickyStash commented Jan 29, 2024

situchan left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 29, 2024

VickyStash commented Jan 30, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

OSBotify commented Jan 31, 2024

VickyStash commented Jan 11, 2024 •

edited

Loading

situchan Jan 24, 2024 •

edited

Loading

situchan commented Jan 28, 2024 •

edited

Loading