Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEDIUM] Expensify Cards: Wallet - Clicking on Address does nothing after submitting empty phone number #34426

Closed
6 tasks done
kavimuru opened this issue Jan 12, 2024 · 27 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Jan 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.24-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Log in to [email protected]
  2. Go to Settings > Wallet > Expensify card.
  3. Click Reveal details > Update address > Save.
  4. Click Get physical card.
  5. Enter invalid phone number > Next.
  6. Click Get physical card.
  7. Click Address. Note that you can open Address page.
  8. Return to previous page.
  9. Click Phone number > Clear phone number field > Next.
  10. Return to previous page.
  11. Click Address.

Expected Result:

Address page opens.

Actual Result:

Nothing happens when clicking Address.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339815_1705043953339.20240111_232355.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010bd5f5e3f107d6c2
  • Upwork Job ID: 1755972633038876672
  • Last Price Increase: 2024-02-09
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 12, 2024
Copy link

melvin-bot bot commented Jan 12, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Overdue label Jan 14, 2024
Copy link

melvin-bot bot commented Jan 15, 2024

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Jan 17, 2024

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Jan 19, 2024

@kevinksullivan Still overdue 6 days?! Let's take care of this!

@kevinksullivan
Copy link
Contributor

@grgia assigning you for initial review, then let's pass this off to a contributor that's been involved.

@melvin-bot melvin-bot bot removed the Overdue label Jan 24, 2024
@grgia
Copy link
Contributor

grgia commented Jan 26, 2024

Going to see if the callstack will take this one

@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@grgia grgia changed the title Wallet - Clicking on Address does nothing after submitting empty phone number [Card Settings] Wallet - Clicking on Address does nothing after submitting empty phone number Jan 29, 2024
@grgia grgia changed the title [Card Settings] Wallet - Clicking on Address does nothing after submitting empty phone number [ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number Jan 29, 2024
@grgia
Copy link
Contributor

grgia commented Jan 29, 2024

asked here

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 29, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@kevinksullivan @grgia this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Copy link

melvin-bot bot commented Feb 2, 2024

@kevinksullivan, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@pac-guerreiro
Copy link
Contributor

I am Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this job!

Copy link

melvin-bot bot commented Feb 6, 2024

@kevinksullivan, @grgia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@pac-guerreiro
Copy link
Contributor

@grgia @kavimuru What's the password for the user [email protected] ?

Copy link

melvin-bot bot commented Feb 8, 2024

@kevinksullivan, @grgia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@grgia
Copy link
Contributor

grgia commented Feb 8, 2024

Thanks for the patience @pac-guerreiro, assigning now!

@grgia
Copy link
Contributor

grgia commented Feb 8, 2024

What's the password for the user [email protected]

@pac-guerreiro you don't need access to this account (we don't give out expensifail passwords), but you should be able to test the form flow bugs in DEV

Copy link

melvin-bot bot commented Feb 9, 2024

@kevinksullivan @grgia @pac-guerreiro this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Feb 9, 2024
Copy link

melvin-bot bot commented Feb 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010bd5f5e3f107d6c2

Copy link

melvin-bot bot commented Feb 9, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@pac-guerreiro
Copy link
Contributor

@grgia Ok, but I'm not able to replicate the exact behaviour because I don't have a valid card, I can only mock it. Nonetheless, from my tests it seems to work!

@melvin-bot melvin-bot bot added the Overdue label Feb 12, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

@kevinksullivan, @rushatgabhane, @grgia, @pac-guerreiro Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Feb 13, 2024
@pac-guerreiro
Copy link
Contributor

pac-guerreiro commented Feb 13, 2024

PR ready, have fun! 😄

#36056

@greg-schroeder greg-schroeder changed the title [ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number [MEDIUM] Expensify Cards: Wallet - Clicking on Address does nothing after submitting empty phone number Feb 20, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

This issue has not been updated in over 15 days. @kevinksullivan, @rushatgabhane, @grgia, @pac-guerreiro eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@rushatgabhane
Copy link
Member

@kevinksullivan could you please attach payment summary 🙇

@rushatgabhane
Copy link
Member

payment request here https://staging.new.expensify.com/r/2938310154194899

@JmillsExpensify
Copy link

Awaiting payment summary from @kevinksullivan

@kevinksullivan
Copy link
Contributor

Payment summary:

@JmillsExpensify
Copy link

$500 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
No open projects
Development

No branches or pull requests

6 participants