[ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number #36056

pac-guerreiro · 2024-02-07T18:39:16Z

Details

Fixed Issues

$#34426
PROPOSAL:

Fix wrong route format used on every get physical card flow screen, which causes errors on the console.
Fix route redirection issues caused by using different data validations when entering and throughout the flow.
Validate if phone number, which is saved as a draft, is valid besides checking if it only exists, otherwise invalid phone numbers would allow to bypass phone number entry step.
Remove check that allowed user to bypass phone number entry if a phone number is already associated to the user's account before setting the form draft values.

Tests

Go to Settings > Wallet
Select an Expensify card which has no physical card emitted
Note: if no expensify card is available, you can mock it with an useEffect or through the browser console like this:

// Add this on WalletPage.js
useEffect(() => {
        if (cardList[234523452345]) {
            return;
        }
        // eslint-disable-next-line rulesdir/prefer-actions-set-data
        Onyx.merge(`cardList`, {
            234523452345: {
                key: '234523452345',
                cardID: 234523452345,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: true,
                fraud: null,
            },
            234523452346: {
                key: '234523452346',
                cardID: 234523452346,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: false,
                fraud: null,
            },
        });
}, [cardList]);

// Or write this on your browser console
window.Onyx.merge(`cardList`, {
            234523452345: {
                key: '234523452345',
                cardID: 234523452345,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: true,
                fraud: null,
            },
            234523452346: {
                key: '234523452346',
                cardID: 234523452346,
                state: 2,
                bank: 'Expensify Card',
                availableSpend: 10000,
                domainName: 'expensify.com',
                lastFourPAN: '2345',
                isVirtual: false,
                fraud: null,
            },
});

Press Get physical card
If you're on the phone number entry step, then write an invalid number and go back; If you're on the confirmation step, click on phone number then write an invalid number and go back; otherwise just add the address then enter an invalid phone number and go back
Press Get physical card
You should be shown the phone number entry step with the invalid number you wrote before, so now replace it with a valid number
Go back and press Get physical card
You should be shown the confirmation page, then click on address and update the data
You should be back in the confirmation page, so try clicking on address again to confirm that you're able to edit it

Offline tests

Same as tests

QA Steps

Go to Settings > Wallet
Select an Expensify card which has no physical card emitted
Click on reveal details, then on address
Press Get physical card
If you're on the phone number entry step, then write an invalid number and go back; If you're on the confirmation step, click on phone number then write an invalid number and go back
Press Get physical card
You should be shown the phone number entry step with the invalid number you wrote before, so now replace it with a valid number
Go back and press Get physical card
You should be shown the confirmation page, then click on address and update the data
You should be back in the confirmation page, so try clicking on address again to confirm that you're able to edit it

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-13.at.21.34.44.mp4

Android: mWeb Chrome

Screen.Recording.2024-02-12.at.19.16.07.mp4

iOS: Native

Screen.Recording.2024-02-12.at.19.39.45.mp4

iOS: mWeb Safari

Screen.Recording.2024-02-12.at.19.11.16.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-02-12.at.19.03.08.mp4

MacOS: Desktop

Screen.Recording.2024-02-12.at.19.23.53.mp4

pac-guerreiro · 2024-02-07T18:41:43Z

cc @grgia

…ne-number-bug # Conflicts: # src/libs/GetPhysicalCardUtils.ts # src/pages/settings/Wallet/Card/GetPhysicalCardPhone.tsx

…ard flow from expensify card page

…ne-number-bug # Conflicts: # src/libs/GetPhysicalCardUtils.ts

melvin-bot · 2024-02-13T22:09:02Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2024-02-14T17:49:44Z

Going to trigger a test build for this one!

github-actions · 2024-02-14T18:09:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/36056/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/36056/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/36056/NewExpensify.dmg	https://36056.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

rushatgabhane · 2024-02-16T04:25:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-19.at.18.31.57.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-02-19.at.18.28.10.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-02-19.at.18.20.07.mov

MacOS: Desktop

melvin-bot · 2024-02-19T12:55:06Z

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #36800.

OSBotify · 2024-02-26T21:06:17Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:54:53Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: wrong route format causing console errors

a555fd3

fix: invalid phone number bypassing get physical card flow

9332a29

pac-guerreiro force-pushed the pac-guerreiro/issue/34426-wallet-invalid-phone-number-bug branch from 31bc2b3 to 9332a29 Compare February 7, 2024 18:43

pac-guerreiro added 3 commits February 12, 2024 17:48

Merge branch 'main' into pac-guerreiro/issue/34426-wallet-invalid-pho…

afa37e9

…ne-number-bug # Conflicts: # src/libs/GetPhysicalCardUtils.ts # src/pages/settings/Wallet/Card/GetPhysicalCardPhone.tsx

fix: draft values not being properly set when entering get physical c…

033be50

…ard flow from expensify card page

Merge branch 'main' into pac-guerreiro/issue/34426-wallet-invalid-pho…

3b40be2

…ne-number-bug # Conflicts: # src/libs/GetPhysicalCardUtils.ts

pac-guerreiro marked this pull request as ready for review February 13, 2024 22:08

pac-guerreiro requested a review from a team as a code owner February 13, 2024 22:08

melvin-bot bot requested review from cristipaval and removed request for a team February 13, 2024 22:09

pac-guerreiro mentioned this pull request Feb 13, 2024

[MEDIUM] Expensify Cards: Wallet - Clicking on Address does nothing after submitting empty phone number #34426

Closed

6 tasks

cristipaval requested review from rushatgabhane and grgia and removed request for cristipaval February 14, 2024 14:13

grgia added the Ready To Build label Feb 14, 2024

This comment has been minimized.

Sign in to view

rushatgabhane approved these changes Feb 19, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Feb 19, 2024

Payment issue for E/App PR#36056 #36800

Closed

grgia approved these changes Feb 21, 2024

View reviewed changes

grgia merged commit 86a91bb into Expensify:main Feb 21, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number #36056

[ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number #36056

pac-guerreiro commented Feb 7, 2024 •

edited

Loading

pac-guerreiro commented Feb 7, 2024

melvin-bot bot commented Feb 13, 2024

grgia commented Feb 14, 2024

This comment has been minimized.

github-actions bot commented Feb 14, 2024

rushatgabhane commented Feb 16, 2024 •

edited

Loading

melvin-bot bot commented Feb 19, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

[ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number #36056

[ECard Settings] Wallet - Clicking on Address does nothing after submitting empty phone number #36056

Conversation

pac-guerreiro commented Feb 7, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

pac-guerreiro commented Feb 7, 2024

melvin-bot bot commented Feb 13, 2024

grgia commented Feb 14, 2024

This comment has been minimized.

github-actions bot commented Feb 14, 2024

rushatgabhane commented Feb 16, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Feb 19, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

pac-guerreiro commented Feb 7, 2024 •

edited

Loading

rushatgabhane commented Feb 16, 2024 •

edited

Loading