Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-01-17 #34621

Closed
58 tasks done
github-actions bot opened this issue Jan 17, 2024 · 10 comments
Closed
58 tasks done

Deploy Checklist: New Expensify 2024-01-17 #34621

github-actions bot opened this issue Jan 17, 2024 · 10 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2024

Release Version: 1.4.26-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kbecciv kbecciv added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 17, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.26-1 🚀

@kbecciv
Copy link

kbecciv commented Jan 17, 2024

Regression is 30% left

#33392 - pending validation
#33836 - pending validation
#34098 - #34098 (comment)
#34116 - pending validation
#34398 is failing with #27262 on Android and IOS app, repro in prod, checking Off
#34469 - pending validation
#34553 - pending validation
#34590 - pending validation

Deploy Blockers:

#34649
#34650

@tgolen
Copy link
Contributor

tgolen commented Jan 17, 2024

Marking off #34669 from the deploy blocker list because I don't think this has any user impact, so I don't think it should be a deploy blocker.

@marcaaron
Copy link
Contributor

Checking off #34681 because the issue is very minor and connected with what looks like a new feature

@blimpich
Copy link
Contributor

#34676 is not a blocker, checking off. Very minor issue that happens only under fairly specific circumstances.

@mvtglobally
Copy link

Regression is completed

#33392 is failing #34690. Repro in PROD checking off
#34098 - Internal QA #34098 (comment)
#34590 - seem to be failing #34590 (comment)

Open Blockers

#34649
#34668
#34673
#34675
#34680
#34685

@mountiny mountiny added the Daily KSv2 label Jan 18, 2024
@mountiny mountiny self-assigned this Jan 18, 2024
@mountiny
Copy link
Contributor

Demoting couple deploy blockers, and reverting the cancel payment to resolve the rest

#34590 does not feel like a blocking issue too

@mountiny
Copy link
Contributor

All is looking good just waiting for one CP to finish

@mountiny
Copy link
Contributor

@marcaaron
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants