[HOLD for payment 2024-02-01] When Paying with Expensify the passed payment type is REPORT

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

It seems like this is broken since #34621

Version Number: v1.4.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify @johnmlee101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705929941791079

Action Performed:

Break down in numbered steps

You should have wallet enabled, for testing purposes I think you can bypass the KYC

1. Submit request to account that already has an upgraded wallet.
2. Click into the Request.
3. Click Pay with Expensify.

Expected Result:

Describe what you think should've happened

Payment goes through

Actual Result:

Describe what actually happened

Error appears because the

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @mountiny is eligible for the Engineering assigner, not assigning anyone new.

[mountiny]

From the logs we can see that the problem is that in here the payment type is REPORT for some unclear reason so then the api method called is the PayMoneyRequest which is not correct for the Pay with Expensify option

[mountiny]

Seems like ti started after this deploy #34621 as only the deploy before is the last one this worked

[mountiny]

This is not technically a deploy blocker, but important flow that is not yet covered by regression testing that is broken so trying to fix with urgency

[ZhenjaHorbach]

I think the problem related to this changes
#33714 (comment)

[mountiny]

Thanks for linking, yep that will be the exact problem

[mountiny]

Most likely will be fixed with this PR #34870

[ZhenjaHorbach]

Also here )
#33866

[mountiny]

Yeah we would ideally only CP as small change as possible to get this working

[mountiny]

@ruben-rebelo @rushatgabhane can you please comment on this issue so I can assign you?

[mountiny]

Removing the blocker label as this is technically not a blocker and we have identified the root cause and a fix, currently blocked on something else

[ruben-rebelo]

@mountiny sure

[melvin-bot]

📣 @ruben-rebelo! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[alexpensify]

Alright, we are open for proposals here.

[mountiny]

This was fixed actually, closing as it was a regression from different PR

[alexpensify]

Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.31-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS Migration] Adjustments on KYCWall #34870

If no regressions arise, payment will be issued on 2024-02-01. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @ruben-rebelo does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: