Cancel payment - Expense report with payment cancellation system message is not entirely deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create a new workspace
2. Go to workspace chat
3. Create a manual request
4. Edit the amount, description etc of the request to invoke system message
5. Delete the request
6. Note that the details page together with the system message is deleted
7. Create another manual request
8. Pay elsewhere the report
9. Go to expense report > 3-dot menu > Cancel payment

Expected Result:

The report will be entirely deleted since there is no more request in the report

Actual Result:

The report is not entirely deleted as the system message for payment cancellation still remains

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Uploading Bug6345737_1705521965443!bandicam_2024-01-18_00-51-03-204.mp4…

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lanitochka17]

#wave7-collect-approvers

[roryabraham]

It looks like the video upload failed here. A reproduction video would be helpful for me to understand this better

[mountiny]

It feels like the steps are missing last step saying: Delete the report

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #33836 from Expensify/alberto-unpay2" #34697

If no regressions arise, payment will be issued on 2024-01-25. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #33836 from Expensify/alberto-unpay2" #34697

If no regressions arise, payment will be issued on 2024-01-26. 🎊

[roryabraham]

The offending PR was reverted.