Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] Context menu - Context menu opens in LHN when navigating via Tab and Enter key #34739

Closed
2 of 6 tasks
lanitochka17 opened this issue Jan 18, 2024 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.27-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Hover over any message in chat
  2. Click on the empty area inside the hover menu
  3. Navigate to overflow menu via Tab
  4. Hit Enter

Expected Result:

The context menu will open near the hover menu

Actual Result:

The context menu opens in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6346583_1705587656418.20240118_212922.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 18, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 18, 2024

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@lanitochka17
Copy link
Author

#vip-vsb

@esh-g
Copy link
Contributor

esh-g commented Jan 18, 2024

It was known while making the PR here: #34031 (comment)
We decided not to block the deploy because of it. There is another pending PR where this should be fixed.

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 18, 2024
@mountiny mountiny added Daily KSv2 and removed Hourly KSv2 labels Jan 18, 2024
@mountiny
Copy link
Contributor

This is known, we decided to move ahead and fix as a follow up

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 18, 2024
@esh-g
Copy link
Contributor

esh-g commented Jan 26, 2024

@mountiny Would it be possible to reconsider the total bounty for this issue (including the original), since this required 2 PRs and a lot more changes than normal bugs? I would suggest the previous bounty ($1000) but I'm good with any decision you take.

@mountiny
Copy link
Contributor

It required 2 Prs only because we decided this new bug can be treated as a follow up

bumping to $600 dont think more would be fair compared to other issues/ feature request

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title Context menu - Context menu opens in LHN when navigating via Tab and Enter key [HOLD for payment 2024-02-07] Context menu - Context menu opens in LHN when navigating via Tab and Enter key Jan 31, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

  • @rushatgabhane requires payment through NewDot Manual Requests
  • @esh-g requires payment (Needs manual offer from BZ)

@mountiny mountiny added the NewFeature Something to build that is a new item. label Jan 31, 2024
Copy link

melvin-bot bot commented Jan 31, 2024

@mountiny mountiny added Daily KSv2 Reviewing Has a PR in review and removed Weekly KSv2 labels Jan 31, 2024
@mountiny
Copy link
Contributor

Wait payment for this is handled here #33573 so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants