[HOLD for payment 2024-02-07] [HOLD for payment 2024-02-05] Desktop - Unread marker remains after opening chat with new messages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.32-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33779

Action Performed:

1. [User A] Send a message to User B.
2. [User B] Open chat with User A.
3. [User B] Switch between chat with User A and different chats.

Expected Result:

The unread message marker above the new message from User A will disappear.

Actual Result:

The unread message marker above the new message from User A does not disappear.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355838_1706278358510.20240126_202948.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[arosiclair]

Cannot reproduce on web v1.4.32-2. Going to try desktop...

[arosiclair]

Reproduced on desktop v1.4.32-2. It seems like something is marking the report as read when I focus the window and that is causing the bug:

Screen.Recording.2024-01-26.at.4.19.10.PM.mov

[arosiclair]

Seems like this is caused by #34537. cc @FitseTLT @abdulrahuman5196 @hayata-suenaga.

There's another similar blocker. I'm going to ask if both of these can be fixed in the same way.

[abdulrahuman5196]

#35251 and #35254 are same issue. (We can combine into one issue if required). Since its under the regression period @FitseTLT Should fix this. Kindly assign me as C+ as well.
On another topic @tienifr 's proposal here #35254 (comment) works fine.

[FitseTLT]

Raised PR for these and linked to the original issue 👍

[mountiny]

Reverted the offending PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #34537 from FitseTLT/fix-mark-as-read-on-v… #35308

If no regressions arise, payment will be issued on 2024-02-05. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #34537 from FitseTLT/fix-mark-as-read-on-v… #35308

If no regressions arise, payment will be issued on 2024-02-07. 🎊