[HOLD for payment 2024-02-07] [HOLD for payment 2024-02-05] [$500] Desktop - Unread chat becomes unbolded in LHN without opening unread messages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.32-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33779

Action Performed:

Precondition;

• User A is on web.
• User B is on desktop app.
• User A and B windows are next to each other.

1. [User B Desktop] Open any report other than report with User A.
2. [User A web] Send a message to User B.
3. [User B Desktop] Without opening chat with User A, focus the window on the desktop app.

Expected Result:

For User B, the chat with User A will remain bold because User B has not opened the chat with unread message.

Actual Result:

The chat with User A is unbold as soon as User B focuses on the desktop app without even opening chat with User A.
On web, the issue is reproducible when the other user switches between tab without even opening the chat with new message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6355850_1706278998747.20240126_202410.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0108273261b6247483
• Upwork Job ID: 1750907915767681024
• Last Price Increase: 2024-01-26
• Automatic offers:
• abdulrahuman5196 | Contributor | 28127559

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-vsb
CC @quinthar

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0108273261b6247483

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[mountiny]

Making this external none of the PRs in checklist stand out to me. Anyone can find which pr caused this?

[mountiny]

I am out for couple hours

[bernhardoj]

It's caused by #34537 where we read the newest action on visibility change. I think we should return early if the report screen on the stack isn't focused.

[tienifr]

This is regression from #34537, I can raise a PR immediately if assigned

Proposal

Please re-state the problem that we are trying to solve in this issue.

The chat with User A is unbold as soon as User B focuses on the desktop app without even opening chat with User A.
On web, the issue is reproducible when the other user switches between tab without even opening the chat with new message.

What is the root cause of that problem?

In here, we do not check that the current report has focus/is the topmost one before marking it as read, so even when the report is not the topmost one, it's still marked as read when the visibility changes.

What changes do you think we should make in order to solve the problem?

We should unsubscribeVisibilityListener if the report is not focused/is not the topmost report. For example we can update this to:

const isFocused = useIsFocused();

useEffect(() => {
    if (!isFocused) {
        return;
    }

    const unsubscribeVisibilityListener = Visibility.onVisibilityChange(onVisibilityChange);
    return unsubscribeVisibilityListener;
}, [onVisibilityChange, isFocused]);

This will fix the issue and there'll be no redundant event listeners for not-focused reports

What alternative solutions did you explore? (Optional)

NA

[thesahindia]

It's caused by #34537 where we read the newest action on visibility change. I think we should return early if the report screen on the stack isn't focused.

cc: @FitseTLT @abdulrahuman5196 @hayata-suenaga

[arosiclair]

I also have this blocker which seems like it has the same root cause: #35251

Do we know if the proposed solutions can fix both?

[tienifr]

Do we know if the proposed solutions can fix both?

@arosiclair Yes, it's same root cause and my proposed solution will fix both (tested).

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[abdulrahuman5196]

#35251 and #35254 are same issue. (We can combine into one issue if required). Since its under the regression period @FitseTLT Should fix this. Kindly assign me as C+ as well.
On another topic @tienifr 's proposal here #35254 (comment) works fine.

[FitseTLT]

Raised PR for these and linked to the original issue 👍

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Reverted the offending PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #34537 from FitseTLT/fix-mark-as-read-on-v… #35308

If no regressions arise, payment will be issued on 2024-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Contributor)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #34537 from FitseTLT/fix-mark-as-read-on-v… #35308

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment automatic offer (Contributor)