[$500] [LOW] Tags: Recently selected tag not displayed in recents list after editing an IOU

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.34.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:
User is employee of Collect workspace
Steps:

1. Employee navigate to Workspace chat
2. Go to +> Request money> Manual> Select tag 1> Complete the flow
3. Navigate to created IOU> Edit tag> Select tag 2> Save
4. Navigate to workspace chat
5. Go to +> Request money> Manual> Tag

Expected Result:

Tag 2 should be present in recent tags list

Actual Result:

Tag 2 is not present in recent tags lis

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362752_1706727433731.Recording__1984.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ee0fe0e10710c59
• Upwork Job ID: 1752771933542309888
• Last Price Increase: 2024-01-31

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ee0fe0e10710c59

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[lanitochka17]

We think that this bug might be related to #wave6
CC @greg-schroeder

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Latest Selected Tag is not displayed in recents list when we edit it

What is the root cause of that problem?

We do not update the Tag value to recent as we do with category

What changes do you think we should make in order to solve the problem?

Update the Tag value to recents

What alternative solutions did you explore? (Optional)

N/A

[greg-schroeder]

Hmm, is this the behavior for categories that a category selected via edit is added to Recents? I'm not sure if that actually is the expected behavior

[greg-schroeder]

I suppose that makes sense though, it was actually used for the expense in the end. I'll add it to the project board, low prio though

[vishrutagarwal97]

how to make a collect workspace? and also how to connect to OD? Any articles or place where I can refer and do it?

[melvin-bot]

Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.

[DylanDylann]

I think we should hold this issue until #34612 is done

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[trjExpensify]

I think we should hold this issue until #34612 is done

It probably makes sense @DylanDylann, but mind including your reasoning when making a suggestion to put something on hold? Thanks!

[DylanDylann]

In #34612, we will migrate to use IOURequestStepTags for all Tag pages so I think the logic update recant tag will be updated for all flows

[trjExpensify]

Thanks, helpful. Popping it on hold :)

[trjExpensify]

@DylanDylann, looks like the PR associated with #34612 was deployed to prod, right? Is that it or is there more to do?

[DylanDylann]

Will check on Feb 15

[DylanDylann]

Still can reproduce

Screen.Recording.2024-02-15.at.12.16.05.mov

The RCA is that OpenDraftWorkspaceRequest API return wrong data

After turning off the Internet, everything works well in all flows (create/edit request money, split bill). So I think it is a BE bug.

cc @mollfpr

[trjExpensify]

Okay cool, I'll take this off-hold. @amyevans over to you then if this is BE related, I guess!

[melvin-bot]

@amyevans @trjExpensify @mollfpr this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[amyevans]

PRs up: https://github.com/Expensify/Auth/pull/10019, https://github.com/Expensify/Web-Expensify/pull/41005. Also just a heads up I'll be OOO next week!

[amyevans]

Everything has deployed, closing!