[HOLD for payment 2024-02-09] [$250] Room - Tapping on "Leave" room directed to previously visited page for an second

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.35
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap on any report
3. Navigate back to LHN
4. Tap fab---Start chat
5. Tap room
6. Enter all required fields
7. Tap create room
8. Tap on top right 3 dots and select "Leave" room

Expected Result:

When user leaves room, previously visited page must not be shown for an second and user must be navigated to concierge page

Actual Result:

When user leaves room, previously visited page( in step 2 visited page) shown for an second and then only navigated to concierge page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6363866_1706807592795.7h.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0171a4f0bb95566a69
• Upwork Job ID: 1753162906835521536
• Last Price Increase: 2024-02-09
• Automatic offers:
• situchan | Reviewer | 28135564
• dukenv0307 | Contributor | 28135565

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Room - Tapping on "Leave" room directed to previously visited page for an second

What is the root cause of that problem?

• When leaving room, we called leaveRoom with isWorkspaceMemberLeavingWorkspaceRoom param is false. It is because lodashGet(props.report, 'visibility', '') return ""

What changes do you think we should make in order to solve the problem?

• We need to pass the visibility to this

What alternative solutions did you explore? (Optional)

• NA

[situchan]

This is deploy blocker. @dukenv0307 do you know offending PR?

[dukenv0307]

@situchan Maybe this one. We not pass the visibility to the report

[situchan]

I am not sure about the expected behavior.
After adding visibility, it doesn't return to Concierge chat.

[dukenv0307]

@situchan Yes. Based on the issue, we do not return to Concierge chat anymore

[bondydaa]

cc @mountiny @aimane-chnaif any ideas here since it looks like it might have started from #30168?

[bondydaa]

sounds like that PR might have introduced a few regressions but nothing too major so we'll just patch them as needed instead of reverting the PR.

Going to assign you @dukenv0307 and @situchan for everything.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0171a4f0bb95566a69

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[getusha]

@situchan @dukenv0307 just as a note, we do navigate to Concierge if there is no report opened before leaving the room.

[situchan]

@getusha thanks for the note

[sakluger]

@bondydaa @situchan @dukenv0307 it seems like you all have this under control - let me know if I can help with anything.

[bondydaa]

👍 yeah just assigned you so I wouldn't forget like I have in the past for payment stuff, sort of skipped past the first steps of BZ team on ya. mostly I think you're just along for the ride for now 😂

[mountiny]

@dukenv0307 are you able to raise the PR with a fix soon? I also suggest to lower the reward for this one to $250 because its very simple change and we have already done couple PRs patching the missing properties. Does that work for you @dukenv0307 ? Thanks!

[dukenv0307]

@mountiny I am working on it.

[dukenv0307]

@getusha Did we implement it yet? " just as a note, we do navigate to Concierge if there is no report opened before leaving the room."

[dukenv0307]

@situchan PR #35624 is ready to review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix/35579: Leaving room issue #35624

If no regressions arise, payment will be issued on 2024-02-09. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Reviewer)
• @dukenv0307 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Upwork job price has been updated to $250

[sakluger]

Changing the bounty to $250 on @mountiny's suggestion since he confirmed it was the fair price before the PR was merged.

[sakluger]

All paid out!

@situchan could you please complete the BZ checklist before I close the issue?

[situchan]

offending PR: #30168
Since it was large refactor, this was easily missed.

As this was deploy blocker, we can skip regression test. QA team caught this during staging regression testing.

[sakluger]

Nice, thanks for that! Closing out 👍