[$500] Web - Pay with Expensify button for approved request disappears after VBA added

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.36-0
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4278917&group_by=cases:section_id&group_order=asc&group_id=296773
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: Before reproduce, do this TRs:

1. https://expensify.testrail.io/index.php?/cases/view/2778074
2. https://expensify.testrail.io/index.php?/cases/view/2778075
3. https://expensify.testrail.io/index.php?/cases/view/2778077
4. Do Preconditions for https://expensify.testrail.io/index.php?/cases/view/2778078

1. As the admin - navigate to the workspace chat with the employee
2. Button is displayed as "Pay with Expensify" in the report preview of the report that was approved
3. Click on the report preview to navigate to the report conversation

Expected Result:

The option to "Pay with Expensify" is displayed in the header

Actual Result:

The option to "Pay with Expensify" is briefly displayed in the header and disappears.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365235_1706902346740.bandicam_2024-02-02_21-17-15-887.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ac45cee2af607ba3
• Upwork Job ID: 1753523096410824704
• Last Price Increase: 2024-02-09
• Automatic offers:
• hoangzinh | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ac45cee2af607ba3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[kbecciv]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[melvin-bot]

@hoangzinh, @abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

Verifying if this is wave 7 here

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abekkala]

https://expensify.slack.com/archives/C03UK30EA1Z/p1707504123922889

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

[abekkala]

Thanks @teneeto

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[abekkala]

@teneeto
https://expensify.testrail.io/index.php?/cases/view/2778074
Employee - Collect Workspace chat is displayed after first login

[abekkala]

https://expensify.testrail.io/index.php?/cases/view/2778075
Employee - Approve button is not displayed for employee

[abekkala]

https://expensify.testrail.io/index.php?/cases/view/2778077
Admin - Approve report - Status is updated

[abekkala]

https://expensify.testrail.io/index.php?/cases/view/2778078
Admin - Pay report with Expensify - Employee doesn't have BA

[melvin-bot]

@hoangzinh @abekkala @teneeto this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[abekkala]

@teneeto do you have a timeframe for the PR?

[teneeto]

Hi @abekkala, I believe we can clear this out on or before the weekend. I will be sure to attend to a few other reviews, and then come back to this.

[abekkala]

@teneeto thanks for the update!

[melvin-bot]

@hoangzinh @abekkala @teneeto this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[abekkala]

@teneeto is there a PR ready for this one?

[abekkala]

@teneeto do you have an update here? or a PR to link?

[teneeto]

Hi @abekkala, Apologies for missing updates here. I couldn't complete this at the time earlier promised. But I'll push for a PR tomorrow. TBH Had some delays with reproducing this earlier.

[teneeto]

Hi @abekkala

From my Findings shouldShowPayButton button has a condition called isAutoReimbursable. That condition is the reason why the Pay with Expensify button disappears.

App/src/components/MoneyReportHeader.tsx

Lines 79 to 82 in 3e74ddf

	const shouldShowPayButton = useMemo(
	() => isPayer && !isDraft && !isSettled && !moneyRequestReport.isWaitingOnBankAccount && reimbursableSpend !== 0 && !ReportUtils.isArchivedRoom(chatReport) && !isAutoReimbursable,
	[isPayer, isDraft, isSettled, moneyRequestReport, reimbursableSpend, chatReport, isAutoReimbursable],
	);

Investigating Further:
This PR: #33987 is deliberate and responsible to Hide pay button when auto reimbursement is enabled.
This was included here: https://github.com/Expensify/App/pull/33987/files#diff-5163bae465a2e5449c9b49bd5a38af413a2b3f8b8cf0e3ed81552dba2899215fL68-R70

Possible Solution

removing isAutoReimbursable condition.

Discussion

This rather seem to be a feature than a bug, can we check to confirm if this PR: #33987 is valid and on what conditions of reimbursement should the pay button display or not?.

[teneeto]

@marcochavezf I'm mentioning you here for clarity sake. any thoughts on my last comment?

[abekkala]

@marcochavezf I agree with @teneeto comment here

to confirm: @teneeto this 'issue' was not reproducible if the workspace does not use auto-reimbursement, correct?
OR if the report total was over the auto-reimbursement threshold of the workspace?

[teneeto]

@marcochavezf I agree with @teneeto comment here

To confirm: @teneeto this 'issue' was not reproducible if the workspace does not use auto-reimbursement, correct? OR if the report total was over the auto-reimbursement threshold of the workspace?

@abekkala, Yes, it was not reproducible if the workspace does not use auto-reimbursement. Also, I can confirm if it is the same thing when the total is over the auto-reimbursement threshold of the workspace.

[teneeto]

@abekkala and Yes!, I simply removed the default reimbursement amount, which was $100 and the button showed up again.

[melvin-bot]

@hoangzinh @abekkala @teneeto this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @hoangzinh is eligible for the Internal assigner, not assigning anyone new.

[abekkala]

Ok, then it would appear that this is working as intended due to the recent update mentioned by @teneeto above.

@marcochavezf if you'd like to buddy check me on that.

If so, then I'll close this one out

[marcochavezf]

Yes, that's correct, we're not showing the Pay button if the policy has auto-reimbursement enabled. We can close it out.