[$500] LHN - When you delete a message from a room, the conversation in the members remains bolded

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.37-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Open https://staging.new.expensify.com/
2. Log in under your HT account A
3. In incognito mode, open https://staging.new.expensify.com/
4. Log in with a different account B
5. Under user A, create a WS
6. Invite user B to the created WS
7. Under user B, go to a conversation other than @announce
8. Under user A, send a message to the @announce room
9. Delete the sent message

Expected Result:

1. When you delete a message from a room, in LHN the room in bold should become with a normal font.
2. Notifications of deleted messages should disappear as soon as the message is removed from the room.

Actual Result:

1. When you delete a message from a room, the conversation in the members remains bolded in LHN
2. Notifications of deleted messages do not disappear.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6370265_1707305254499.Recording__1301_Android.mp4

Bug6370265_1707305254501.Recording__1300_web.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165cbc398f4a1592d
• Upwork Job ID: 1755208022138167296
• Last Price Increase: 2024-02-07
• Automatic offers:
• akinwale | Reviewer | 0
• FitseTLT | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0165cbc398f4a1592d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

We think that this bug might be related to #vip-vsb
CC @quinthar

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When you delete a message from a room, the conversation in the members remains bolded

What is the root cause of that problem?

When there is no visible action left in the report/room after deleting the lastVisibleActionCreated is not being reset so ReportUtils.isUnread is calculated based on the deleted action created time hence it remains bold

App/src/libs/SidebarUtils.ts

Lines 305 to 306 in f6ba751

	result.isUnread = ReportUtils.isUnread(report);
	result.isUnreadWithMention = ReportUtils.isUnreadWithMention(report);

What changes do you think we should make in order to solve the problem?

To deal with this specific case we can add additional condition here

App/src/libs/SidebarUtils.ts

Lines 305 to 306 in f6ba751

	result.isUnread = ReportUtils.isUnread(report);
	result.isUnreadWithMention = ReportUtils.isUnreadWithMention(report);

    result.isUnread = ReportUtils.isUnread(report) && !!report.lastActorAccountID;

Similarly we can make the additional condition to be based on lastMessageHtml or lastMessageText

What alternative solutions did you explore? (Optional)

We can take this condition inside isUnread to fix for other uses of this function as well.

[FitseTLT]

Updated 😉

[akinwale]

We can move forward with @FitseTLT's proposal here.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

@FitseTLT Is there an ETA for your PR?

[joekaufmanexpensify]

Pending update from @FitseTLT

[FitseTLT]

PR will be ready in 2 days

[joekaufmanexpensify]

Got it. TY!

[joekaufmanexpensify]

@FitseTLT are you still on track for the PR here?

[FitseTLT]

will create it today 👍

[joekaufmanexpensify]

Got it. We'll look out for it. It's been 10 days since assignment, so we want to make progress on this asap.

[joekaufmanexpensify]

@FitseTLT Are you still able to prioritize this issue? Generally, we look for a PR to be created within a few days of assignment to an issue.

[FitseTLT]

@joekaufmanexpensify very sorry for the delay will create the pr today

[akinwale]

@joekaufmanexpensify Automation missed this one. The PR was deployed to production on 2024-02-29, making the payment due date 2024-03-07. It's currently about 4 days overdue.

[joekaufmanexpensify]

Got it. I will handle!

[joekaufmanexpensify]

All set to issue payment here. We need to pay:

• @FitseTLT $500 for PR via Upwork.
• @akinwale $500 for C+ via Upwork.

[joekaufmanexpensify]

@FitseTLT $500 sent and contract ended!

[joekaufmanexpensify]

@akinwale $500 sent and contract ended

[joekaufmanexpensify]

All set. Thanks everyone!