Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript #36123

Closed
melvin-bot bot opened this issue Feb 8, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Feb 8, 2024

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/iou/request/step/withFullTransactionOrNotFound.js 11
@ghost
Copy link

ghost commented Feb 8, 2024

I want to work on it

@MahmudjonToraqulov
Copy link
Contributor

I want to work on it

@ruben-rebelo
Copy link
Contributor

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

Copy link
Author

melvin-bot bot commented Feb 28, 2024

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Feb 29, 2024
Copy link
Author

melvin-bot bot commented Feb 29, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 4, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript Mar 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 4, 2024
Copy link
Author

melvin-bot bot commented Mar 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-11. 🎊

Copy link
Author

melvin-bot bot commented Mar 4, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@tylerkaraszewski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 11, 2024
Copy link
Author

melvin-bot bot commented Mar 11, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Mar 27, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 4, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript Apr 8, 2024
Copy link
Author

melvin-bot bot commented Apr 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024
Copy link
Author

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

Copy link
Author

melvin-bot bot commented Apr 8, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@tylerkaraszewski] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@parasharrajat
Copy link
Member

Please assign me as C+.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript [HOLD for payment 2024-04-25] [HOLD for payment 2024-04-15] [HOLD for payment 2024-03-11] [TS migration] Migrate 'withFullTransactionOrNotFound.js' HOC to TypeScript Apr 18, 2024
Copy link
Author

melvin-bot bot commented Apr 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Apr 18, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@parasharrajat
Copy link
Member

@tylerkaraszewski Could you please post the payment summary?

@tylerkaraszewski
Copy link
Contributor

I think that's @garrettmknight's task.

@garrettmknight
Copy link
Contributor

Payment summary:

@garrettmknight garrettmknight reopened this Jul 2, 2024
@parasharrajat
Copy link
Member

Payment requested as per #36123 (comment)

@JmillsExpensify
Copy link

$250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants