[HOLD for payment 2024-03-11] Distance - App refreshes when hitting Enter on empty waypoint editor

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.40-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money > Distance.
3. Click Start.
4. Hit Enter on keyboard.
   Note that the page refreshes.

Expected Result:

App returns to the distance request page.

Actual Result:

App refreshes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6377102_1707765277552.20240213_014106.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c78c122e47f0026b
• Upwork Job ID: 1757134919273578496
• Last Price Increase: 2024-02-12
• Automatic offers:
• cubuspl42 | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @blimpich (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[blimpich]

Not a blocker.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c78c122e47f0026b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[paultsimura]

This looks like a regression from #34471 - it's not only on empty inputs but on non-empty ones when offline.
cc: @shubham1206agra @cubuspl42

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[zoilorys]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App refreshes when hitting Enter in waypoint editor while Address input is focused, it may be not empty and it will still reload the app.

What is the root cause of that problem?

After investigating the code, I found out that the issue was caused by the fact that pressing Enter while Address input is focused was triggering browser submit on the parent form element, instead of triggering programmatic submit. And since there is no action specified on the form element, it triggers submit on current route. This can be easily checked by adding submit event listener via console in browser. After analysing PR attached to the issue as potential cause of regression, I noticed that one of the changes in the PR was replacement of FormSubmit component, consequent removal of the component with FormElement component. Web code for FormSubmit contained evt.preventDefault() for this event and were removed in that PR.

What changes do you think we should make in order to solve the problem?

In order to solve this issue you need to restore FormSubmit component and replace FormElement component in FormWrapper component with it and add onSubmit handler to it.

What alternative solutions did you explore? (Optional)

Before discovering that the regression was caused by replacement of FormSubmit component with FormElement, I did alternative solution, where I just added submit event listener on the form reference to preventDefault() it. Since this code is present only in desktop code, this has no effect on mobile builds.

[melvin-bot]

📣 @zoilorys! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[zoilorys]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0118575350e02b8b5e

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[shubham1206agra]

I think this is due to the weird behaviour of GooglePlacesAutocomplete. I will raise a PR in a few hours.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[cubuspl42]

PR #36401 is in review

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[blimpich]

Ugh, I am terrible at using these dang labels. This is a regression being handled by the author of the PR who caused it, so I shouldn't have marked it as external and needing help to begin with. No bug zero member is assigned here so this should just be handled as part of the original issue here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix form default behavior #36401

If no regressions arise, payment will be issued on 2024-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment automatic offer (Contributor)

[cubuspl42]

No payment for me, we handled this as a regression

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[abekkala]

Hi @blimpich based on this comment:

Does this particular issue need payment? It seems like payments are being handed via #31433 correct?

can this one just be closed? or do I need to even be assigned?

[blimpich]

👍 Correct yes this one can just be closed. I'll close it now.