[HOLD for payment 2024-02-20] [$500] The "Enter" key does not work when editing the "Description" and "Merchant" fields

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.40-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Configure the OldDot administrator account, invite an employee and include multiple categories and tags
https://sites.google.com/applausemail.com/applause-expensifyproject/wiki-guides/newdot-categories?authuser=0

Steps:

1. Open https://staging.new.expensify.com/

2. Log in with the employee's login

3. Click on FAB

4. Select "Request money"

5. Deposit any amount

6. Click on the "Next" button

7. Select Group Policy WS

8. Select any category or tag

9. Click the Merchant or Description field

10. Entry any data

11. Press the "Enter" key

Expected Result:

Pressing the "Enter" key should save the data in the "Description" and "Merchant" fields and return to the IOU menu

Actual Result:

The Enter key does not work when editing the Description and Merchant fields after selecting a Category or Tag

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6377180_1707768877101.Recording__1328.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012366b11cbf8f59eb
• Upwork Job ID: 1757144388262604800
• Last Price Increase: 2024-02-12
• Automatic offers:
• shubham1206agra | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012366b11cbf8f59eb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[paultsimura]

Potentially a regression from #34471, similar to #36363

[hayata-suenaga]

Potentially a regression from #34471, similar to #36363

asking people involved in the original PR if this is actually related to it

[shubham1206agra]

@hayata-suenaga Will take over from here.

Explanation of the problem: This issue actually stems from #32464 as it creates a ghost subscribe event on the Component update, which has no way to do an unsubscribe call (This is happening due to a double call to this.subscribeToEnterShortcut() on update).

Why this became a problem now: This happened as we removed the extra onKeyDown handler from this PR, and now RNW handler catches this event already default prevented.

I will raise a PR in a few hours.

cc @luacmartins @cubuspl42

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[MonilBhavsar]

Thanks for explanation @shubham1206agra!
Assigning this issue to you

[Beamanator]

@shubham1206agra when can we expect a PR? 🙏 this is blocking deploy so it would be great to get a fix out ASAP please

[shubham1206agra]

@Beamanator PR is up.

[cubuspl42]

@Beamanator PR is C+ approved

[Beamanator]

PR merged & is being CP'd to staging 🙏

[Beamanator]

This also looks fixed on staging! 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix listener in options selector #36396

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
• [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[shubham1206agra]

@hayata-suenaga Can you close this issue? There's no pending payment here