[HOLD for payment 2024-02-26] [$500] About - Footer text has no bottom margin

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.41-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Profile.
3. Go to About.
4. Scroll to the bottom.

Expected Result:

The footer text will have bottom margin.

Actual Result:

The footer text has no bottom margin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a30c2684f91e84c5
• Upwork Job ID: 1757533717180780544
• Last Price Increase: 2024-02-13

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a30c2684f91e84c5

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

About - Footer text has no bottom margin

What is the root cause of that problem?

the vertical padding was removed
in this PR #35672

and the Section component was introduced instead , where it uses marginBottom:20

however in the sidebar Footer we dont use the bottom margin:

App/src/pages/settings/AboutPage/AboutPage.tsx

Line 159 in 0375e27

<View style={[styles.sidebarFooter]}>

What changes do you think we should make in order to solve the problem?

we can add the bottom padding styles.mb5 which resolves to a bottom margin equals to 20 in the view styles

                <View style={[styles.sidebarFooter, styles.mb5]}>

or we can add it inside the sidebarFooter:

       sidebarFooter: {
            display: 'flex',
            justifyContent: 'center',
            width: '100%',
            paddingLeft: 20,
            marginBottom: 20,
        },

[tgolen]

@kosmydel It looks like this is a bug from the PR #35672. Can you fix this, please?

[abzokhattab]

Root Cause was updated ... the PR could be ready once assigned.

[filip-solecki]

Hi! I am Filip from SWM an expert agency and I will work on this as I was working also on updating Account Settings

[mountiny]

I think @s77rt should help with the review as C+ on the PR https://expensify.slack.com/archives/C02NK2DQWUX/p1707871824360899

[mountiny]

this is fixed

[abzokhattab]

sorry for mentioning you @mountiny, is this eligible for a partial award? the PR used the first solution mentioned in my proposal. thanks again for your understanding

[mountiny]

Ah thanks for the ping. I do think this was very simple solution so that feels like we could skip the partial reward. I would say we look at that as a form of "how much time it saved us" when fixing the issue. In this case it was quite easy so probably very little.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Add bottom margin to About Page and fix Status Bar color on Preferences Page #36452

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: [Update Account Settings] Preferences, About, Security #35672
• The offending PR has been commented on: Not needed. Since the author fixed the bug
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No