Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New architecture] The app doesn't resize properly when the status bar is translucent #36661

Closed
1 of 6 tasks
j-piasecki opened this issue Feb 16, 2024 · 16 comments
Closed
1 of 6 tasks
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@j-piasecki
Copy link
Contributor

j-piasecki commented Feb 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


This issue is related to the ongoing new architecture adoption. It was reported on the build with new architecture enabled on the relevant PR.


Version Number: 1.4.42-1
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777 here
Slack conversation:

Action Performed:

Open the app. (reopen after closing on LHN and on different screens, the result may differ depending on which screen is opened first)

Expected Result:

The status bar should be transparent and there should not be a blank space on the bottom of the screen

Actual Result:

There is a blank space with the size matching the status bar on the bottom of the screen

Workaround:

This is a visual bug, should be fixed by c3679bb

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

android-statusbar-height1
android-statusbar-height2
statusbar-height3

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0176beefaf58490faa
  • Upwork Job ID: 1768714506853662720
  • Last Price Increase: 2024-03-15
@j-piasecki j-piasecki added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 16, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Feb 19, 2024

Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Feb 21, 2024

Huh... This is 4 days overdue. Who can take care of this?

@ishpaul777
Copy link
Contributor

not able to repro.

Copy link

melvin-bot bot commented Feb 23, 2024

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Feb 27, 2024

10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Feb 29, 2024

12 days overdue. Walking. Toward. The. Light...

Copy link

melvin-bot bot commented Mar 1, 2024

this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 4, 2024
Copy link

melvin-bot bot commented Mar 4, 2024

This issue has not been updated in over 14 days. eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added Engineering Daily KSv2 and removed Weekly KSv2 labels Mar 8, 2024
Copy link

melvin-bot bot commented Mar 11, 2024

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Mar 15, 2024

this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Mar 15, 2024
Copy link

melvin-bot bot commented Mar 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0176beefaf58490faa

Copy link

melvin-bot bot commented Mar 15, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (Internal)

@mountiny
Copy link
Contributor

All issues will be tested for the new arch pr in staging so closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

5 participants