Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Fabric and TurboModules on iOS & Android #13767

Merged
merged 259 commits into from
Apr 9, 2024
Merged

Enable Fabric and TurboModules on iOS & Android #13767

merged 259 commits into from
Apr 9, 2024

Conversation

WoLewicki
Copy link
Contributor

@WoLewicki WoLewicki commented Dec 21, 2022 •
edited by roryabraham
Loading

PR turning on the new architecture in the Expensify App as well as changing the libraries with native components to the commits containing implementation of Fabric integration in them.

Upstream PRs for the added patches

Fixed Issues

$ #8503

List of all the reported issues from Applause
  • Sign out - The blank page after tap sign out (#14371, #18726)
  • iOS - Payment -Background of the GIF about the successful addition of payment method is lighter (#18732)
  • Android - Chat - Сhat history isn't displayed if you send messages with multiple line breaks(5 and more) (#18731)
  • Android - Chat - User unable to select any emojis (#18721)
  • Android - App is flashing when selecting Fub menu and than tapping outside of the field (#18722)
  • Android - Chat - User unable to select any options in Fub menu and conversation (#18724)
  • Android - Chat - Content menu does not work (#18730)
  • Android - Log in - The page blinks when tap "Go back" button" (#14370)
  • Android - Chat - First letter is shaking in composed box (#14367)
  • Android - Bank Account - "Something went wrong" page instead of Onfido during KYC flow (#18740)
  • Android - Deeplink - The app doesn't open to the login screen. mWeb/Chrome is opened (#14366, #18723, #18750)
  • Android - IOU preview shows default avatars instead of current ones (#18733)
  • iOS - Second keyboard opens when you click on the cursor in Request money (#14372)
  • iOS - Log in - App flickers when open it (#16799)
  • iOS - Profile - Avatar image rotates after saving (#18734)
  • iOS - Chat - Missing 'Expand' icon in the text input field (#14369)
  • iOS - "Global action" - "Back" and "Close" button does not work (#16795)
  • iOS - Profile - The Profile section is not clickable (#16796)
  • iOS - Settings- Can not select language and priority mode under Preference page (#16808)
  • iOS - Chat - Buttons Cancel, Save changes and emoji are not clickable when edit the message (#16810)
  • iOS - Chat - Emoji are cut off at the top when used in text (#16824)
  • iOS - Chat - Focus is lost when editing is selected (#16814)
  • iOS - Markdown does not work for bold * / _ tags. header tag # resizes font not make text bold (#16815)
  • iOS - Chat - Unable to download a .docx file (#16809)
  • iOS - Sign in - No skeleton appears when log in with account (#16806)
  • iOS - User can not copy and paste the magic code, also unable to open the keyboard (#18719)
List of all the reported issues reported by ishpaul777

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

AndrewGable and others added 4 commits October 28, 2022 11:34
@AndrewGable
Merge branch 'main' into andrew-fabric
709b733
@AndrewGable
Update from main
0f66f43
@roryabraham
Merge branch 'main' into andrew-fabric
273cf07 
# Conflicts:
#	ios/Podfile.lock
#	package-lock.json
#	package.json
#	src/pages/home/ReportScreen.js
#	src/pages/home/sidebar/SidebarLinks.js
@roryabraham
Reinstall packages after merging main
c3f4342
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@WoLewicki
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@roryabraham roryabraham mentioned this pull request Dec 21, 2022
Closed
@AndrewGable AndrewGable added Ready To Build Daily KSv2 and removed Daily KSv2 labels Jan 2, 2023
@AndrewGable
Copy link
Contributor

6d97b2b is failing for web and desktop builds, however, here is iOS and Android testing links:

  1. https://ad-hoc-expensify-cash.s3.amazonaws.com/android/13767/index.html
  2. https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/13767/index.html

@j-piasecki
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@mvtglobally mvtglobally mentioned this pull request Jan 6, 2023
Closed
1 task
This was referenced Jan 7, 2023
Closed
Closed
@kbecciv

This comment was marked as duplicate.

Sign in to view
@kbecciv

This comment was marked as duplicate.

Sign in to view
@kbecciv

This comment was marked as duplicate.

Sign in to view
@kbecciv

This comment was marked as duplicate.

Sign in to view
@kbecciv

This comment was marked as duplicate.

Sign in to view
@kbecciv

This comment was marked as duplicate.

Sign in to view
@kbecciv

This comment was marked as duplicate.

Sign in to view
@kbecciv

This comment was marked as duplicate.

Sign in to view
This was referenced Jan 17, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 12, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 22, 2024
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
jakex7 pushed a commit to software-mansion/react-native-svg that referenced this pull request Aug 23, 2024
@WoLewicki
feat: add load method (#2427)
4a5674d 
## PR concerning New Architecture support in the library 🎉

We at [Software Mansion](https://swmansion.com/) have been working on
[improving
support](https://blog.swmansion.com/sunrising-new-architecture-in-the-new-expensify-app-729d237a02f5)
for the new architecture for quite a while now. If you need help with
anything related to New Architecture, like:
- [migrating your
library](https://x.com/swmansion/status/1717512089323864275)
- [migrating your app](Expensify/App#13767)
- [investigating
issues](https://github.com/facebook/react-native/pulls?q=sort%3Aupdated-desc+is%3Apr+author%3Aj-piasecki+is%3Aopen)
- [improving
performance](https://x.com/BBloniarz_/status/1808138585528303977)

or you just want to ask any questions, hit us up on
[[email protected]](mailto:[email protected])

---

## Summary
<!-- Simple summary of what was changed. -->

PR adding `load` method needed for dynamic frameworks to work with the
library. See facebook/react-native#37274 for
more information.
kirillzyusko pushed a commit to kirillzyusko/react-native-keyboard-controller that referenced this pull request Aug 23, 2024
@WoLewicki
feat: add load method (#564)
6a2332b 
## PR concerning New Architecture support in the library 🎉

We at [Software Mansion](https://swmansion.com/) have been working on
[improving
support](https://blog.swmansion.com/sunrising-new-architecture-in-the-new-expensify-app-729d237a02f5)
for the new architecture for quite a while now. If you need help with
anything related to New Architecture, like:
- [migrating your
library](https://x.com/swmansion/status/1717512089323864275)
- [migrating your app](Expensify/App#13767)
- [investigating
issues](https://github.com/facebook/react-native/pulls?q=sort%3Aupdated-desc+is%3Apr+author%3Aj-piasecki+is%3Aopen)
- [improving
performance](https://x.com/BBloniarz_/status/1808138585528303977)

or you just want to ask any questions, hit us up on
[[email protected]](mailto:[email protected])

---

## Summary
<!-- Simple summary of what was changed. -->

PR adding `load` method needed for dynamic frameworks to work with the
library. See facebook/react-native#37274 for
more information.
@lakchote lakchote mentioned this pull request Sep 23, 2024
Merged
60 tasks
This was referenced Oct 2, 2024
Merged
Merged
This was referenced Oct 11, 2024
Merged
Merged
@WoLewicki WoLewicki mentioned this pull request Nov 26, 2024
Open
@lakchote lakchote mentioned this pull request Dec 9, 2024
Merged
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayata-suenaga hayata-suenaga hayata-suenaga left review comments

@aldo-expensify aldo-expensify aldo-expensify left review comments

@roryabraham roryabraham roryabraham approved these changes

@j-piasecki j-piasecki j-piasecki left review comments

@hungvu193 hungvu193 hungvu193 left review comments

@mrousavy mrousavy mrousavy left review comments

@wildan-m wildan-m wildan-m left review comments

@pecanoro pecanoro pecanoro left review comments

@shawnborton shawnborton shawnborton left review comments

@stitesExpensify stitesExpensify Awaiting requested review from stitesExpensify

@ishpaul777 ishpaul777 Awaiting requested review from ishpaul777

Assignees

@WoLewicki WoLewicki

Labels
Ready To Build
Projects
No open projects
RN: New Architecture
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.