[$500] Workspace-Collect workspace doesn't show up on the employee side unless sign out and sign in

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43.0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-internl Team
Slack conversation:

Action Performed:

1. Sign in with a new account on ND as account B
2. Create a collect workspace on OD
3. Invite account B as an employee to the workspace created on step 2
4. Refresh the page on account B
5. Sign out from account B and then sign in again

Expected Result:

Workspace should show up on account B's side once user B gets invited as an employee

Actual Result:

Workspace doesn't show up on account B's side unless user B manually signs out and signs in again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6385540_1708423871577.categorybug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0150c1c74c4df3c641
• Upwork Job ID: 1764832159689936896
• Last Price Increase: 2024-03-05

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[stephanieelliott]

This is only affecting one platform and is pretty minor, gonna opt to close

[kbecciv]

Reopening the issue, QA team is able to reproduce on two platforms: mWeb/safari and Mac/Safari

RPReplay_Final1709331027.mp4

Screen.Recording.2024-03-01.at.23.45.54.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0150c1c74c4df3c641

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[stephanieelliott]

Hey @DylanDylann can you check me on this one -- I think this may need a BE fix, but I am not 100% sure

[DylanDylann]

There is only announce report is displayed in the employee account and the new workspace isn't added to the workspace list

The RCA is the BE return policy.isPolicyExpenseChatEnabled is false and the new workspace is hidden by this logic

App/src/libs/PolicyUtils.ts

Lines 92 to 96 in a79c119

	function shouldShowPolicy(policy: OnyxEntry<Policy>, isOffline: boolean): boolean {
	return (
	!!policy && policy?.isPolicyExpenseChatEnabled && (isOffline || policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || Object.keys(policy.errors ?? {}).length > 0)
	);
	}

@stephanieelliott I think it is a BE bug

[melvin-bot]

@stephanieelliott @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@stephanieelliott @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[stephanieelliott]

Cool, thanks for looking at this @DylanDylann!

[melvin-bot]

Current assignee @DylanDylann is eligible for the Internal assigner, not assigning anyone new.

[stephanieelliott]

Adding this to #wave-collect to get a internal eng on this: https://expensify.slack.com/archives/C036QM0SLJK/p1709683811665219

[DylanDylann]

Not overdue, we are waiting for an eye from the internal engineer

[melvin-bot]

@stephanieelliott @DylanDylann this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[stephanieelliott]

This is polish, so not critical for launch. Will wait for this to be picked up.

[melvin-bot]

@stephanieelliott, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

[stephanieelliott]

No update, see #36877 (comment)

[melvin-bot]

@stephanieelliott @DylanDylann this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[stephanieelliott]

Still waiting for this to be picked up internally, its been posted in #wave-collect but considering this is polish it is lower priority

[stephanieelliott]

I think this is fixed -- I am unable to repro now. @izarutskaya can you retest please?

[stephanieelliott]

Still not reproducible, closing