[HOLD for payment 2024-03-07] [$500] Group - After selecting user in Group chat, the modal is not sliding upwards

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Click on the "+" > "Start chat"
4. Select user to "Add to group"

Expected Result:

User expects that when a user is selected, the modal is slid upwards to show the selection

Actual Result:

The modal does not slide upwards. Also, a few selected members are missing after scrolling back upwards.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393518_1709000644338.Chat_view_is_not_sliding_upwards_on_Staging_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013e254d49afd2fba2
• Upwork Job ID: 1762306611837190144
• Last Price Increase: 2024-02-27
• Automatic offers:
• ishpaul777 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013e254d49afd2fba2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

Production:

Bug6393518_1709000644345.On_PROD.mp4

[youssef-lr]

This seems to be coming from here, I reverted it locally and I can't reproduce. cc @Piotrfj @allroundexperts.

[askavyblr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The modal does not slide upwards when the user selects "Add to group"

What is the root cause of that problem?

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 417 to 437 in 1c0d6b9

	useEffect(() => {
	const newSections = sliceSections();
	const newOptions = flattenSections();
	if (prevLocale.current !== props.preferredLocale) {
	prevLocale.current = props.preferredLocale;
	setAllOptions(newOptions);
	setSections(newSections);
	return;
	}
	const newFocusedIndex = props.selectedOptions.length;
	const prevFocusedOption = _.find(newOptions, (option) => focusedOption && option.keyForList === focusedOption.keyForList);
	const prevFocusedOptionIndex = prevFocusedOption ? _.findIndex(newOptions, (option) => focusedOption && option.keyForList === focusedOption.keyForList) : undefined;
	setSections(newSections);
	setAllOptions(newOptions);
	setFocusedIndex(prevFocusedOptionIndex || (_.isNumber(props.focusedIndex) ? props.focusedIndex : newFocusedIndex));
	// we want to run this effect only when the sections change
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [props.sections]);

What changes do you think we should make in order to solve the problem?

set the setFocusedIndex when the selection gets changed

What alternative solutions did you explore? (Optional)

CreateGroup-U.webm

[techievivek]

@Piotrfj @allroundexperts Can you please take care of this deployblocker.

[nagypite]

There's some scrolling happening, but mostly to the wrong position (just below the selected list).

Additionally the selection logic seems to be faulty as well: the selected options sometimes reset when a new option is selected.

Here is a recording to prove the above points (left side: prod, right side: staging):

Screencast at: 2024-02-27 11-06-34.webm

[melvin-bot]

📣 @nagypite! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[nagypite]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0161b2e93e88f95be5

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[allroundexperts]

This might fix this issue as well.

[allroundexperts]

Will test and confirm.

[allroundexperts]

Okay. @Piotrfj is on it already!

[askavyblr]

I update the proposal plz take a look
cc: @allroundexperts

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

@kevinksullivan FYI @ishpaul777 will need to be paid out for being the C+ on this revert PR: #37454

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert 31606 #37454

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @ishpaul777 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kevinksullivan]

@ishpaul777 please complete the checklist above so we can wrap up payments.

[ishpaul777]

[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: #31606

[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #31606 (comment)

[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a straight revert

[@ishpaul777] Determine if we should create a regression test for this bug. - This was caught from QA for a big refactor PR so we dont need one

[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. - n/a
nope

[melvin-bot]

@kevinksullivan, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

@kevinksullivan Gentle bump for payment!

[mallenexpensify]

Contributor+: @ishpaul777 paid $500 via Upwork

@ishpaul777 , I created a TestRail for this because QA does monthly tests for edge cases and design-related issues and they might want to include this.
https://github.com/Expensify/Expensify/issues/378695

Thx!