[HOLD for payment 2024-03-29] [$500][Simplified Collect][Tags] Implement DeleteWorkspaceTags

[luacmartins]

Implement this section of the Simplified Collect: Tags design doc

cc @waterim

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0155b70726d736408f
• Upwork Job ID: 1762500850869534720
• Last Price Increase: 2024-02-27

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[waterim]

Hello, Im Artem from Callstack and would like to take this one

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0155b70726d736408f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Current assignee @MitchExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[luacmartins]

Still on hold for the main page

[MitchExpensify]

PR was merged so I'm taking this off hold!

[MitchExpensify]

Are we good to apply Help Wanted on this now @luacmartins ?

[luacmartins]

@waterim I've asked @allroundexperts to get started on implementing the delete functionality while you finish settings and edit pages. Hope that's ok!

[allroundexperts]

Draft PR created #38453

This has some conflicts because the PR it is based from has conflicts as well.

I will make it it ready for review once the base PR gets merged.

[allroundexperts]

Okay. I was mistaken. The main branch already had the tag setting page created. As such, we don't need to base off from the above branch. The PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add tag delete option #38453
• Use correct DeletePolicyTags api command name #38606

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @waterim does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[MitchExpensify]

Reminder set to pay.

Payment summary:

C+ $500 @allroundexperts (NewDot)

[JmillsExpensify]

$500 approved for @allroundexperts

[Ollyws]

@MitchExpensify I just noticed I was never paid for my review of #38453, any chance you could help with that? Thanks!

[MitchExpensify]

Can do, Payment job here https://www.upwork.com/jobs/~011908d15db493b1bf @Ollyws

[Ollyws]

@MitchExpensify Accepted, thanks!

[MitchExpensify]

Done!