Add tag delete option #38453

allroundexperts · 2024-03-17T20:04:29Z

Details

Adds the ability to delete a policy tag

Fixed Issues

$ #37314
PROPOSAL: N/A

Tests

Create a Control workspace in OD
Enter the following in the console, while the workspace is open:

var p = Policy.getActive();
p.policy.areTagsEnabled = true;
p.save();

Open ND and go to workspace settings -> tags
Create a tag
Click on the created tag to open tag settings page
Click on the three dots menu and press delete tag and confirm deletion
Verify that the tag gets deleted successfully

Verify that no errors appear in the JS console

Offline tests

Create a Control workspace in OD
Enter the following in the console, while the workspace is open:

var p = Policy.getActive();
p.policy.areTagsEnabled = true;
p.save();

Open ND and go to workspace settings -> tags
Create a tag
Go offline
Click on the created tag to open tag settings page
Click on the three dots menu and press delete tag and confirm deletion
Verify that the tag gets crossed but is still visible
Go online and verify that the tag gets completely removed

QA Steps

Create a Control workspace in OD
Enter the following in the console, while the workspace is open:

var p = Policy.getActive();
p.policy.areTagsEnabled = true;
p.save();

Open ND and go to workspace settings -> tags
Create a tag
Click on the created tag to open tag settings page
Click on the three dots menu and press delete tag and confirm deletion
Verify that the tag gets deleted successfully

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-18.at.1.53.00.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-03-18.at.1.48.45.AM.mov

iOS: Native

Screen.Recording.2024-03-18.at.1.49.51.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-18.at.1.42.50.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-18.at.1.35.50.AM.mov

Screen.Recording.2024-03-18.at.1.36.14.AM.mov

MacOS: Desktop

Screen.Recording.2024-03-18.at.1.39.26.AM.mov

melvin-bot · 2024-03-17T20:56:28Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/languages/es.ts

trjExpensify · 2024-03-18T18:42:42Z

@allroundexperts oh no, pesky conflicts! 😱 😅

Ollyws · 2024-03-18T19:54:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

OSBotify · 2024-03-19T23:51:37Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-20T00:52:12Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

deetergp · 2024-03-20T20:59:46Z

I believe this issue is related to this bug #38683

deetergp · 2024-03-20T21:01:32Z

I'm not even sure we care right now, since dependent tags are not yet available in NewDot. The only way to test it is to import them in OldDot, I did so with this csv and was able to reproduce.

OSBotify · 2024-03-22T16:10:59Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.55-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts mentioned this pull request Mar 17, 2024

[HOLD for payment 2024-03-29] [$500][Simplified Collect][Tags] Implement DeleteWorkspaceTags #37314

Closed

add delete functionality

faddd9b

allroundexperts force-pushed the feat-37314 branch from ee14df7 to faddd9b Compare March 17, 2024 20:34

allroundexperts marked this pull request as ready for review March 17, 2024 20:56

allroundexperts requested a review from a team as a code owner March 17, 2024 20:56

melvin-bot bot requested review from Ollyws and removed request for a team March 17, 2024 20:56

Ollyws reviewed Mar 18, 2024

View reviewed changes

src/languages/es.ts Show resolved Hide resolved

luacmartins requested review from luacmartins and Ollyws March 18, 2024 15:46

Merge branch 'main' into feat-37314

a2941af

Ollyws approved these changes Mar 18, 2024

View reviewed changes

luacmartins approved these changes Mar 18, 2024

View reviewed changes

luacmartins merged commit 66eda14 into Expensify:main Mar 18, 2024
16 checks passed

github-actions bot mentioned this pull request Mar 19, 2024

Deploy Checklist: New Expensify 2024-03-19 #38651

Closed

66 tasks

deetergp mentioned this pull request Mar 20, 2024

[HOLD for payment 2024-06-06] [Awaiting NewDot Request] [$250] [Simplified Collect][Tags] - Error when deleting dependent tags and unable to dismiss the error #38683

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tag delete option #38453

Add tag delete option #38453

allroundexperts commented Mar 17, 2024 •

edited

Loading

melvin-bot bot commented Mar 17, 2024

trjExpensify commented Mar 18, 2024

Ollyws commented Mar 18, 2024

Ollyws left a comment

OSBotify commented Mar 19, 2024

OSBotify commented Mar 20, 2024

deetergp commented Mar 20, 2024

deetergp commented Mar 20, 2024

OSBotify commented Mar 22, 2024

Add tag delete option #38453

Add tag delete option #38453

Conversation

allroundexperts commented Mar 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 17, 2024

trjExpensify commented Mar 18, 2024

Ollyws commented Mar 18, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 19, 2024

OSBotify commented Mar 20, 2024

deetergp commented Mar 20, 2024

deetergp commented Mar 20, 2024

OSBotify commented Mar 22, 2024

allroundexperts commented Mar 17, 2024 •

edited

Loading