[$500] [HOLD for payment 2024-03-11] [HOLD for payment 2024-03-07] Workspace - Workspace avatar is missing in Profile page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.45-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings.
3. Select a workspace.
4. Go to Profie.
5. If there is no workspace, create a new one, navigating between different workspace tabs and then back to Profile until the avatar disappears.

Expected Result:

Workspace avatar will be visible.

Actual Result:

Workspace avatar is missing.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6396447_1709169649154.bandicam_2024-02-29_08-30-56-846__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01df14be8421063b01
• Upwork Job ID: 1766972826759442432
• Last Price Increase: 2024-03-10

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

We (applause) think this bug might be related to #wave5-free-submitters
cc @dylanexpensify

[m-natarajan]

@MonilBhavsar FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[hungvu193]

Regression from #36849

[ghost]

I think this :

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 69 in 3e74ddf

source={policy?.avatar ?? ReportUtils.getDefaultWorkspaceAvatar(policyName)}

is the main culprit behind the above issue.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace avatar is missing.

What is the root cause of that problem?

The workspace that has no avatar policy.avatar is empty so this policy?.avatar ?? ReportUtils.getDefaultWorkspaceAvatar(policyName) will return '' and then no avatar is displayed.

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 69 in 3e74ddf

source={policy?.avatar ?? ReportUtils.getDefaultWorkspaceAvatar(policyName)}

What changes do you think we should make in order to solve the problem?

We should change this by checking policy.avatar is empty or not like this

source={!policy?.avatar ? ReportUtils.getDefaultWorkspaceAvatar(policyName) : policy?.avatar}

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 69 in 3e74ddf

source={policy?.avatar ?? ReportUtils.getDefaultWorkspaceAvatar(policyName)}

What alternative solutions did you explore? (Optional)

NA

[situchan]

Heads up: I first commented here so not accepting proposals.
Ideally this should be fixed by PR author cc: @blazejkustra

[blazejkustra]

Draft PR is up!

[blazejkustra]

PR is ready for review 😄

[MonilBhavsar]

This has been fixed now. Thanks all!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix missing default workspace avatar #37480

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@blazejkustra] Determine if we should create a regression test for this bug.
• [@blazejkustra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix missing default workspace avatar #37480

If no regressions arise, payment will be issued on 2024-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@blazejkustra] Determine if we should create a regression test for this bug.
• [@blazejkustra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mkhutornyi]

Please assign me here for reviewing linked PR

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01df14be8421063b01

[melvin-bot]

Current assignee @mkhutornyi is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

@mkhutornyi , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01df14be8421063b01

[melvin-bot]

@mallenexpensify, @MonilBhavsar, @blazejkustra, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Contributor+: @mkhutornyi paid $500 via Upwork.

@mkhutornyi , can you fill out the BZ checklist above plz? I'm unsure if we'll want to check this on every release or monthly, QA can decide.

• [$500] [HOLD for payment 2024-03-11] [HOLD for payment 2024-03-07] Workspace - Workspace avatar is missing in Profile page #37465 (comment)

[mkhutornyi]

• The PR that introduced the bug has been identified. Link to the PR: Bump eslint-config-expensify version in E/App #36849
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Bump eslint-config-expensify version in E/App #36849 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A This caught have been caught earlier during PR review
• Regression Test: No. This was caught during regression test.

[mallenexpensify]

Thanks @mkhutornyi , closing