[HOLD for Payment 2024-09-24] Implement Android conversation notifications

[arosiclair]

In Android 11, conversation notifications were added that offer a richer notification experience for messaging.

Conversation notifications are placed highest in the notification shade and prominently display avatars and names with the app's logo in the corner. Individual notifications can be marked as a priority allowing them to cut through Do Not Disturb settings. This is very similar to communication notifications which we implemented for iOS here.

• Android docs

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[arosiclair]

FYI this is a copy of the old internal issue here: https://github.com/Expensify/Expensify/issues/258528

[arosiclair]

From the docs, we need to implement these to get conversation notifications

• The notification uses MessagingStyle.
• (Only if the app targets Android 11 or higher) The notification is associated with a valid long-lived dynamic or cached sharing shortcut. The notification can set this association by calling setShortcutId() or setShortcutInfo(). If the app targets Android 10 or lower, the notification doesn't have to be associated with a shortcut, as discussed in the fallback options section.

Which means we should just need to implement sharing shortcuts. I'm going to look for a contributor to work on this.

@robertKozik you worked on our last issue for clearing notifications on Android. Would you be interested in working on this as well?

[staszekscp]

Hey @arosiclair! I can take care of this feature, because currently I work on the HybridApp, where we will refactor notifications in order to make sure they work for both OldDot, and NewDot. However, could we slightly wait with implementation of this feature? I just want to make sure that the notifications work fine after the refactor, and then, as a follow-up, I will add the conversation notifications on Android.

[arosiclair]

Makes sense I'll assign you and put this on hold. Keep us updated 🙏

[bfitzexpensify]

Still held @staszekscp?

[arosiclair]

Still held I believe. cc @staszekscp for any updates

[staszekscp]

Hey! Sorry, I missed the previous comment - the PR with the refactor is open, I just have to find one fix for a bug that I noticed. After merging I will work on this issue - I have already done some small testing, and I think I know what needs to be done 😄

[bfitzexpensify]

Still held on https://github.com/Expensify/Mobile-Expensify/pull/12610

[bfitzexpensify]

Remains held

[bfitzexpensify]

Stil held on https://github.com/Expensify/Mobile-Expensify/pull/12610

[arosiclair]

Asked for an update on the PR. Still held for now.

[rayane-djouah]

@arosiclair Could you please trigger an Adhoc build for #47626? thanks!

[bfitzexpensify]

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.

Current status: PR being worked on in #47626

[melvin-bot]

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[rayane-djouah]

@garrettmknight / @bfitzexpensify I reviewed the PR #47626 as C+, please assign me here. Thanks!

[rayane-djouah]

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-24] according to #49287 production deploy checklist, confirmed in #47626 (comment)

[garrettmknight]

Awaiting payment

[bfitzexpensify]

I'm back from OOO, and can take this one back over - thanks for keeping an eye on it @garrettmknight

[bfitzexpensify]

Payment summary:

@staszekscp - contractor, no payment required
@rayane-djouah - $250 to be paid for PR review via Upwork

Offer sent via Upwork @rayane-djouah

[rayane-djouah]

@bfitzexpensify - Offer accepted, thank you!

[rayane-djouah]

Checklist

• Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

Regression Test Proposal

• Android native only test:

1. Log into NewDot on the Android native app.
2. Accept the notification permission prompt.
3. Exit (leave) the app.
4. From another account, send yourself a direct message (DM).
5. Long press on the NewDot app icon.
6. Verify that a message notification shortcut is displayed.
7. Tap on the message notification shortcut and verify that the app opens the notification report.
8. Exit the app again.
9. Long press on the app icon.
10. Verify that a conversation shortcut is displayed for the last notification report.
11. Tap on the conversation shortcut and verify that the app opens the notification report.
12. Log out from the app.
13. Long press on the app icon.
14. Verify that there are no shortcuts (the previous shortcuts are cleared).

Do we agree 👍 or 👎

[bfitzexpensify]

Regression steps proposed in https://github.com/Expensify/Expensify/issues/430593

Payment complete. Closing this one out!