Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Medium] Create Trip Details #37823

Open
stitesExpensify opened this issue Mar 6, 2024 · 49 comments
Open

[Medium] Create Trip Details #37823

stitesExpensify opened this issue Mar 6, 2024 · 49 comments

Comments

@stitesExpensify
Copy link
Contributor

stitesExpensify commented Mar 6, 2024

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.lgcmthyxnpmx

This issue is for creating a new trip details modal:
2024-03-06_08-26-27

A new page, TravelDetails.ts will be created in src/pages/Travel:

  • It will receive the transactionID as a route parameter, which we’ll use to retrieve the full transaction via withOnyx, and, from there, we’ll display the travel-related information
  • It will include a HeaderWithBackButton component with either “Flight Details” or “Hotel Details” as the title, depending on whether it is a flight or a hotel booking. Similarly, it will either display a plane or a hotel icon, which we will pass to HeaderWithBackButton through the new parameter added here. - - For other travel-related expenses (Trains, car rental), the title will default to the generic “Travel Details” and the plane icon (we can change this down the line).
  • The itinerary and confirmation number elements will be displayed using the existing MenuItemWithTopDescription component with the interactive parameter set to false. For the itinerary’s arrow for flights, we can use the ➜ unicode character.
  • A new component, TripDetailsMenuItem will be created to display the detailed itinerary (with the airline, airports, etc). It will receive the travel-related information from the transaction as a parameter and will be formatted as displayed above. Since the user can’t interact with the element in any way, there is no need for further considerations.
  • The trip support link will be displayed using the existing MenuItem component, passing our phone icon as the icon. On click, it will take the user to Spotnana’s support page.

Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx

Issue OwnerCurrent Issue Owner: @shubham1206agra
@cdOut
Copy link
Contributor

cdOut commented Mar 8, 2024

Hello, I’m Tymoteusz from Software Mansion, the expert agency, and I’d like to work on this task.

@twisterdotcom
Copy link
Contributor

Adding a C+ here for Travel reviews: @shubham1206agra

@twisterdotcom
Copy link
Contributor

Only assigned on Friday. We can give them a day here Melvin.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 11, 2024
Copy link

melvin-bot bot commented Mar 14, 2024

@twisterdotcom, @shubham1206agra, @cdOut Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@twisterdotcom
Copy link
Contributor

Are we waiting on anything internal here?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 14, 2024
@cdOut
Copy link
Contributor

cdOut commented Mar 18, 2024

No, Im working on creating a draft PR for this issue by tomorrow.

@twisterdotcom
Copy link
Contributor

Nice, draft PR is in!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 29, 2024
@twisterdotcom
Copy link
Contributor

Same Q, answer in one place is fine: #37824 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2024
@cdOut
Copy link
Contributor

cdOut commented Apr 4, 2024

@twisterdotcom both PRs are linked, we are currently waiting for the backend implementation, since right now we basically work on dummy data.

From what I know it has been decided that we will hold off on these PRs with further reviews until we get backend access, you can refer to this decision here.

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@twisterdotcom
Copy link
Contributor

Still waiting on webhooks.

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@kevinksullivan kevinksullivan changed the title [CRITICAL] Create Trip Details [HIGH] Create Trip Details Jul 24, 2024
@kevinksullivan kevinksullivan moved this from Critical - GBTA July 22 to High - Summer Release in [#whatsnext] #travel 2025-02-01 - External Commit Jul 24, 2024
@kevinksullivan
Copy link
Contributor

Demoting to HIGH, as I don't think this prevents launching to 5k customers or announcing. Also, conversation on design is ongoing here, so this may take a few more days to nail down.

https://expensify.slack.com/archives/C05S5EV2JTX/p1721737498827189

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Jul 26, 2024
Copy link

melvin-bot bot commented Jul 26, 2024

This issue has not been updated in over 15 days. @twisterdotcom, @shubham1206agra, @cdOut eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 26, 2024
@kevinksullivan kevinksullivan changed the title [HIGH] Create Trip Details [MEDIUM] Create Trip Details Aug 8, 2024
@kevinksullivan kevinksullivan moved this from High - SuiteWorld September 9 to Medium - Intuit Connect October 28 in [#whatsnext] #travel 2025-02-01 - External Commit Aug 8, 2024
@kevinksullivan kevinksullivan changed the title [MEDIUM] Create Trip Details [HIGH] Create Trip Details Aug 26, 2024
@melvin-bot melvin-bot bot closed this as completed Sep 23, 2024
Copy link

melvin-bot bot commented Sep 23, 2024

@twisterdotcom, @shubham1206agra, @cdOut, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@shubham1206agra
Copy link
Contributor

@twisterdotcom Please reopen this

@twisterdotcom twisterdotcom reopened this Sep 24, 2024
@github-project-automation github-project-automation bot moved this from Done to Critical - Intuit Connect October 28 in [#whatsnext] #travel 2025-02-01 - External Commit Sep 24, 2024
@stitesExpensify stitesExpensify changed the title [HIGH] Create Trip Details [VIP-Travel][FUTURE] Create Trip Details Sep 27, 2024
@stitesExpensify stitesExpensify moved this from Critical to Future - NewDot in [#whatsnext] #travel 2025-02-01 - External Commit Sep 27, 2024
@stitesExpensify stitesExpensify changed the title [VIP-Travel][FUTURE] Create Trip Details [FUTURE] Create Trip Details Sep 27, 2024
@blazejkustra
Copy link
Contributor

Hey! I'm going to take over from @cdOut. Feel free to tag me when you're ready to revisit this issue 😄

@mountiny mountiny assigned blazejkustra and unassigned cdOut Nov 14, 2024
@stitesExpensify stitesExpensify changed the title [FUTURE] Create Trip Details [Medium] Create Trip Details Nov 18, 2024
@stitesExpensify
Copy link
Contributor Author

@blazejkustra We're ready!

@stitesExpensify stitesExpensify self-assigned this Nov 18, 2024
@blazejkustra
Copy link
Contributor

Update: I started implementing this screen but I'm a bit blocked, waiting on responses on slack here

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Nov 29, 2024
@blazejkustra
Copy link
Contributor

Update: PR is ready for internal review. Sorry for now updating here directly, I was doing it daily on #vip-travel slack channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Medium - NewDot MVP - Feb '25
Development

No branches or pull requests

7 participants