-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Medium] Create Trip Details #37823
Comments
Hello, I’m Tymoteusz from Software Mansion, the expert agency, and I’d like to work on this task. |
Adding a C+ here for Travel reviews: @shubham1206agra |
Only assigned on Friday. We can give them a day here Melvin. |
@twisterdotcom, @shubham1206agra, @cdOut Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Are we waiting on anything internal here? |
No, Im working on creating a draft PR for this issue by tomorrow. |
Nice, draft PR is in! |
Same Q, answer in one place is fine: #37824 (comment) |
@twisterdotcom both PRs are linked, we are currently waiting for the backend implementation, since right now we basically work on dummy data. From what I know it has been decided that we will hold off on these PRs with further reviews until we get backend access, you can refer to this decision here. |
Still waiting on webhooks. |
Demoting to HIGH, as I don't think this prevents launching to 5k customers or announcing. Also, conversation on design is ongoing here, so this may take a few more days to nail down. https://expensify.slack.com/archives/C05S5EV2JTX/p1721737498827189 |
This issue has not been updated in over 15 days. @twisterdotcom, @shubham1206agra, @cdOut eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@twisterdotcom, @shubham1206agra, @cdOut, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
@twisterdotcom Please reopen this |
Hey! I'm going to take over from @cdOut. Feel free to tag me when you're ready to revisit this issue 😄 |
@blazejkustra We're ready! |
Update: I started implementing this screen but I'm a bit blocked, waiting on responses on slack here |
Update: PR is ready for internal review. Sorry for now updating here directly, I was doing it daily on |
VIP-Travel Implementation Issue
Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.lgcmthyxnpmx
This issue is for creating a new trip details modal:
A new page, TravelDetails.ts will be created in src/pages/Travel:
Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx
Issue Owner
Current Issue Owner: @shubham1206agraThe text was updated successfully, but these errors were encountered: