[vip-travel] Create Trip Details Screen #52823

blazejkustra · 2024-11-20T14:24:32Z

Explanation of Change

We're adding a new Trip Details Modal in NewDot, allowing users to view travel details directly in the app instead of being redirected to Spotnana. This includes creating a new page and components to display trip information like flights, hotels, rails and cars seamlessly.

Fixed Issues

$ #37823
PROPOSAL: N/A

Tests

To prepare your account and environment for testing, follow these steps:

1. Configure Your Account for Testing

Navigate to OldDot (ideally create new account)

Run the following JavaScript snippet in the console before enabling travel in the account:

var settings = NVP.get('travelSettings') || {};
settings.testAccount = true;
NVP.set('travelSettings', settings);

Verify that the test settings are successfully applied (NVP.get('travelSettings')).
Now you can enable travel in the account and proceed with testing (Search -> Trip -> book a trip)
Use stripe card ending in 4444 for testing purposes (https://docs.stripe.com/testing)
When reserving trips for testing purposes:
- Always book trips scheduled at least 1 month in the future.
Example:
- Flight: One-way trip from SEA (Seattle) to SFO (San Francisco).
- Airline: Alaska Airlines.
- Departure Date: At least 1 month from the current date.

Flight Details

Verify the page displays key information: departure/arrival times, duration of the flight, layovers, airline, seat, record locator, and cabin class.
Validate clickable actions: Modify trip and Trip support .
Ensure responsive design and alignment across devices.

Hotel Details

Confirm correct display of hotel name, address, check-in/out times, room type, and cancellation policy.
Check clickable actions: Modify trip and Trip support .
Verify overall layout for completeness and responsiveness.

Car Rental Details

Check the car rental name, pickup/drop-off details, car type, and cancellation policy.
Ensure the Modify trip and Trip support options are functional.
Validate formatting and responsiveness across devices.

Train/Rail Details

Verify the page displays key information: departure/arrival times, duration of the ride, layovers, airline, seat, record locator, and cabin class.
Validate clickable actions: Modify trip and Trip support .
Ensure responsive design and alignment across devices.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android-web.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

Nothing here 🤫

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…eDetails types

…rmat

…tion

…p content in ScrollView

This reverts commit 04d94db.

…ervation data and sort by start date

…ation data and improve navigation handling

…ntal information

blazejkustra · 2024-12-06T14:29:08Z

But also why would just opening a link take a long time?

Before opening a link, we make a request to generate signing credentials for travel page, that's why it could potentially take some time. I'm going to include a loading spinner, so it's not confusing when user has a bad internet connection.

shawnborton · 2024-12-06T14:31:00Z

Cool - thanks for explaining, that works for me 👍

dannymcclain · 2024-12-06T14:43:38Z

Awesome, appreciate the explanation! I'm down with including it too in that case 👍

blazejkustra · 2024-12-06T14:43:56Z

@shubham1206agra Back to you!

shubham1206agra · 2024-12-10T07:58:34Z

Please add a bottom padding. Unable to access the last button at all.
cc @SzymczakJ

shubham1206agra · 2024-12-10T10:49:04Z

Address is getting cut off here.

shubham1206agra · 2024-12-10T10:50:50Z

Not related to this PR. But the preview is overflowing.

SzymczakJ · 2024-12-10T12:20:47Z

Fixed your comments @shubham1206agra!

shubham1206agra · 2024-12-10T12:37:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/languages/es.ts

SzymczakJ · 2024-12-12T15:09:44Z

@blazejkustra told me that he has already confirmed these translation on open-source, but I couldn't find it anywhere. If yes then ignore my comment 😄
Nevertheless bumping this PR!
FYI I'm OOO tomorrow

stitesExpensify · 2024-12-13T20:31:26Z

I posted in the translation channel to confirm, I'll post any updates here when I get them

blazejkustra · 2024-12-16T09:57:47Z

but I couldn't find it anywhere.

Slack is confusing as I have two accounts on open source channel, that's why @SzymczakJ couldn't find my messages 😅

These translations were all confirmed in these two threads:

@stitesExpensify So we can move forward 🚀

stitesExpensify

Looks fantastic, can't wait for this to go live!

blazejkustra · 2024-12-18T17:03:32Z

@stitesExpensify Let's ignore Changed files ESLint check, this PR is already too big and in the past we made exceptions like this

melvin-bot · 2024-12-18T17:22:17Z

@stitesExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

stitesExpensify · 2024-12-18T17:22:59Z

Not an emergency, this is a very big PR that will continue to have conflicts if we don't move quickly

OSBotify · 2024-12-18T17:31:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

blazejkustra added 18 commits November 26, 2024 11:46

Create trip details screen

a33274b

Add translation for trip support

15c9ae3

Add undefined type for trip details

3ae7f98

Fix navigation config

d2e1df5

Link the correct backTo on trip details screen

7394a09

Access data and fix getTripIDFromTransactionParentReportID

2c9d2a8

Add english translations

610ed48

Make reservationType optional in getTripReservationIcon function

644243c

Add arrivalGate and cityName fields to Reservation and ReservationTim…

d5dd2af

…eDetails types

Enhance getFormattedTransportDate function to support shorter date fo…

6c89f5a

…rmat

Add FlightTripDetails component to display flight reservation informa…

b47f8a2

…tion

Integrate FlightTripDetails component into TripDetails screen and wra…

aeddf58

…p content in ScrollView

Final touches

ae39590

Fix flight page after design changes

2954e6a

Change TripDetails into TripDetailsPage

08fd3fb

Create HotelTripDetails

6e71d43

Add missing translation

4ff355f

Revert "Final touches"

2eb1bb9

This reverts commit 04d94db.

blazejkustra force-pushed the feature/trip-details branch from 94cabfb to 2eb1bb9 Compare November 26, 2024 10:48

blazejkustra added 8 commits November 26, 2024 11:52

Remove flight from hotel page

503cf60

Add a blank line for improved readability in HotelTripDetails component

a4a0cde

Add CarTripDetails component for displaying car rental information

30e27d1

Refactor getReservationsFromTripTransactions to return structured res…

a8b78f8

…ervation data and sort by start date

Add translation for rental car

f4f5501

Fix navigation route in MoneyRequestView to use parentReportID

d49cdce

Refactor TripDetailsView and TripRoomPreview to use structured reserv…

092e430

…ation data and improve navigation handling

Add CarTripDetails component to TripDetailsPage for displaying car re…

6c59ca4

…ntal information

blazejkustra changed the title ~~Feature/trip details~~ [vip-travel] Create Trip Details Screen Nov 26, 2024

blazejkustra added 2 commits November 27, 2024 18:29

Add Trip Summary screen

49f946f

Add address translation to common

9c5963e

blazejkustra added 3 commits December 6, 2024 15:38

Add loading state management for trip modification and support actions

0b6030f

Merge branch 'main' into feature/trip-details

4e075c8

Merge branch 'main' into feature/trip-details

d43a884

fix PR comments

8324be8

shubham1206agra reviewed Dec 10, 2024

View reviewed changes

src/languages/es.ts Show resolved Hide resolved

shubham1206agra approved these changes Dec 10, 2024

View reviewed changes

melvin-bot bot requested a review from stitesExpensify December 10, 2024 12:39

Merge branch 'main' into feature/trip-details

d0776cf

blazejkustra added 2 commits December 16, 2024 11:11

Merge branch 'main' into feature/trip-details

ffe8522

Merge branch 'main' into feature/trip-details

990300e

stitesExpensify approved these changes Dec 18, 2024

View reviewed changes

stitesExpensify merged commit 8b9bd0e into Expensify:main Dec 18, 2024
15 of 16 checks passed

melvin-bot bot added the Emergency label Dec 18, 2024

stitesExpensify removed the Emergency label Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vip-travel] Create Trip Details Screen #52823

[vip-travel] Create Trip Details Screen #52823

blazejkustra commented Nov 20, 2024 •

edited

Loading

blazejkustra commented Dec 6, 2024

shawnborton commented Dec 6, 2024

dannymcclain commented Dec 6, 2024

blazejkustra commented Dec 6, 2024

shubham1206agra commented Dec 10, 2024 •

edited

Loading

shubham1206agra commented Dec 10, 2024

shubham1206agra commented Dec 10, 2024

SzymczakJ commented Dec 10, 2024

shubham1206agra commented Dec 10, 2024

SzymczakJ commented Dec 12, 2024 •

edited

Loading

stitesExpensify commented Dec 13, 2024

blazejkustra commented Dec 16, 2024

stitesExpensify left a comment

blazejkustra commented Dec 18, 2024

melvin-bot bot commented Dec 18, 2024

stitesExpensify commented Dec 18, 2024

OSBotify commented Dec 18, 2024

[vip-travel] Create Trip Details Screen #52823

[vip-travel] Create Trip Details Screen #52823

Conversation

blazejkustra commented Nov 20, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

1. Configure Your Account for Testing

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

blazejkustra commented Dec 6, 2024

shawnborton commented Dec 6, 2024

dannymcclain commented Dec 6, 2024

blazejkustra commented Dec 6, 2024

shubham1206agra commented Dec 10, 2024 • edited Loading

shubham1206agra commented Dec 10, 2024

shubham1206agra commented Dec 10, 2024

SzymczakJ commented Dec 10, 2024

shubham1206agra commented Dec 10, 2024

Reviewer Checklist

Screenshots/Videos

SzymczakJ commented Dec 12, 2024 • edited Loading

stitesExpensify commented Dec 13, 2024

blazejkustra commented Dec 16, 2024

stitesExpensify left a comment

Choose a reason for hiding this comment

blazejkustra commented Dec 18, 2024

melvin-bot bot commented Dec 18, 2024

stitesExpensify commented Dec 18, 2024

OSBotify commented Dec 18, 2024

blazejkustra commented Nov 20, 2024 •

edited

Loading

shubham1206agra commented Dec 10, 2024 •

edited

Loading

SzymczakJ commented Dec 12, 2024 •

edited

Loading