[HOLD for payment 2024-03-26] [HOLD for payment 2024-03-25] Category - Incorrect app behavior when editing category with / symbol

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.53-1
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: applause internal team

Action Performed:

Precondition:

• User is an admin of Collect workspace.
• The Collect workspace has the following categories:
  a/
  a/: invalid

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > any workspace.
3. Go to Categories.
   4, Click on the category a/.
4. Click Category name.
5. Note that the symbol / is missing.
6. Update the category name and save it.
7. Note that it creates a new category with an error instead of updating the previous category.
8. Create on the category a/: invalid > Category name.
9. Note that it shows not here page.

Expected Result:

User should be able to edit category with / in the name.

Actual Result:

For a/ category, when editing the name, the field is missing / symbol. When updating the name, it creates a new category with error instead of updating a new one.
For a/: invalid category, it shows not here page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6415047_1710514618649.20240315_193802.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[c3024]

I think this got to do with this.

App/src/ROUTES.ts

Line 574 in 15124d7

getRoute: (policyID: string, categoryName: string) => `workspace/${policyID}/categories/${encodeURI(categoryName)}/edit` as const,

We should use encodeURIComponent instead of encodeURI and decode it in the EditCategoryPage

cc: @ArekChr @luacmartins

[luacmartins]

Yes, I got this one. It's the same solution we have for tags and other pages.

[luacmartins]

PR here - #38412

[luacmartins]

Fixed in staging. Will keep this issue open to pay C+ for the PR review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix edit category #38412

If no regressions arise, payment will be issued on 2024-03-25. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

This is a new feature still in development. I don't think the BZ checklist applies here.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix edit category #38412
• Fix category decode #38426

If no regressions arise, payment will be issued on 2024-03-26. 🎊

[Christinadobrzyn]

Who are the C+ reviewers here that need to be paid?

@sobitneupane and @c3024 was it both of you? cc @luacmartins?

[sobitneupane]

@Christinadobrzyn I didn't review the PR.

[luacmartins]

@Christinadobrzyn this was handled internally. We can close this.