[HOLD for payment 2024-06-20] [Guided Setup Stage 2] Create Guided Setup messages and tasks from Expensify persona for every other user (Phase 2)

[francoisl]

Part of the "wave-collect – Build Stage 2 of Guided Setup" project

Main issue: https://github.com/Expensify/Expensify/issues/356685
Doc section: https://docs.google.com/document/d/10bhCv6XtzzqEZQ9tzxFwAz4lowgjOhsFqz13BMq6Iu4/edit#bookmark=id.be20bju15zhu
Project: https://github.com/orgs/Expensify/projects/129

Feature Description

When preparing the tasks and messages for the API command CompleteGuidedSetup, alternate between the Concierge account ID and Expensify persona account ID for every other user

cc @barttom

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c10eb14717d5fee
• Upwork Job ID: 1770904841304297472
• Last Price Increase: 2024-03-21

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c10eb14717d5fee

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[melvin-bot]

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[barttom]

Hello! I'm Bartek from Callstack, an expert contributor group, and I would like to work on this issue.

[trjExpensify]

Assigned you!

[trjExpensify]

I believe we're prioritising Phase 1 first.

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[trjExpensify]

Assigned you!

[burczu]

Hi, I’m Bartek from Callstack and I would like to take over of this issue.

[trjExpensify]

Still holding the PR on #38769.

[trjExpensify]

^^ False alarm. We started the prep 12 hours ago just before the authPR was merged, so it didn't make it. It'll go out tonight, will circle back when it goes out!

[koko57]

@trjExpensify I've resolved some conflicts and applied one minor change to the PR. I think the rest is ready to be reviewed after this PR https://github.com/Expensify/Auth/pull/10675 hits the prod.

I cannot open Bartek's PR, but I'm opening a draft from my fork with the same changes, let me know when to open it for the review.

Me and my team will be OOO tomorrow (05/01), so I will be able to address the comments on Thursday.

[trjExpensify]

Thanks! Can you open it for review? I'll add the hold in the title for the AuthPR in the meantime.

[melvin-bot]

This issue has not been updated in over 15 days. @burczu, @trjExpensify, @sobitneupane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

We're still held here, Melv.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Feature/38774 expensify persona #41343

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[sobitneupane]

Regression Test Proposal

1. Open the app with an entire new user.
2. Complete the onboarding flow.
3. Repeat steps 1-2 a few times (create a few new users).
4. Verify that after onboarding flow you're redirected either to the Concierge chat or Expensify persona

Do we agree 👍 or 👎

[trjExpensify]

Confirming payment as follows:

• $250 to @sobitneupane for the C+ review. Feel free to go ahead and request!

As for the regression tests, we'll add them centrally. I got the ball rolling on that here: https://github.com/Expensify/Expensify/issues/406205

Go ahead and request, Sobit!

[JmillsExpensify]

$250 approved for @sobitneupane