[HOLD for payment 2024-05-02] Distance - Map reloads with "Route pending" when clicking Save button without any changes

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to workspace chat.
3. Create a distance request.
4. Go to request details page.
5. Click Distance.
6. Click Save button without editing the addresses.

Expected Result:

Map will not reload. Distance row will not show Route pending (production behavior).

Actual Result:

Map reloads. Distance row shows Route pending when no edit is made to distance.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423602_1711135650912.20240323_032324.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #vip-bills

[paultsimura]

It's a regression from #34610

[puneetlath]

Looks like @DylanDylann is working on a fix as the original PR author.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[puneetlath]

Assigning @DylanDylann as they are working on this as a regression from their PR.

[puneetlath]

@DylanDylann how's this going?

[DylanDylann]

The PR will be ready on April 2, 2024 (GMT +7). Sorry for my delay because of a bit complicated

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

Seems to not have been fixed per this comment #40392 (comment)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[DylanDylann]

@mountiny I also see that this bug can be reproduced. But it is the regression from this PR

@kosmydel @ishpaul777 Tag you here because this is a regression from your PR

Could you explain why you update the key from ${ONYXKEYS.COLLECTION.TRANSACTION_BACKUP} to ${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}

[DylanDylann]

@kosmydel @ishpaul777 If it is a mistake, we should create a quick PR to resolve this problem

cc @mountiny

[mountiny]

Asked Jakub, thanks

[kosmydel]

@kosmydel @ishpaul777 If it is a mistake, we should create a quick PR to resolve this problem

Hey, thanks for reporting! I noticed that the _DRAFT was introduced in this commit. This appears to be a result of an incorrect conflict merge. I will look into it and prepare a pull request with the necessary changes.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix] Map reloads with "Route pending" #40674

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)

[puneetlath]

I believe this is a regression, so no new payments needed, correct?

[puneetlath]

Going to close, but @DylanDylann comment if I'm mistaken about the above.