Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed
github-actions bot opened this issue Apr 18, 2024 · 60 comments
Closed

Deploy Checklist: New Expensify 2024-04-18 #40392

github-actions bot opened this issue Apr 18, 2024 · 60 comments
Assignees
@mountiny @applausebot
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited by mountiny
Loading

Release Version: 1.4.63-21
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads
@kbecciv kbecciv added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 18, 2024
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.63-0 🚀

@kbecciv
Copy link

kbecciv commented Apr 18, 2024 •
edited
Loading

Internal QA - #38196, checking off
No QA - #39132, #39874, #40183, #40196, #40359, checking off
Prod QA - #39960, #39976, #39977, #39978, #39998, #40000, #40002, #40004,
#40006, #40207, #40378 - checking off

@Beamanator
Copy link
Contributor

Checked off #40405 b/c it wasn't reproducible by a few people

@rlinoz
Copy link
Contributor

rlinoz commented Apr 18, 2024

Checking off #40360 as it was from the previous checklist.

@twisterdotcom
Copy link
Contributor

Checking off #40412 as it's not a blocker.

@tgolen
Copy link
Contributor

tgolen commented Apr 18, 2024

Checking off #40458 as not a blocker

@rlinoz
Copy link
Contributor

rlinoz commented Apr 18, 2024

Demoting #40463

@amyevans
Copy link
Contributor

Checked off #40429 as intended design

@rlinoz
Copy link
Contributor

rlinoz commented Apr 18, 2024

Demoting #40422

@marcaaron
Copy link
Contributor

Demoting #40427

@amyevans
Copy link
Contributor

Demoting #40465

@marcaaron
Copy link
Contributor

Demoting #40426

@marcaaron
Copy link
Contributor

Demoting #40442

@marcaaron
Copy link
Contributor

Demoting #40457

@marcaaron
Copy link
Contributor

Demoting #40466

@roryabraham
Copy link
Contributor

Demoting #40472

@blimpich
Copy link
Contributor

Demoting #40486

@marcaaron
Copy link
Contributor

Demoting #40493

@tgolen
Copy link
Contributor

tgolen commented Apr 18, 2024

Demoting #40504

@jasperhuangg
Copy link
Contributor

Demoting #40512

@jasperhuangg
Copy link
Contributor

Demoting #40467

@kbecciv
Copy link

kbecciv commented Apr 18, 2024

TR is 15% left
#30849 - pending validation
#35671 - pending validation
#36314 is failing on Android and IOS app with #40486
#36409 - pending validation on Desktop and IOS app
#37680 - pending validation on Desktop and IOS app
#37909 is failing with #40424
#38023 is failing with #40445
#38709 - pending validation
#38759 - pending validation on IOS app
#38884 - pending validation
#38924 is failing with #40397, except for the iOS app
#38980 - pending validation
#38988 - pending validation
#39007 - pending validation on IOS app
#39042 - pending validation on Desktop
#39144 - pending validation on IOS app
#39219 - pending validation on mWeb and Desktop
#39347 - pending validation
#39374 - pending validation on Desktop
#39398 - pending validation on Desktop
#39475 - pending validation
#39482 - pending validation on Desktop
#39489 is failing with #40459, except for the Web
#39519 - pending validation
#39579 - pending validation on Desktop and IOS app
#39597 - pending validation on mWeb and Android app
#39640 - pending validation on IOS app
#39757 - pending validation on mWeb and IOS app
#39791 - pending validation on Web
#39796 - pending validation on Android app
#39829 - pending validation
#39846 - pending validation
#39906 - pending validation
#39945 - pending validation on mWeb and Android app
#39963 - pending validation on IOS app
#39991 - pending validation on IOS app
#39995 - pending validation on IOS app
#40046 - pending validation
#40065 - pending validation
#40083 - pending validation
#40088 - pending validation on Desktop
#40136 - pending validation on Desktop
#40160 - pending validation
#40174 is failing on Desktop with #38895, repro in Prod, checking off
#40179 is failing with #40454
#40224 - pending validation
#40229 - pending validation
#40333 - pending validation on Desktop

Deploy Blockers:
#40406
#40410
#40411
#40413
#40416
#40424
#40440
#40441
#40452
#40454
#40456
#40459
#40470
#40474
#40485
#40490
#40492
#40498
#40499
#40507
#40509
#40513

@luacmartins
Copy link
Contributor

Demoting #40499

@roryabraham
Copy link
Contributor

Verified #40399 is fixed on staging, checking it off

@roryabraham
Copy link
Contributor

#40517 is behind a beta, checking that off

@roryabraham
Copy link
Contributor

Verified #40401 is fixed on staging, checking it off

@roryabraham
Copy link
Contributor

#40513 is behind a beta, checking it off

@amyevans
Copy link
Contributor

Demoting #40578

@yuwenmemon
Copy link
Contributor

Demoting #40587

@marcaaron
Copy link
Contributor

Checked off #40474 #40470

@blimpich
Copy link
Contributor

Demoting #40586

@marcaaron
Copy link
Contributor

Demoted #40583 as it's minor

@kbecciv
Copy link

kbecciv commented Apr 19, 2024 •
edited
Loading

TR is completed!

#30849 is failing with #40498
#36314 is failing on Android and IOS app with #40486
#36409 is failing with #40509 in Android app
#37909 is failing with #40424
#38023 is failing with #40445
#38709 is failing with #40421 and
#40304 on Web, mWeb and Android; failing with #40421
#40304 and #40265 on IOS app; failing with #40265 on Desktop
#38924 is failing with #40397, except for the iOS app
#39144 is failing with #38864
#39219 is failing with #40513
#39374 is blocked in Desktop, doesn't seem to have the autofill option on it, checking off
#39475 is failing with #40518
#39489 is failing with #40459, except for the Web
#39757 is failing with #40463 and
#40422 on Web and Android app;
#39906 is failing with #39906
#39927 is failing with KI #39834, repro in prod, checking Off
#39963 is failing with #40601 on Android and mWeb, repro in Prod, checking Off
#39995 is failing in IOS with KI #40486
#40174 is failing on Desktop with #38895, repro in Prod, checking off
#40179 is failing with #40454
CP #40471 - pending validation
CP #40522 - pending validation
CP #40563 - pending validation

@marcaaron
Copy link
Contributor

Demoting #40536

This was referenced Apr 20, 2024
Merged
Closed
@mountiny
Copy link
Contributor

@mountiny
Copy link
Contributor

Checking #40542 off, its backend issue

@mountiny
Copy link
Contributor

PRs to CP tomorrow morning cc @Beamanator :

This is a last deploy blocker without proposal #40410 but its coming from SWM PR and I have asked them here to look into it as early as possible

This can be demoted I think #40595

@Beamanator
Copy link
Contributor

Beamanator commented Apr 22, 2024 •
edited
Loading

Quick update:

Last update of mine: all PR fixes are in staging!

@saifelance
Copy link

Demoting #40654

@saifelance
Copy link

Demoting #40640

@saifelance
Copy link

Demoting #40416

@saifelance
Copy link

Demoting #40583

@saifelance
Copy link

Demoting #40632

@mountiny mountiny added the Daily KSv2 label Apr 22, 2024
@mountiny mountiny self-assigned this Apr 22, 2024
@mountiny
Copy link
Contributor

demoted #40679 and #40683

@mountiny
Copy link
Contributor

Chekcing #40410 off, the PR is being CPed and we will verify that

@mountiny
Copy link
Contributor

demoted #40595 cannot be reproduced

@mountiny
Copy link
Contributor

demoted #40680

@mountiny
Copy link
Contributor

Graphs looking good, created issue to investigate one new crash that occurred from reanimated and asked in swm channel.

@kbecciv
Copy link

kbecciv commented Apr 22, 2024 •
edited
Loading

CP #40562 is failing with #40410 in Web, comment left #40562 (comment)

Deploy Blocker:
#40680

@mountiny
Copy link
Contributor

Commented, the issue seems flaky and not major enough to block the deploy

@mountiny
Copy link
Contributor

All is clear so going to kick off the deploy, the android production deploy will not happen

@mountiny
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mountiny mountiny

@applausebot applausebot

Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests