-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] [Taxes] User can access the background list using the arrow keys while the RHP is open #39093
Comments
Triggered auto assignment to @CortneyOfstad ( |
@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Taxes - User can access the background list using the arrow keys while the RHP is open What is the root cause of that problem?The main problem with the issue is that we do not process this case in any way when we're out of focus inside ArrowKeyFocusManager which we use for BaseOptionsSelector and BaseSelectionList App/src/components/ArrowKeyFocusManager.js Lines 79 to 83 in e87d35d
What changes do you think we should make in order to solve the problem?Since we only use this ArrowKeyFocusManager for lists, the best way to fix this is to make changes inside the manager to cover changes for both BaseOptionsSelector and BaseSelectionList To fix this issue we can update ArrowKeyFocusManager and update condition onArrowUpKey and onArrowDownKey when we're out of focus For this, we need to create a wrapper to get isFocused value for ArrowKeyFocusManager
And then update conditions to disable onArrowUpKey and onArrowDownKey when we're out of focus
Plus we might want to reset the index offset state when we leave the screen And if we want, we can always add an additional parameter that will make it possible to interact with lists when we are not in focus (But it doesn't make sense to me) What alternative solutions did you explore? (Optional)As an alternative, we can update onFocusedIndexChanged outside the manager
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Taxes - User can access the background list using the arrow keys while the RHP is open What is the root cause of that problem?We do not disable Arrow keys for What changes do you think we should make in order to solve the problem?
We can add new What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~01008d99761a20e1bb |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani ( |
@jayeshmangwani we have some proposals for review above — thanks! |
Checking if this is VIP-VSP here |
Actually, it's wave-collect so assigning that now 👍 |
Thanks for the proposal @shahinyan11 , your changes will work on the Workspace Taxes page but similar issue is on the Workspaces's Distance rates, Categories , Tags pages too, so rather we would fix it in the SelectionList would be the good idea. @ZhenjaHorbach's Proposal looks good to me, tested locally by applying changes and changes looks good, and @ZhenjaHorbach IMO resetting the index is not needed here when we leave the screen, key down and key up will not work when SectionList's screen is not focused, but keyboard shortcuts will work, adding a video below to checking the effect after applying changes in the proposal Video:key-down.mov🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @pecanoro, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
ProposalUpdated. Simplified changes and and fixed the issue in |
Assigning @ZhenjaHorbach to the issue! |
📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
PR will be ready on the weekend |
PR hit staging earlier today! |
For some reason this did not move to daily or apply payment details, but payment is due to day! |
Payment Summary@jayeshmangwani — paid $500 via Upwork |
@jayeshmangwani can you confirm if this needs a regression test and make the proposal before EOD? Thank you! |
This is not a regression from any PR, but it was missed when we created ArrowKeyFocusManager, and later, the issue was visible after we created RHP. I am proposing regression test steps below. Please let me know if you have any other suggestions Regression Test Steps
Do you agree 👍 or 👎 ? |
|
Sorry about that @jayeshmangwani! I agree to the regression test and getting that created now! |
Regression is here — closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Pressing on the arrow keys on the keyboard should do nothing as there is an RHP open
Actual Result:
Even if RHP is open pressing on the arrow keys moves through the background list
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6428753_1711549325149.bandicam_2024-03-27_17-18-00-957.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @CortneyOfstadIssue Owner
Current Issue Owner: @CortneyOfstadThe text was updated successfully, but these errors were encountered: