User can access the background list using the arrow keys while the RHP is open #39327

ZhenjaHorbach · 2024-03-30T19:00:10Z

Details

User can access the background list using the arrow keys while the RHP is open

Fixed Issues

$ #39093
PROPOSAL: #39093 (comment)

Tests

Go to Paid workspace > Taxes
Open one tax setting
Press on the down and up arrow keys on the keyboard
Go back and go to categories settings
Open one category setting
Press on the down and up arrow keys on the keyboard
Verify that pressing on the arrow keys on the keyboard do nothing as there is an RHP open

Verify that no errors appear in the JS console

Offline tests

Go to Paid workspace > Taxes
Open one tax setting
Press on the down and up arrow keys on the keyboard
Go back and go to categories settings
Open one category setting
Press on the down and up arrow keys on the keyboard
Verify that pressing on the arrow keys on the keyboard do nothing as there is an RHP open

QA Steps

Go to Paid workspace > Taxes
Open one tax setting
Press on the down and up arrow keys on the keyboard
Go back and go to categories settings
Open one category setting
Press on the down and up arrow keys on the keyboard
Verify that pressing on the arrow keys on the keyboard do nothing as there is an RHP open

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-04.at.22.49.39.mov

Android: mWeb Chrome

Screen.Recording.2024-04-04.at.22.49.39.mov

iOS: Native

Screen.Recording.2024-04-04.at.22.54.44.mov

iOS: mWeb Safari

Screen.Recording.2024-04-04.at.22.53.15.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-04.at.22.56.47.mov

MacOS: Desktop

Screen.Recording.2024-04-04.at.22.58.51.mov

… while the RHP is open

melvin-bot · 2024-03-30T19:00:15Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-03-30T19:17:23Z

@jayeshmangwani

Hello )
PR is ready )

Plus a little explanation
I needed to update the tests a little and I noticed that we have incorrect mocks related to useIsFocused
Therefore, in addition to the mock related to my changes, I updated the others (But if necessary, I can delete these changes)

And I also added shouldPreventDefaultFocusOnSelectRow={!DeviceCapabilities.canUseTouchScreen()} in a couple of places

Because there is such a bug

Screen.Recording.2024-03-31.at.01.13.04.mov

I made these changes similar to

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 600 in aeb387f

shouldPreventDefaultFocusOnSelectRow={!DeviceCapabilities.canUseTouchScreen()}

jayeshmangwani · 2024-04-01T18:11:32Z

src/components/ArrowKeyFocusManager.js

+
+BaseArrowKeyFocusManager.propTypes = propTypes;
+BaseArrowKeyFocusManager.defaultProps = defaultProps;
+ArrowKeyFocusManager.displayName = 'ArrowKeyFocusManager';


@ZhenjaHorbach We should create a folder with the name ArrowKeyFocusManager, and under this folder, BaseArrowKeyFocusManager.js and index.js files.

ArrowKeyFocusManager BaseArrowKeyFocusManager.js index.js

I think this doesn’t make sense, since we have a rule that prohibits creating new js files )
And for ts files we have separate tickets )

I was searching for GH issues and wondering if is there any ticket was created to replace ArrowKeyFocusManager with useArrowKeyFocusManager usage For SelectionList

I saw this comment today, and If ArrowKeyFocusManager is going to be removed, then we should not add any logic to the ArrowKeyFocusManager.

In this case, maybe we should remove ArrowKeyFocusManage from the lists?

Then let's move forward with this PR 👍

Or are you afraid that the PR will undo the changes we are doing here?

@pecanoro Yes, I was thinking that once that PR is merged, then SelectionList will no longer use ArrowKeyFocusManager and In current PR, We are adding changes to the ArrowKeyFocusManager Component and these changes will not be in effect, and also ArrowKeyFocusManager usage will be removed entirely soon.

Let's finish reviewing this PR and I will post in the other issue to let them know about the changes here. But at this point I am not sure which one is closer to get merged 😄

In this case, the PR is ready to review )

Then I would say I'll complete the checklist in the next hour 😃

jayeshmangwani · 2024-04-04T20:33:48Z

NAB: @ZhenjaHorbach You have written Not relevant for Android, iOS, mWeb Safari, and mWeb Chrome in the screenshot/video section, but we can test this issue on these devices using the keyboard. Also, mWeb Chrome and Safari videos are wrong

jayeshmangwani · 2024-04-04T20:36:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mWeb-Android.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mWeb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

Code changes LGTM 🚀

ZhenjaHorbach · 2024-04-04T20:40:09Z

NAB: @ZhenjaHorbach You have written Not relevant for Android, iOS, mWeb Safari, and mWeb Chrome in the screenshot/video section, but we can test this issue on these devices using the keyboard. Also, mWeb Chrome and Safari videos are wrong

Since we have quite global changes, it probably makes no difference which RHP screen is open
But okay
I'll update the video now)

jayeshmangwani · 2024-04-04T20:42:31Z

@ZhenjaHorbach There is no need to update videos; I was pointing it out For future reference 😄

ZhenjaHorbach · 2024-04-04T21:02:22Z

@ZhenjaHorbach There is no need to update videos; I was pointing it out For future reference 😄

I updated it just in case)

OSBotify · 2024-04-08T11:09:05Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-08T13:05:43Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:23:20Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix bug with User can access the background list using the arrow keys…

b89c911

… while the RHP is open

ZhenjaHorbach requested a review from a team as a code owner March 30, 2024 19:00

melvin-bot bot requested review from jayeshmangwani and removed request for a team March 30, 2024 19:00

Refactor ArrowKeyFocusManager

b771515

ZhenjaHorbach added 11 commits March 30, 2024 21:39

Update propTypes for ArrowKeyFocusManager

108f04f

Update propTypes for ArrowKeyFocusManager x2

e3f803b

Update perf-tests

9efe712

Update perf-tests x2

9eba416

Update perf-tests x3

defd731

Revert some changes

aeb387f

Revert some changes x2

aa60c7e

Update perf-tests

13affe7

Update perf-tests x2

aae8ff4

Update perf-tests x3

917cf00

Fix bug with blue border

f4f7b19

jayeshmangwani reviewed Apr 1, 2024

View reviewed changes

jayeshmangwani approved these changes Apr 4, 2024

View reviewed changes

melvin-bot bot requested a review from pecanoro April 4, 2024 20:38

Update branch

2f1cede

pecanoro approved these changes Apr 5, 2024

View reviewed changes

pecanoro merged commit 200de35 into Expensify:main Apr 5, 2024
18 checks passed

pecanoro mentioned this pull request Apr 5, 2024

Sync keyboard navigation in SelectionList and PopoverMenu #39201

Merged

50 tasks

github-actions bot mentioned this pull request Apr 8, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807

Closed

This was referenced Apr 12, 2024

Deploy Checklist: New Expensify 2024-04-08 #39807 Derevyaa/Expensify-App#1

Closed

Deploy Checklist: New Expensify 2024-04-09 #39808 Derevyaa/Expensify-App#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User can access the background list using the arrow keys while the RHP is open #39327

User can access the background list using the arrow keys while the RHP is open #39327

ZhenjaHorbach commented Mar 30, 2024 •

edited

Loading

melvin-bot bot commented Mar 30, 2024

ZhenjaHorbach commented Mar 30, 2024 •

edited

Loading

jayeshmangwani Apr 1, 2024

ZhenjaHorbach Apr 1, 2024 •

edited

Loading

jayeshmangwani Apr 1, 2024

jayeshmangwani Apr 1, 2024

ZhenjaHorbach Apr 1, 2024

jayeshmangwani Apr 3, 2024

jayeshmangwani Apr 3, 2024

pecanoro Apr 4, 2024

ZhenjaHorbach Apr 4, 2024

jayeshmangwani Apr 4, 2024

jayeshmangwani commented Apr 4, 2024

jayeshmangwani commented Apr 4, 2024

jayeshmangwani left a comment

ZhenjaHorbach commented Apr 4, 2024

jayeshmangwani commented Apr 4, 2024

ZhenjaHorbach commented Apr 4, 2024

OSBotify commented Apr 8, 2024

OSBotify commented Apr 8, 2024

OSBotify commented Apr 10, 2024

User can access the background list using the arrow keys while the RHP is open #39327

User can access the background list using the arrow keys while the RHP is open #39327

Conversation

ZhenjaHorbach commented Mar 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 30, 2024

ZhenjaHorbach commented Mar 30, 2024 • edited Loading

Choose a reason for hiding this comment

ZhenjaHorbach Apr 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayeshmangwani commented Apr 4, 2024

jayeshmangwani commented Apr 4, 2024

Reviewer Checklist

Screenshots/Videos

jayeshmangwani left a comment

Choose a reason for hiding this comment

ZhenjaHorbach commented Apr 4, 2024

jayeshmangwani commented Apr 4, 2024

ZhenjaHorbach commented Apr 4, 2024

OSBotify commented Apr 8, 2024

OSBotify commented Apr 8, 2024

OSBotify commented Apr 10, 2024

ZhenjaHorbach commented Mar 30, 2024 •

edited

Loading

ZhenjaHorbach commented Mar 30, 2024 •

edited

Loading

ZhenjaHorbach Apr 1, 2024 •

edited

Loading