[CP Staging] Fix crash for unknown action type when getting quick action title #39149

parasharrajat · 2024-03-28T06:17:19Z

cc: @Gonals @thienlnam

Details

App crashes due to '' being passed to translate function while determining the quick action title.

Fixed Issues

Slack =$ https://expensify.slack.com/archives/C049HHMV9SM/p1711579838530089
PROPOSAL:

Tests

On a new account, create a tracked expense.
Log out, and log back in
Notice that the app does not crash.

Verify that no errors appear in the JS console

Offline tests

On a new account, create a tracked expense.
Log out, and log back in
Notice that the app does not crash.

QA Steps

On a new account, create a tracked expense.
Log out, and log back in
Notice that the app does not crash.

Note: Clicking on Track Expense Shortcut does nothing for now.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-29.at.3.44.22.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-03-29.at.3.45.44.PM.mov

iOS: Native

Screen.Recording.2024-03-29.at.3.48.02.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-29.at.3.43.26.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-29.at.3.22.09.PM.mov

MacOS: Desktop

Screen.Recording.2024-03-29.at.3.24.35.PM.mov

parasharrajat · 2024-03-28T06:23:10Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

@@ -154,6 +154,11 @@ function FloatingActionButtonAndPopover(props) {
        return [];
    }, [props.personalDetails, props.session.accountID, quickActionReport]);

+    const quickActionTitle = useMemo(() => {
+        const titleKey = getQuickActionTitle(props.quickAction.action);
+        return titleKey ? translate(titleKey) : '';


Now the title will be empty for unknown actions so should we return something instead of ''.

Actually the crash only occurs in dev enviornment

App/src/libs/Localize/index.ts

Lines 161 to 169 in f5cf3fb

if (Config.IS_IN_PRODUCTION || Config.IS_IN_STAGING) {

const phraseString: string = Array.isArray(phraseKey) ? phraseKey.join('.') : phraseKey;

Log.alert(`${phraseString} was not found in the en locale`);

if (userEmail.includes(CONST.EMAIL.EXPENSIFY_EMAIL_DOMAIN)) {

return CONST.MISSING_TRANSLATION;

}

return phraseString;

}

throw new Error(`${phraseKey} was not found in the default language`);

so i beleive we should not suppress it as this may result in unnoticed missing title, which otherwise will be caught if theres a crash

We are not suppressing localization errors but correcting the logic for title so that only when there is a title we translate it. I also added new keys for action.

actually what i meant is if app is crashed when title key is not found in translation that should be the ideal behviour in dev enviornment (opinion), that will help us quickly spot the error in dev enviornment for future newly added actions, otherwise this can be missed.

lets leave it like this, my comment ^ is optional btw

parasharrajat · 2024-03-28T06:23:53Z

src/languages/es.ts

+        trackManual: 'Track Manual',
+        trackScan: 'Track Scan',
+        trackDistance: 'Track Distance',


@Gonals can you please confirm the new actions and their translations?

melvin-bot · 2024-03-28T13:50:01Z

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2024-03-28T15:26:48Z

@Gonals What do you think should be done?

ishpaul777 · 2024-03-28T15:28:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-03-30-00-02-47.mp4

Android: mWeb Chrome

Record_2024-03-29-23-56-29.mp4

iOS: Native

Screen.Recording.2024-03-30.at.12.04.40.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-03-29.at.11.47.13.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-29.at.6.47.58.PM.mov

MacOS: Desktop

Screen.Recording.2024-03-30.at.12.08.44.AM-1.mov

parasharrajat · 2024-03-28T15:38:28Z

We need translations and I will attach the screenshots. I am even not sure if these texts are correct for shortcut.

        trackManual: 'Track Manual',
        trackScan: 'Track Scan',
        trackDistance: 'Track Distance',

ishpaul777 · 2024-03-28T15:40:24Z

We need translations and I will attach the screenshots. I am even not sure if these texts are correct for shortcut.

can we bring this to slack for faster resolution

…ickactioncrash

parasharrajat · 2024-03-29T10:20:28Z

PR is ready for review. I confirmed the titles via design doc and added translations.

ishpaul777 · 2024-03-29T13:20:27Z

HII @parasharrajat what about the icon for track expense shortcut should we also update it?

parasharrajat · 2024-03-29T18:14:42Z

This is out of scope of this PR. There are follow-up PRs which will handle more cases. Main purpose of this PR was to fix the crash. I just added more actions so that title is shown on the shortcut. These shortcuts are yet to be implemented.

ishpaul777 · 2024-03-29T18:16:20Z

okay i'll complete videos

ishpaul777

Looks good! :)

melvin-bot · 2024-03-29T18:42:28Z

🎯 @ishpaul777, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #39281.

ishpaul777 · 2024-03-29T18:44:05Z

Lets also add that the clicking on track Expense shortcut will do nothing, in the QA steps

thienlnam

Awesome, thanks for this PR!

melvin-bot · 2024-03-29T18:54:11Z

@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

thienlnam · 2024-03-29T18:54:34Z

Tests were passing

OSBotify · 2024-03-29T19:00:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ncrash [CP Staging] Fix crash for unknown action type when getting quick action title (cherry picked from commit 905e689)

OSBotify · 2024-03-29T20:40:21Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.58-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-04-02T11:05:30Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ikevin127 · 2024-04-21T23:52:48Z

Regarding PR author checklist item:

Verify that no errors appear in the JS console

Coming from this Slack 🧵 in which the OP reported:

Warning

Encountered two children with the same key Submit expense.

From taking a quick look at the code, looks like this is coming from the fact that we use the item.text as key in PopoverMenu > FocusableMenuItem (reference) and there is the case when the Quick action menu item can be the same as the action menu item that was just performed via the Fab popover menu -> therefore the Fab popover will render two menu items with the same key.

Steps:

Open app on iOS / Android - Native and press on Fab.
(Optional) If the warning does not show up this is because your Quick action is not Submit expense, which you can change by submitting a manual request (Fab > Submit expense) after which the Quick action will be updated to Submit expense.

Note

The same happens for the other possible actions:

Track expense
Pay someone
Assign task

cc @thienlnam @ishpaul777

parasharrajat added 2 commits March 28, 2024 11:38

Fix crash for unknown action type when getting quick action

57477ef

Add more actions

2e5c1a6

parasharrajat commented Mar 28, 2024

View reviewed changes

parasharrajat changed the title ~~Fix crash for unknown action type when getting quick action title~~ [CP Staging] Fix crash for unknown action type when getting quick action title Mar 28, 2024

thienlnam requested a review from ishpaul777 March 28, 2024 09:59

parasharrajat marked this pull request as ready for review March 28, 2024 13:49

parasharrajat requested a review from a team as a code owner March 28, 2024 13:49

melvin-bot bot removed the request for review from a team March 28, 2024 13:50

parasharrajat added 3 commits March 29, 2024 14:40

Update translations

1fc252b

Merge branch 'main' of github.com:Expensify/App into parasharrajat/qu…

1deb99a

…ickactioncrash

QuickAction is optional prop

e43acd0

ishpaul777 approved these changes Mar 29, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Mar 29, 2024

[PAY 04/09] Payment issue for E/App PR#39149 #39281

Closed

thienlnam approved these changes Mar 29, 2024

View reviewed changes

thienlnam merged commit 905e689 into Expensify:main Mar 29, 2024
18 checks passed

melvin-bot bot added the Emergency label Mar 29, 2024

thienlnam removed the Emergency label Mar 29, 2024

OSBotify pushed a commit that referenced this pull request Mar 29, 2024

Merge pull request #39149 from parasharrajat/parasharrajat/quickactio…

10595ce

…ncrash [CP Staging] Fix crash for unknown action type when getting quick action title (cherry picked from commit 905e689)

github-actions bot mentioned this pull request Mar 29, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

ZhenjaHorbach mentioned this pull request Apr 8, 2024

Android/iOS - Shortcut - Tapping shortcut track manual does not trigger any action #39863

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix crash for unknown action type when getting quick action title #39149

[CP Staging] Fix crash for unknown action type when getting quick action title #39149

parasharrajat commented Mar 28, 2024 •

edited

Loading

parasharrajat Mar 28, 2024

ishpaul777 Mar 28, 2024

parasharrajat Mar 28, 2024

ishpaul777 Mar 28, 2024 •

edited

Loading

ishpaul777 Mar 28, 2024

parasharrajat Mar 28, 2024

melvin-bot bot commented Mar 28, 2024

parasharrajat commented Mar 28, 2024

ishpaul777 commented Mar 28, 2024 •

edited

Loading

parasharrajat commented Mar 28, 2024 •

edited

Loading

ishpaul777 commented Mar 28, 2024 •

edited

Loading

parasharrajat commented Mar 29, 2024

ishpaul777 commented Mar 29, 2024

parasharrajat commented Mar 29, 2024

ishpaul777 commented Mar 29, 2024

ishpaul777 left a comment

melvin-bot bot commented Mar 29, 2024

ishpaul777 commented Mar 29, 2024

thienlnam left a comment

melvin-bot bot commented Mar 29, 2024

thienlnam commented Mar 29, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

ikevin127 commented Apr 21, 2024 •

edited

Loading

	if (Config.IS_IN_PRODUCTION \|\| Config.IS_IN_STAGING) {
	const phraseString: string = Array.isArray(phraseKey) ? phraseKey.join('.') : phraseKey;
	Log.alert(`${phraseString} was not found in the en locale`);
	if (userEmail.includes(CONST.EMAIL.EXPENSIFY_EMAIL_DOMAIN)) {
	return CONST.MISSING_TRANSLATION;
	}
	return phraseString;
	}
	throw new Error(`${phraseKey} was not found in the default language`);

[CP Staging] Fix crash for unknown action type when getting quick action title #39149

[CP Staging] Fix crash for unknown action type when getting quick action title #39149

Conversation

parasharrajat commented Mar 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

parasharrajat Mar 28, 2024

Choose a reason for hiding this comment

ishpaul777 Mar 28, 2024

Choose a reason for hiding this comment

parasharrajat Mar 28, 2024

Choose a reason for hiding this comment

ishpaul777 Mar 28, 2024 • edited Loading

Choose a reason for hiding this comment

ishpaul777 Mar 28, 2024

Choose a reason for hiding this comment

parasharrajat Mar 28, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Mar 28, 2024

parasharrajat commented Mar 28, 2024

ishpaul777 commented Mar 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

parasharrajat commented Mar 28, 2024 • edited Loading

ishpaul777 commented Mar 28, 2024 • edited Loading

parasharrajat commented Mar 29, 2024

ishpaul777 commented Mar 29, 2024

parasharrajat commented Mar 29, 2024

ishpaul777 commented Mar 29, 2024

ishpaul777 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 29, 2024

ishpaul777 commented Mar 29, 2024

thienlnam left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 29, 2024

thienlnam commented Mar 29, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

ikevin127 commented Apr 21, 2024 • edited Loading

parasharrajat commented Mar 28, 2024 •

edited

Loading

ishpaul777 Mar 28, 2024 •

edited

Loading

ishpaul777 commented Mar 28, 2024 •

edited

Loading

parasharrajat commented Mar 28, 2024 •

edited

Loading

ishpaul777 commented Mar 28, 2024 •

edited

Loading

ikevin127 commented Apr 21, 2024 •

edited

Loading