Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-06] [QBO] Navigate to the Accounting page when the accounting feature is enabled #39214

Closed
hayata-suenaga opened this issue Mar 28, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Mar 28, 2024

When the accounting feature is enabled, navigate to the Accounting screen inside the enablePolicyConnections action function.

We're waiting for the PR to the accounting page to be merged.

Issue OwnerCurrent Issue Owner: @johncschuster
@hayata-suenaga hayata-suenaga added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Mar 28, 2024
@hayata-suenaga hayata-suenaga self-assigned this Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01614792b0d1d6a81b

Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @paultsimura (Internal)

Copy link

melvin-bot bot commented Mar 28, 2024

@melvin-bot melvin-bot bot added the Weekly KSv2 label Mar 28, 2024
@hayata-suenaga hayata-suenaga moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 28, 2024
@melvin-bot melvin-bot bot removed the Daily KSv2 label Mar 28, 2024
@hayata-suenaga hayata-suenaga changed the title Navigate to the Accounting page when the accounting feature is enabled [HOLD App PRs #38283 #38900] Navigate to the Accounting page when the accounting feature is enabled Mar 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@johncschuster
Copy link
Contributor

@hayata-suenaga do you need anything from me on this at the moment?

@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
@hayata-suenaga hayata-suenaga changed the title [HOLD App PRs #38283 #38900] Navigate to the Accounting page when the accounting feature is enabled [HOLD App PRs] Navigate to the Accounting page when the accounting feature is enabled Apr 10, 2024
@hayata-suenaga
Copy link
Contributor Author

The PRs that were holding this issue were merged. I'll work on this when I have time

@melvin-bot melvin-bot bot added the Overdue label Apr 19, 2024
@johncschuster
Copy link
Contributor

Bumping to keep Melvin at bay 👍

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2024
@hayata-suenaga hayata-suenaga changed the title [HOLD App PRs] Navigate to the Accounting page when the accounting feature is enabled [QBO] Navigate to the Accounting page when the accounting feature is enabled Apr 29, 2024
@trjExpensify
Copy link
Contributor

Can this not be external like the other pages in the workspace settings? CC: @allroundexperts who worked on a lot of this stuff. :)

@trjExpensify trjExpensify moved this from Release 1: Spring 2024 (May) to Polish in [#whatsnext] #wave-collect Apr 30, 2024
@allroundexperts
Copy link
Contributor

Yep. This can be external.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 1, 2024
@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented May 1, 2024

because this change is simple, I just opened a PR here bumped @allroundexperts for review

@hayata-suenaga
Copy link
Contributor Author

This issue will be fixed in the PR linked above ⬆️

This PR doesn't need payment as the payment will be handled in a different issue.

I'm closing this issue for now.

@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect May 13, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 30, 2024
@melvin-bot melvin-bot bot changed the title [QBO] Navigate to the Accounting page when the accounting feature is enabled [HOLD for payment 2024-06-06] [QBO] Navigate to the Accounting page when the accounting feature is enabled May 30, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented May 30, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants