fix: re-add finetunings #42026

allroundexperts · 2024-05-12T16:26:39Z

Details

This PR fine tunes the highlighted menu item animation durations. The original PR got reverted here due to #41142.

Fixed Issues

$ #39841
$ #39214
PROPOSAL: N/A

Tests

Create a new workspace
Go to the workspace settings
Enable a feature.

Verify that the design requirements mentioned here are satisfied.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Create a new workspace
Go to the workspace settings
Enable a feature.

Verify that the design requirements mentioned here are satisfied.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-17.at.11.32.42.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-04-17.at.11.13.25.PM.mov

iOS: Native

Screen.Recording.2024-04-17.at.11.12.35.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-17.at.11.07.40.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.11.05.02.PM.mov

MacOS: Desktop

Screen.Recording.2024-04-17.at.11.06.23.PM.mov

melvin-bot · 2024-05-12T20:17:14Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-05-12T20:18:52Z

@sobitneupane will review this.

mountiny · 2024-05-13T10:15:04Z

@sobitneupane can you please follow up with the review here? thanks

hayata-suenaga · 2024-05-13T22:41:36Z

@allroundexperts, can you do the same for enablePolicyConnections, too? I'm closing my PR, then.

sobitneupane · 2024-05-14T09:01:52Z

src/components/ScreenWrapper.tsx

+            setDidScreenTransitionEnd(true);
+            onEntryTransitionEnd?.();
+        }, CONST.SCREEN_TRANSITION_END_TIMEOUT);
+


@allroundexperts I'm wondering if there's a way to avoid using setTimeout. In which cases transitionEnd event doesn't trigger? Is this a known issue? Perhaps we could troubleshoot and resolve it first so that we don't have to rely on the setTimeout workaround.

cc: @mountiny

As mentioned here, this is a bug in react-native-navigation. For iOS, it doesn't seem to call the transition end handler.

I also wonder if there is any good way to avoid using setTimeout 🤔

I think using setTimeout here isn't a bad practice. It's more of a safe exit.

I think my worry is that we're changing the value of didScreenTransitionEnd using setTimeout.

Right, so it is a known bug on iOS that sometimes didScreenTransitionEnd never gets set to true even though the transition is actually finished. Setting a setTimeout ensures that we handle such cases. Does that make sense @hayata-suenaga? Do you have any alternative that I should explore?

I agree with you, @allroundexperts 😄. However, as we aim to avoid setTimeout as much as possible, I've asked in Slack if there are any other alternatives that don't involve using setTimeout. This is just to get a broader perspective before we decide to proceed with setTimeout.

mountiny

Seems like there was no good alternative shared to this use of setTimeout, while we trying to avoid it, it seems fine in this case

@sobitneupane can you please complete the checklist?

hayata-suenaga

🟢 Thank you Vit for confirming that 😄

Thank you @allroundexperts for the PR 🙇

sobitneupane

If any feature is toggled on, and you toggle it off and on again quickly, it takes a few seconds for the feature to appear in the LHN. I don't think this issue is directly related to the changes introduced by this PR, but it is worth addressing.

Screen.Recording.2024-05-21.at.13.22.28.mov

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-21.at.13.36.10.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-05-21.at.13.30.40.mov

iOS: mWeb Safari

Screen.Recording.2024-05-21.at.13.27.34.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-21.at.13.10.31.mov

MacOS: Desktop

Screen.Recording.2024-05-21.at.13.32.13.mov

hayata-suenaga · 2024-05-22T17:22:12Z

If any feature is toggled on, and you toggle it off and on again quickly, it takes a few seconds for the feature to appear in the LHN. I don't think this issue is directly related to the changes introduced by this PR, but it is worth addressing.

I think it might be from the slowness of the backend API that we're experiencing currently. But I want to make sure that this is the case. @sobitneupane, could you investigate this a little bit more and check the network tab that this is actually from the backend.

Because we have the optimistic update, I actually wonder if this is from the backend issue.

sobitneupane · 2024-05-24T07:47:43Z

I think it might be from the slowness of the backend API that we're experiencing currently. But I want to make sure that this is the case. @sobitneupane, could you investigate this a little bit more and check the network tab that this is actually from the backend.

@hayata-suenaga The issue I mentioned is not reproducible when the user is offline.

When I toggle the switch multiple times, it waits for all the API requests to complete before making any changes. That might be the reason for the delay.

Screen.Recording.2024-05-24.at.13.19.44.mov

mountiny · 2024-05-24T13:58:26Z

I think we need to make sure a normal/ single toggling works well as that is what 99% of users will do

hayata-suenaga · 2024-05-24T18:13:46Z

@sobitneupane do yo have an idea what we have to do here to fix the issue?

sobitneupane · 2024-05-27T07:53:39Z

I think we need to make sure a normal/ single toggling works well as that is what 99% of users will do

Yup. Normal/single Toggling is working fine.

do yo have an idea what we have to do here to fix the issue?

@hayata-suenaga I am not sure. I might have to spend some time digging it down.

But for now I think we are good to merge this PR.

mountiny · 2024-05-27T14:33:29Z

Yeah I think we are good to merge this PR

OSBotify · 2024-05-27T17:10:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:42:42Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:25:31Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:37:29Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts added 3 commits May 12, 2024 21:25

fix: re-add finetunings

41c105d

fix: add timeout

b72a7ac

fix: add timeout

ad79bcc

allroundexperts marked this pull request as ready for review May 12, 2024 20:17

allroundexperts requested a review from a team as a code owner May 12, 2024 20:17

melvin-bot bot removed the request for review from a team May 12, 2024 20:17

melvin-bot bot requested a review from hoangzinh May 12, 2024 20:17

revert podfile changes

74e8fc2

allroundexperts mentioned this pull request May 12, 2024

[HOLD for payment 2024-06-06] [HOLD for payment 2024-05-06] Web - Features - Feature row in left side bar appears with delay after the page opens on the right #39841

Closed

6 tasks

allroundexperts mentioned this pull request May 12, 2024

Navigate to accounting page #41428

Closed

48 tasks

mountiny requested review from sobitneupane and removed request for hoangzinh May 13, 2024 10:14

mountiny assigned allroundexperts May 13, 2024

sobitneupane reviewed May 14, 2024

View reviewed changes

mountiny approved these changes May 20, 2024

View reviewed changes

hayata-suenaga approved these changes May 20, 2024

View reviewed changes

hayata-suenaga changed the title ~~fix: re-add finetunings~~ [HOLD Merge Freeze] fix: re-add finetunings May 20, 2024

sobitneupane reviewed May 21, 2024

View reviewed changes

sobitneupane approved these changes May 21, 2024

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga May 21, 2024 07:56

mountiny changed the title ~~[HOLD Merge Freeze] fix: re-add finetunings~~ fix: re-add finetunings May 27, 2024

hayata-suenaga approved these changes May 27, 2024

View reviewed changes

puneetlath merged commit 7df4fd5 into Expensify:main May 27, 2024
21 of 31 checks passed

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

lanitochka17 mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Workspace features-User not returned to WS settings after enabling Accounting in more features #42789

Closed

6 tasks

melvin-bot bot mentioned this pull request May 30, 2024

[HOLD for payment 2024-06-06] [QBO] Navigate to the Accounting page when the accounting feature is enabled #39214

Closed

bernhardoj mentioned this pull request Jun 12, 2024

[HOLD for payment 2024-07-10] [$250] Web - Workspace - Member is unselected when refresh Add message page and go back #42533

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: re-add finetunings #42026

fix: re-add finetunings #42026

allroundexperts commented May 12, 2024 •

edited by mountiny

Loading

melvin-bot bot commented May 12, 2024

allroundexperts commented May 12, 2024

mountiny commented May 13, 2024

hayata-suenaga commented May 13, 2024 •

edited

Loading

sobitneupane May 14, 2024 •

edited

Loading

allroundexperts May 14, 2024

hayata-suenaga May 14, 2024

allroundexperts May 14, 2024

hayata-suenaga May 14, 2024

allroundexperts May 16, 2024

hayata-suenaga May 17, 2024 •

edited

Loading

mountiny left a comment

hayata-suenaga left a comment

sobitneupane left a comment

sobitneupane left a comment

hayata-suenaga commented May 22, 2024

sobitneupane commented May 24, 2024

mountiny commented May 24, 2024

hayata-suenaga commented May 24, 2024

sobitneupane commented May 27, 2024

mountiny commented May 27, 2024

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

fix: re-add finetunings #42026

fix: re-add finetunings #42026

Conversation

allroundexperts commented May 12, 2024 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 12, 2024

allroundexperts commented May 12, 2024

mountiny commented May 13, 2024

hayata-suenaga commented May 13, 2024 • edited Loading

sobitneupane May 14, 2024 • edited Loading

Choose a reason for hiding this comment

allroundexperts May 14, 2024

Choose a reason for hiding this comment

hayata-suenaga May 14, 2024

Choose a reason for hiding this comment

allroundexperts May 14, 2024

Choose a reason for hiding this comment

hayata-suenaga May 14, 2024

Choose a reason for hiding this comment

allroundexperts May 16, 2024

Choose a reason for hiding this comment

hayata-suenaga May 17, 2024 • edited Loading

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

hayata-suenaga left a comment

Choose a reason for hiding this comment

sobitneupane left a comment

Choose a reason for hiding this comment

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

hayata-suenaga commented May 22, 2024

sobitneupane commented May 24, 2024

mountiny commented May 24, 2024

hayata-suenaga commented May 24, 2024

sobitneupane commented May 27, 2024

mountiny commented May 27, 2024

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

allroundexperts commented May 12, 2024 •

edited by mountiny

Loading

hayata-suenaga commented May 13, 2024 •

edited

Loading

sobitneupane May 14, 2024 •

edited

Loading

hayata-suenaga May 17, 2024 •

edited

Loading