[$500] openApp and reconnectApp consistently failing every time sign into the app with error

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712076134934759

Action Performed:

1. Sign in to app

Expected Result:

Should be no error

Actual Result:

openApp and reconnectApp shows error

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01db64f0c98a4baf4f
• Upwork Job ID: 1775338512686096384
• Last Price Increase: 2024-04-03

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[nathanmetcalf]

Had a quick look at this with Jason 1:1. I can't manage to reproduce this on my account. Those API calls (openApp and reconnectApp) do not error on my account. And I'm not comfortable supportaling into another staff members account to check if they error there.

I think this needs someone from engineering to triage and diagnose further.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01db64f0c98a4baf4f

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @dukenv0307 (Internal)

[jliexpensify]

@dukenv0307 (since you're assigned) just curious: are you able to repro this?

[dukenv0307]

@jliexpensify There's no error on my side. Here's the evidence

web-resize.mp4

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

@dukenv0307 we're going to move forward with attempting to diagnose and fix this issue. Hoping a Contributor can repro and has a solution!

[iwiznia]

Almost sure that this is internal, since the error is in the API command

[melvin-bot]

Current assignee @dukenv0307 is eligible for the Internal assigner, not assigning anyone new.

[jliexpensify]

Thanks @iwiznia!

[iwiznia]

@puneetlath can you check if you get the same error in ReconnectApp but not on the call right after loading the app like the one above, instead, disconnect from wifi and recconect to it and check the response there?
If it works (I assume it will) then the only problem is in OpenApp (which is called by ReconnectApp when we have no updateID, see https://expensify.slack.com/archives/C06SCNUBB28/p1712181414857909)

[puneetlath]

It seems you are right @iwiznia

[jliexpensify]

So if I'm understanding correctly, it seems like this issue will be resolved with Ioni's PR right?

[iwiznia]

Just the reconnect part

[puneetlath]

Yeah, so we still need to fix the OpenApp issue that I'm experiencing.

[melvin-bot]

@jliexpensify @dukenv0307 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[puneetlath]

I'll take on looking into this. Since I'm the main person affected.

[melvin-bot]

@puneetlath, @jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[pecanoro]

I am facing this, logs here. Could it be related to mostRecentReportActionLastModified being malformed?

[pecanoro]

@marcaaron Any ideas why we are generating the oldest like this? It's not a valid format for the back-end.

Malformed REQUEST: 'mostRecentReportActionLastModified' = '1970-01-01T00:00:00.000Z', ignoring (should match '\d{4}-\d{2}-\d{2}( \d{2}:\d{2}:\d{2}(\.\d{3})?)?').

[pecanoro]

@puneetlath Btw, it seems to be failing here, not sure if related to the problem with the previous comment I left: https://github.com/Expensify/Auth/blob/ac50b8189120a2efa9d51b1c3bc2dfb2ebc627a7/auth/command/Get.cpp#L715

[marcaaron]

hmm, it should be a number timestamp not ISO 👀 maybe that is wrong... let me look before I speak ahah

[marcaaron]

Ok - I think it's the T and the Z - both are valid ISO timestamps, but our regex doesn't allow it:

Not too sure why it changed - but probably related to a date library or some other code... I'll keep looking for the answer to that.

FWIW - at least for the "reconnect when you are missing Onyx updates" case this param does not matter. And I disabled it in this PR. What other case do we call ReconnectApp at this point?

[marcaaron]

Not too sure why it changed - but probably related to a date library or some other code... I'll keep looking for the answer to that

actually, looks like it has just been broken forever - but would be pretty unusual to have 0 report actions 🤔

[puneetlath]

Oh interesting. I think that's different than my issue. Mine seems to be failing with a Report no longer exists error.

Logs here.

[pecanoro]

Oh interesting. I think that's different than my issue. Mine seems to be failing with a Report no longer exists error.

Yeah, for me too, I linked that here, that's why I mentioned they could 2 different problems that needed to be fixed

[puneetlath]

Ah got it! Looks like you're right. Here's an example stacktrace:

8803d1317888aab2-SJC | virt1.rno | 2024-05-07 20:04:39 963 | [email protected] | [trace] 6/6. file '/git/releases/expensify.com/624c6bf/api.php' function 'openApp' line '3625'
-- | -- | -- | -- | --
8803d1317888aab2-SJC | virt1.rno | 2024-05-07 20:04:39 963 | [email protected] | [trace] 5/6. file '/git/releases/expensify.com/624c6bf/lib/AppInit.php' function 'reconnectApp' line '396'
8803d1317888aab2-SJC | virt1.rno | 2024-05-07 20:04:39 963 | [email protected] | [trace] 4/6. file '/git/releases/expensify.com/624c6bf/lib/AppInit.php' function 'getFullDataForReconnect' line '347'
8803d1317888aab2-SJC | virt1.rno | 2024-05-07 20:04:39 963 | [email protected] | [trace] 3/6. file '/git/releases/expensify.com/624c6bf/lib/AppInit.php' function 'structureTransactionsForOnyx' line '254'
8803d1317888aab2-SJC | virt1.rno | 2024-05-07 20:04:39 963 | [email protected] | [trace] 2/6. file '/git/releases/expensify.com/624c6bf/lib/TransactionUtils.php' function 'getByID' line '776'
8803d1317888aab2-SJC | virt1.rno | 2024-05-07 20:04:39 963 | [email protected] | [trace] 1/6. file '/git/releases/expensify.com/624c6bf/lib/ReportStore.php' function 'getByIDs' line '129'
8803d1317888aab2-SJC | virt1.rno | 2024-05-07 20:04:39 963 | [email protected] | [trace] 0/6. file '/git/releases/expensify.com/624c6bf/lib/ReportStore.php' function 'load' line '68'

I raised a PR to catch/log this error here: https://github.com/Expensify/Web-Expensify/pull/41964

[puneetlath]

This has been CP'd and confirmed to have fixed my issue on prod.

Going to close out, but @pecanoro wanted to confirm that your issue is also fixed?