[HOLD for payment 2024-05-02] [$250] Missing translation appears under "Notify me about new messages".

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712255475405659

Action Performed:

1. Open app
2. Go to public room https://staging.new.expensify.com/a/3037571
3. Click on any public user name

Expected Result:

Some notification preference should appear under "Notify me about new messages"

Actual Result:

missing translation appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01631dee60788c6c7d
• Upwork Job ID: 1777700680984256512
• Last Price Increase: 2024-04-16
• Automatic offers:
• ishpaul777 | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

MISSING TRANSLATION for notify me about new message setting.

What is the root cause of that problem?

When we open a profile page of user without prior chat, notificationPreference will be undefined. Because undefined !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN, the notification preference setting is shown with no translation found. MISSING TRANSLATION is only shown in prod or staging.

App/src/pages/ProfilePage.tsx

Lines 122 to 125 in 9220010

	const shouldShowNotificationPreference = !isEmptyObject(report) && !isCurrentUser && report.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;
	const notificationPreference = shouldShowNotificationPreference
	? translate(`notificationPreferencesPage.notificationPreferences.${report.notificationPreference}` as TranslationPaths)
	: '';

We already have a condition to check whether the report object is empty or not. When we open the profile page without prior chat, it will get the report object with report ID of 0.

App/src/pages/ProfilePage.tsx

Lines 279 to 288 in 9220010

	report: {
	key: ({route, session, reports}) => {
	const accountID = Number(route.params?.accountID ?? 0);
	const reportID = ReportUtils.getChatByParticipants([accountID], reports)?.reportID ?? '';
	if ((Boolean(session) && Number(session?.accountID) === accountID) || SessionActions.isAnonymousUser() || !reportID) {
	return `${ONYXKEYS.COLLECTION.REPORT}0`;
	}
	return `${ONYXKEYS.COLLECTION.REPORT}${reportID}`;
	},

In a normal case, it would return an empty object. But if you ever do an OpenReport request with a reportID of 0, then the report will contain error data telling that the report doesn't exist. One way to do OpenReport with a reportID of 0 is by clicking the unexpected money request skeleton preview. (this is a temporary issue)

What changes do you think we should make in order to solve the problem?

We can use ReportUtils.isValidReportIDFromPath that will ignore reportID of 0 in Report.openReport, but I think we should ultimately check whether notificationPreference is undefined or not to show the notification preference setting.

const shouldShowNotificationPreference = !isEmptyObject(report) && !isCurrentUser && !!report.notificationPreference && report.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;

[melvin-bot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01631dee60788c6c7d

[sonialiap]

Moving to External

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[sonialiap]

@ishpaul777 what do you think of the above proposal?

[ishpaul777]

reviewing in few hours 🙇

[ishpaul777]

I am not able to reproduce the issue, it seems the report here is null which dont show the notification preference option at all, @bernhardoj Can you please help me with steps to repro if it is still reproducable for you

Screen.Recording.2024-04-15.at.12.15.46.AM.mov

[bernhardoj]

I explained that here you need a way to request an OpenReport with a reportID of 0 and one of the way is to click the skeleton money request preview but I don't know exactly how to always reproduce the skeleton issue,

so the other way (and easy) is:

1. Open https://staging.new.expensify.com/r/0/transaction/123/receipt (0 is the reportID)
2. Open the profile page https://staging.new.expensify.com/a/3037571

It will now crash btw.

Also, we should check for reportID before showing the private notes.

App/src/pages/ProfilePage.tsx

Lines 239 to 241 in db9e01c

	{!isEmptyObject(report) && !isCurrentUser && (
	<MenuItem
	title={`${translate('privateNotes.title')}`}

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@sonialiap, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ishpaul777]

we should ultimately check whether notificationPreference is undefined or not to show the notification preference setting.
Also, we should check for reportID before showing the private notes.

Agree 💯

Proposal from @bernhardoj looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@sonialiap @bernhardoj @aldo-expensify @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bernhardoj]

PR is ready

cc: @ishpaul777

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix missing translation shown in notification preference #40623

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @ishpaul777 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sonialiap]

@bernhardoj $250 - paid ✔️
@ishpaul777 $250 - paid ✔️

[sonialiap]

@ishpaul777 please complete the checklist

[ishpaul777]

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: [TS migration] Migrate 'Profile' page to TypeScript #34974
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/34974/files#r1591092643
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
• [@ishpaul777] Determine if we should create a regression test for this bug. - No this was a minor issue with not so straightforward repro steps not worth a regression test
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.- n/a