-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing translation shown in notification preference #40623
Fix missing translation shown in notification preference #40623
Conversation
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeWhatsApp.Video.2024-04-24.at.12.06.11.AM.mp4Android: mWeb ChromeWhatsApp.Video.2024-04-24.at.12.06.11.AM.mp4iOS: NativeScreen.Recording.2024-04-23.at.11.54.18.PM.moviOS: mWeb SafariScreen.Recording.2024-04-23.at.11.52.04.PM.movMacOS: Chrome / SafariScreen.Recording.2024-04-23.at.11.51.40.PM.movMacOS: DesktopScreen.Recording.2024-04-24.at.12.00.33.AM.mov |
@bernhardoj Can you please merge main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Merging main locally tests well,
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.65-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
Details
The missing translation shows because the value is undefined.
Fixed Issues
$ #39677
PROPOSAL: #39677 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
staging.new.expensify.com/r/0/transaction/123/receipt
at least once.staging.new.expensify.com/a/3037571
.Notify me about new messages
andPrivate notes
menu isn't shownPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-04-20.at.13.48.16.mov
Android: mWeb Chrome
Screen.Recording.2024-04-20.at.13.43.06.mov
iOS: Native
Screen.Recording.2024-04-20.at.13.41.26.mov
iOS: mWeb Safari
Screen.Recording.2024-04-20.at.13.40.45.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-20.at.13.33.45.mov
MacOS: Desktop
Screen.Recording.2024-04-20.at.13.36.26.mov