Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20] [HOLD][Search v1] Update BottomTabBar #39886

Closed
luacmartins opened this issue Apr 9, 2024 · 20 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@luacmartins
Copy link
Contributor

Section from design doc

@luacmartins luacmartins added the Daily KSv2 label Apr 9, 2024
@luacmartins luacmartins self-assigned this Apr 9, 2024
@luacmartins luacmartins changed the title [Search v1] Update BottomTabBar [HOLD][Search v1] Update BottomTabBar Apr 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Apr 14, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2024
@grgia
Copy link
Contributor

grgia commented Apr 16, 2024

image

@Expensify/design could I get this new icon asset please?

@grgia grgia self-assigned this Apr 16, 2024
@grgia
Copy link
Contributor

grgia commented Apr 16, 2024

@grgia
Copy link
Contributor

grgia commented Apr 16, 2024

Went ahead and opened this one

@dannymcclain
Copy link
Contributor

We're finalizing the icons for Inbox and Search. I will get them uploaded as soon as possible though!

@dannymcclain
Copy link
Contributor

Ok I think we got it. Here are the updated icons for both Inbox and Search:

And here are some mocks showing them in context:

image

image

cc @Expensify/design for viz

@shawnborton
Copy link
Contributor

Looks great to me, thanks Danny!

@dubielzyk-expensify
Copy link
Contributor

Thank you Danny! ❤️

@grgia grgia added Daily KSv2 and removed Weekly KSv2 labels Apr 22, 2024
@grgia
Copy link
Contributor

grgia commented Apr 22, 2024

They look SO GOOD @dannymcclain !

@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2024
@luacmartins
Copy link
Contributor Author

On hold

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Apr 24, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 20, 2024
Copy link

melvin-bot bot commented May 20, 2024

This issue has not been updated in over 15 days. @luacmartins, @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@trjExpensify
Copy link
Contributor

Putting this back on weekly, should be in a position after the freeze to deploy this I think.

@trjExpensify trjExpensify added Weekly KSv2 and removed Monthly KSv2 labels May 20, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 11, 2024
@melvin-bot melvin-bot bot changed the title [HOLD][Search v1] Update BottomTabBar [HOLD for payment 2024-06-18] [HOLD][Search v1] Update BottomTabBar Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-18. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-18] [HOLD][Search v1] Update BottomTabBar [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD][Search v1] Update BottomTabBar Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2024
@grgia grgia added Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Jun 19, 2024
Copy link

melvin-bot bot commented Jun 19, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@grgia
Copy link
Contributor

grgia commented Jun 19, 2024

@abekkala could you help with $500 C+ review payment to @fedirjh for #40293 (comment)

@abekkala abekkala changed the title [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD][Search v1] Update BottomTabBar [HOLD for payment 2024-06-20] [HOLD][Search v1] Update BottomTabBar Jun 20, 2024
@abekkala
Copy link
Contributor

@grgia @fedirjh get's paid via NewDot - this means that a Bug Zero team member does not process their payment in Upwork.

@abekkala
Copy link
Contributor

PAYMENT SUMMARY:

  • PR Review: @fedirjh [$500] - paid via NewDot

@JmillsExpensify
Copy link

$250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

9 participants