-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search v1] Implement Bottom Tab Bar Changes #40293
Conversation
@grgia we might either wanna hide this button or hold on merging this PR until the rest of the functionality is ready. |
@luacmartins We could just hold it since it also moves the global create button |
@WojtekBoman would you mind taking a look at the routes here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Seems like @shawnborton has some comments though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh @grgia one thing that I just remembered, with this PR we can also remove the navigation from the troubleshoot page -
App/src/components/TestToolMenu.tsx
Lines 96 to 105 in 8b71b1b
{/* Navigate to the new Search Page. This button is temporary and should be removed after passing QA tests. */} | |
<TestToolRow title="New Search Page"> | |
<Button | |
small | |
text="Navigate" | |
onPress={() => { | |
Navigation.navigate(ROUTES.SEARCH.getRoute(CONST.TAB_SEARCH.ALL)); | |
}} | |
/> | |
</TestToolRow> |
@shawnborton what size/padding should the FAB have? I can fix the flex row sizing but the button is bigger than that mock edit: I was looking at the profile icon 🙃 |
Done @luacmartins @shawnborton I fixed the even spacing and triggered a new test build for ya |
Dope, thanks Georgia! |
This comment has been minimized.
This comment has been minimized.
Styles look good to me! In theory, we could make tapping the entire tab area that surrounds the FAB tappable, but I don't feel too strongly since the FAB itself is quite big. |
Looking good to me too! I even have a (phantom 😩) RBR on my inbox and it looks dope.
Agree but also don't feel strongly at all. I'd be totally fine leaving it how it is TBH. |
This is looking great! 😄 |
@fedirjh please review this one when you're online. Let's get this one approved and ready to merge for the photo finish. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeCleanShot.2024-04-26.at.18.41.48.mp4Android: mWeb ChromeCleanShot.2024-04-26.at.18.39.15.mp4iOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-26.at.18.36.08.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-26.at.18.33.19.mp4MacOS: Chrome / SafariCleanShot.2024-04-26.at.18.17.24.mp4MacOS: DesktopCleanShot.2024-04-26.at.19.37.38.mp4 |
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all the designers have chimed in so I'm going to go ahead and approve from a design perspective! 🚀
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
Removing the hold and merging to get this feature out tomorrow and start testing! |
@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
hmm tests were passing when I merged it. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@@ -138,7 +138,7 @@ export default { | |||
magicCode: 'Código mágico', | |||
twoFactorCode: 'Autenticación de dos factores', | |||
workspaces: 'Espacios de trabajo', | |||
chats: 'Chats', | |||
inbox: 'Bandeja de entrada', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text overflows #42772 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s77rt do we have a fix for that yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix here #43429
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀
|
Rename Chats to Inbox, Add Search To Bottom Tab, Rearrange Icons
Details
Screen.Recording.2024-04-25.at.8.10.39.PM.mov
Screen.Recording.2024-04-25.at.8.15.52.PM.mov
Fixed Issues
$ #39886
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop