Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD][$250] Task - App scrolls to the top after returning from task report when there is IOU & task #40085

Closed
2 of 6 tasks
izarutskaya opened this issue Apr 11, 2024 · 53 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Apr 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new chat (no chat history).
  3. Create an IOU request.
  4. Create a task.
  5. Click on the task.
  6. Click on the header subtitle in task report.

Expected Result:

App will adjust the chat to show the highlighted task.

Actual Result:

App scrolls up to the top and it is not revealing the task.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6445418_1712812349862.bandicam_2024-04-11_13-08-30-567.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d7000bd5e3685039
  • Upwork Job ID: 1778383845658161152
  • Last Price Increase: 2024-04-18
  • Automatic offers:
    • shubham1206agra | Reviewer | 0
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 11, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@izarutskaya
Copy link
Author

@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@izarutskaya
Copy link
Author

Production

Recording.2367.mp4

@techievivek
Copy link
Contributor

Taking a look.

@techievivek
Copy link
Contributor

Ok, I am able to reproduce this bug. Seems like we have updated the URL signature when we click on the link in task view page.

@techievivek
Copy link
Contributor

It now has reportActionID as well?

@techievivek
Copy link
Contributor

techievivek commented Apr 11, 2024

I think we can remove the deploy blocker label from this since it doesn't look valuable to hold our deployment. However, this is indeed a regression from some recent changes. Maybe #13767?

@techievivek
Copy link
Contributor

Going to add external label.

@techievivek techievivek added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 11, 2024
@melvin-bot melvin-bot bot changed the title Task - App scrolls to the top after returning from task report when there is IOU & task [$250] Task - App scrolls to the top after returning from task report when there is IOU & task Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01d7000bd5e3685039

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

@lschurr
Copy link
Contributor

lschurr commented May 24, 2024

Hold.

@melvin-bot melvin-bot bot removed the Overdue label May 24, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2024
@lschurr
Copy link
Contributor

lschurr commented Jun 3, 2024

Hold

@melvin-bot melvin-bot bot removed the Overdue label Jun 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 11, 2024
@lschurr
Copy link
Contributor

lschurr commented Jun 11, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Jun 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 20, 2024
@lschurr
Copy link
Contributor

lschurr commented Jun 20, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Jun 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 1, 2024

On hold.

@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 9, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 9, 2024

On hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 18, 2024

Hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@techievivek
Copy link
Contributor

@perunt do you have any updates for this GH? Shall we still HOLD this?

@melvin-bot melvin-bot bot removed the Overdue label Jul 29, 2024
@perunt
Copy link
Contributor

perunt commented Jul 30, 2024

hey guys! Thanks for mentioning me
I've fixed a similar bug recently. Can we retest it?
What I have now:

Untitled.mov

@techievivek
Copy link
Contributor

Requested a re-test here https://expensify.slack.com/archives/C9YU7BX5M/p1722346767146919, thanks.

@m-natarajan
Copy link

Not reproducible by the tester.

bandicam.2024-07-30.23-10-18-489.mp4

@techievivek
Copy link
Contributor

Thanks for confirming, going to close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

9 participants