[HOLD for payment 2024-04-25] [$250] Tax - Not here page opens when clicking currency in tax amount in transaction thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.62-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #39562

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has tax enabled
3. Create a manual request with tax
4. Go to transaction thread
5. Click Tax amount
6. Click on the currency

Expected Result:

If the currency for tax amount is not supposed to be accessible in transaction thread, the currency should not be clickable (production behavior)

Actual Result:

The currency in tax amount in transaction thread is clickable, and it leads to not here page instead of currency list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445917_1712841997487.20240411_212019.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015297f4039458a835
• Upwork Job ID: 1778496247330332672
• Last Price Increase: 2024-04-11

[melvin-bot]

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The currency in tax amount in transaction thread is clickable, and it leads to not here page instead of currency list

What is the root cause of that problem?

We use the IOURequestTaxAmountPage for edit flow now but we always pass the action as create here

https://github.croom/Expensify/App/blob/8f90c2567f020ed924a96593244727aace9a7d72/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx#L109

What changes do you think we should make in order to solve the problem?

We should use action in route prop here instead of always passing create

 Navigation.navigate(
    ROUTES.MONEY_REQUEST_STEP_CURRENCY.getRoute(action, iouType, transactionID, reportID, backTo ? 'confirm' : '', Navigation.getActiveRouteWithoutParams()),
);

https://github.croom/Expensify/App/blob/8f90c2567f020ed924a96593244727aace9a7d72/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx#L109

What alternative solutions did you explore? (Optional)

isCurrencyPressable={!isEditing}

If we can't edit the currency of taxAmount, we should pass isCurrencyPressable as false into MoneyRequestAmountForm if we're editing the tax amount.

App/src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx

Line 160 in 8f90c25

<MoneyRequestAmountForm

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015297f4039458a835

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[NikkiWines]

Thanks for investigating @nkdengineer. Since we don't want the currency to be editable for the tax field, let's go with your alternate solution.

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

@mollfpr The PR is ready.

[thienlnam]

Should be fixed

[puneetlath]

So is there anything we need to do here or can we just close?

[thienlnam]

We'll need to do a payment to @nkdengineer / @mollfpr for the fix

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: unable click currency tax amount when editing #40159

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@mollfpr reminder about the checklist so we can pay in 2 days.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mollfpr owed $250 via NewDot
• ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1778496247330332672/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

@nkdengineer sent you an offer: https://www.upwork.com/nx/wm/offer/102031741. Please ping me on this issue when you've accepted.

@mollfpr waiting on checklist for you.

[nkdengineer]

Please ping me on this issue when you've accepted.

@puneetlath I accepted 🙏

[puneetlath]

Ok @nkdengineer has been paid.

@mollfpr still waiting on the checklist for you.

[mollfpr]

Sorry for the delay 🙏

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to the workspace chat that has tax-enabled
2. Create a manual request with tax
3. Go to the transaction thread
4. Click Tax amount
5. Click on the currency
6. Verify that: the currency should not be clickable
7. 👍 or 👎

[puneetlath]

Regression test issue here: https://github.com/Expensify/Expensify/issues/391684

Payment Summary:

@mollfpr requires payment through NewDot Manual Requests - C+ - $250
@nkdengineer paid through upwork - C - $250

@mollfpr please request on NewDot.

[JmillsExpensify]

$250 approved for @mollfpr