[$250] Workspace - Added non-existent members in WS disappear from the list.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.62-10
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Open https://staging.new.expensify.com/
2. Log in with a new HT account
3. Create a new WS
4. Add 6 non-existent users to the created WS
5. Navigate to the LHN chat menu
6. Go back to the list of WS members

Expected Result:

Added non-existent members in WS should be displayed in the list of members with their login and work chats with them should be displayed by their login

Actual Result:

Added non-existent members in WS disappear from the list of members, go to "Hidden" status after update, work chats with them are shown as "Chat Report" until you update them

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6451137_1713270950299.Recording__45.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012892de41a5162e21
• Upwork Job ID: 1780450224453574656
• Last Price Increase: 2024-04-17

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[lanitochka17]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[jliexpensify]

@lanitochka17 my staging version is v1.4.61-8 and I can't repro this. Going to see if C+ can.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012892de41a5162e21

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[jliexpensify]

Hi @mananjadhav - any chance you can repro this? My staging is not 1.4.62-10, is yours? Thanks!

[brunovjk]

We're working on "Allow arbitrary users to be added/removed to/from workspace chat via @mention or members list" and I'm facing the same issue. I believe it has to do with the server response.

@jasperhuangg what do you think?

[jliexpensify]

Thanks @brunovjk - assigning @jasperhuangg for his eyes on this issue.

[jasperhuangg]

Hmm yes, this does seem like a back-end issue, it appears the workspace members page skips showing users that don't have personal details set in Onyx.

 no personal details found for policy member with accountID

I can get a PR up to fix this.

[melvin-bot]

Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.

[jasperhuangg]

Hmm, it appears we are sending a personal details update, but the issue is that we don't consider the users that were created as "known" to the current user.

I'm unable to reproduce the issue where the users just disappear from workspace members list on dev, but I'm able to reproduce it on staging.

[jasperhuangg]

Very strange, it appears when adding a single non-existing user, it works, but if you try to add multiple non-existent users, then isKnown is returned as false so we don't send their full personal details.

[jasperhuangg]

@brunovjk @mananjadhav @jliexpensify

There seem to be two issues at play here:

• Invited non-existent users disappear from the members list shortly after being invited
• Invited non-existent users show as "Hidden" in the members list after being invited

I raised a PR to fix the latter, but I wasn't able to reproduce the former in dev. Let's wait to see after my PR is deployed to staging to see if anything changes.

[jasperhuangg]

@brunovjk thanks for that. You are able to reproduce because your dev environment points to our staging servers.

Might be another issue that I'll look into. For now let's wait for my changes to hit staging to see if you can still reproduce.

[brunovjk]

Nice 🙂 thank you 🚀

[jasperhuangg]

Just retested and the issue seems to have been fixed on staging when https://github.com/Expensify/Web-Expensify/pull/41771 went out

[jasperhuangg]

I think we can close this out once that PR hits prod

[brunovjk]

I can no longer reproduce.

[jliexpensify]

Thanks for checking @brunovjk - going to close this one now. Job removed from Upworks.