Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Clicking into a thread and out disappears message below the parent message #40376

Closed
1 of 6 tasks
m-natarajan opened this issue Apr 17, 2024 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62-14
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @johnmlee101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713370130959229

Action Performed:

  1. Open any report
  2. Click to the thread
  3. Click on the the header to return back to the message

Expected Result:

Should be taken back into the chat report. The URL shouldn't contain the messageID.

Actual Result:

Taken to just the parent chat message. URL has the messageID appended to it.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.13.mp4
Screen.Recording.2024-04-17.at.12.06.16.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dc0dcd6e681f7ef2
  • Upwork Job ID: 1780701535328817152
  • Last Price Increase: 2024-04-17
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 17, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@sakluger sakluger added Reviewing Has a PR in review and removed Reviewing Has a PR in review labels Apr 17, 2024
@sakluger
Copy link
Contributor

Yeah this is a legit deploy blocker! Adding external label for help finding out where it broke.

@sakluger sakluger added the External Added to denote the issue can be worked on by a contributor label Apr 17, 2024
@melvin-bot melvin-bot bot changed the title Clicking into a thread and out disappears message below the parent message [$250] Clicking into a thread and out disappears message below the parent message Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01dc0dcd6e681f7ef2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@rushatgabhane
Copy link
Member

Tested on latest main branch, the bug isn't reproducible.

Screen.Recording.2024-04-18.at.03.11.56.mov

@QichenZhu
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

The URL of the parent link in a thread header contains parentReportActionID.

What is the root cause of that problem?

The parentReportActionID in the URL is used to direct users back to the specific message in the parent and highlight that message.

This feature/bug was first introduced in this commit, and revised a few times later on. The current version is:

Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(parentReportID, parentReportActionID));

What changes do you think we should make in order to solve the problem?

If it's considered as a feature, leave it as it is.

If it's considered as a bug, revert it to its original version:

Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(parentReportID));

What alternative solutions did you explore? (Optional)

N/A

@srikarparsi
Copy link
Contributor

Hey @chiragsalian, do you think you could take a look at this? I think this is expected behavior from this but just want to make sure.

When you click the parent report in the header of a thread, the message id should be in the url right?

@rayane-djouah
Copy link
Contributor

Bug not reproducible on latest main:

Recording.2024-04-17.231044.mp4

@thienlnam thienlnam removed the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
@thienlnam
Copy link
Contributor

Screen.Recording.2024-04-17.at.9.06.11.PM.mov

Also seems to be fixed on staging

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 18, 2024
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Apr 23, 2024

I think this reappeared here: #40644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Hourly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants