-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Clicking into a thread and out disappears message below the parent message #40376
Comments
Triggered auto assignment to @sakluger ( |
Triggered auto assignment to @srikarparsi ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Yeah this is a legit deploy blocker! Adding external label for help finding out where it broke. |
Job added to Upwork: https://www.upwork.com/jobs/~01dc0dcd6e681f7ef2 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 ( |
Tested on latest Screen.Recording.2024-04-18.at.03.11.56.mov |
ProposalPlease re-state the problem that we are trying to solve in this issue.The URL of the parent link in a thread header contains parentReportActionID. What is the root cause of that problem?The parentReportActionID in the URL is used to direct users back to the specific message in the parent and highlight that message. This feature/bug was first introduced in this commit, and revised a few times later on. The current version is:
What changes do you think we should make in order to solve the problem?If it's considered as a feature, leave it as it is. If it's considered as a bug, revert it to its original version:
What alternative solutions did you explore? (Optional)N/A |
Hey @chiragsalian, do you think you could take a look at this? I think this is expected behavior from this but just want to make sure. When you click the parent report in the header of a thread, the message id should be in the url right? |
Bug not reproducible on latest main: Recording.2024-04-17.231044.mp4 |
Screen.Recording.2024-04-17.at.9.06.11.PM.movAlso seems to be fixed on staging |
I think this reappeared here: #40644 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.62-14
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @johnmlee101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713370130959229
Action Performed:
Expected Result:
Should be taken back into the chat report. The URL shouldn't contain the messageID.
Actual Result:
Taken to just the parent chat message. URL has the messageID appended to it.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Recording.13.mp4
Screen.Recording.2024-04-17.at.12.06.16.PM.mov
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: