[HOLD for payment 2024-05-06] [HOLD for payment 2024-05-03] CRITICAL: [Actionable Whispers] [$500] Workspace list doesn't show up after creating a workspace for categorize it

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.62-13
Reproducible in staging?: Yes
Reproducible in production?: No, new feature
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a new account
3. Go to your space
4. Create a manual track expense
5. Click on Categorize it
6. Click on Learn more and create a new workspace
7. Go to your space and click on Categorize it again

Expected Result:

The newly created workspace should show up

Actual Result:

No workspace found shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453302_1713425679307.bandicam_2024-04-18_09-52-30-637.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012e058847a79bee4c
• Upwork Job ID: 1781103150081294336
• Last Price Increase: 2024-04-19
• Automatic offers:
• c3024 | Reviewer | 0
• tienifr | Contributor | 0

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[shubham1206agra]

@ishpaul777 I remember this is a known issue.
Link https://expensify.slack.com/archives/C049HHMV9SM/p1713185937683679

[puneetlath]

@shubham1206agra I don't totally follow. Are you saying this is expected and not a deploy blocker?

[thienlnam]

I don't think this needs to block deploy, it is a new feature - I think this only happens with new workspaces and is only sometimes reproducible. We can probably make this external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012e058847a79bee4c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[thienlnam]

I can also take this over since it's related to track - but feel free to re-assign if you're interested

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.66-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix workspace list does not show #40730

If no regressions arise, payment will be issued on 2024-05-03. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove maxRecentReportsToShow limit for categorize and share actions for track expense  #41009

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Reviewer)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@c3024 bump on the checklist.

@tienifr has been paid.

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: Fix: update options when creating task #39811
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: tienifr@ceff19e#r141766551
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion has been started because this bug is too specific and could not have been caught in a checklist.
• [@c3024] Determine if we should create a regression test for this bug. Yes
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Log on to New Dot with a new account
2. Go to Your space
3. Create a manual track expense
4. Click on Categorize it in the whisper received
5. Click on Learn more and create a new workspace
6. Go to Your space again and click on Categorize it again
7. Verify that the newly created workspace shows up in the list

👍 or 👎

[puneetlath]

Issue for regression test: https://github.com/Expensify/Expensify/issues/393986

Everyone has been paid. Thanks!

[ishpaul777]

@puneetlath I reviewed one of the PR #41009 can we please reopen for payment?

[puneetlath]

Ah ok. So there were two PRs for this issue? @thienlnam can you confirm who all needs to be paid out here?

[thienlnam]

This PR fixes what was described in the issue description
#40730

I thought this wasn't solved when I was testing it here, but turns out there was a different problem with the limit of workspaces shown in the selector which was fixed #41009

[thienlnam]

@c3024 worked on both PRs, so we could give them another payment for this PR, and have a payment to @ishpaul777 for being the C+ on that PR as well

[puneetlath]

Ok so it's:

• $500 for @tienifr for fix workspace list does not show #40730 (already paid)
• $500 for @c3024 for fix workspace list does not show #40730 (already paid)
• $500 for @c3024 for remove maxRecentReportsToShow limit for categorize and share actions for track expense  #41009
• $500 for @ishpaul777 for remove maxRecentReportsToShow limit for categorize and share actions for track expense  #41009

Is that right?

[thienlnam]

Yup that's correct

[puneetlath]

Ok @tienifr and @c3024 are now fully paid.

@ishpaul777 sent you an offer: https://www.upwork.com/nx/wm/offer/102304232

Ping me here when you've accepted please.

[ishpaul777]

Thanks! accepted the offer 😄

[puneetlath]

Ok all paid. Thanks everyone!